ci: use Clang 16 for Valgrind #29848

1. 
   fanquake commented at 8:10 am on April 11, 2024: member

   Switch to Ubuntu Noble. Valgrind 3.19 -> 3.22 Clang 14 -> Clang 16
2. 
   DrahtBot commented at 8:10 am on April 11, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	maflcko
   Concept ACK	theuni

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #29790 ([DO NOT MERGE] cmake: Migrate CI scripts to CMake-based build system – WIP by hebasto)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

3. DrahtBot added the label Tests on Apr 11, 2024
4. 
   maflcko commented at 8:53 am on April 11, 2024: member

   lgtm ACK 9996fba412f2d6d0e899906e8b3c387ef9d199d3

   Didn’t test

5. 
   theuni commented at 12:33 pm on April 11, 2024: member

   Concept ACK
6. ci: use clang-16 for Valgrind

   Switch to Ubuntu Noble.

   ad21f22948
7. in ci/test/00_setup_env_native_valgrind.sh:14 in 9996fba412 outdated

   11 export CONTAINER_NAME=ci_native_valgrind
   12-export PACKAGES="valgrind clang llvm libclang-rt-dev python3-zmq libevent-dev libboost-dev libdb5.3++-dev libminiupnpc-dev libnatpmp-dev libzmq3-dev libsqlite3-dev"
   13+export PACKAGES="valgrind clang-16 llvm-16 libclang-rt-16-dev python3-zmq libevent-dev libboost-dev libdb5.3++-dev libminiupnpc-dev libnatpmp-dev libzmq3-dev libsqlite3-dev"
   14 export USE_VALGRIND=1
   15 export NO_DEPENDS=1
   16 export TEST_RUNNER_EXTRA="--exclude feature_init,rpc_bind,feature_bind_extra"  # Excluded for now, see https://github.com/bitcoin/bitcoin/issues/17765#issuecomment-602068547
   

   ---

   ---

   

   maflcko commented at 7:58 am on April 13, 2024:

   0export TEST_RUNNER_EXTRA="--exclude rpc_bind,feature_bind_extra"  # Excluded for now, see [#17765 (comment)](/bitcoin-bitcoin/17765/#issuecomment-602068547)
   

   unrelated, but this was fixed a while ago

   ---

   

   fanquake commented at 9:41 am on April 14, 2024:

   Added
8. fanquake force-pushed on Apr 14, 2024
9. 
   maflcko commented at 10:27 am on April 14, 2024: member

   lgtm ACK ad21f2294821d7c436e58a8f199fb555b11a56ad
10. DrahtBot requested review from theuni on Apr 14, 2024
11. fanquake merged this on Apr 15, 2024
12. fanquake closed this on Apr 15, 2024

    ---

13. fanquake deleted the branch on Apr 15, 2024

Contributors
fanquake DrahtBot maflcko theuni

Review Requested
theuni

Labels
Tests