net: Decrease nMaxIPs when learning from DNS seeds #29850

pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2024-04-dnsseeds-up-to-32 changing 1 files +5 −1
  1. laanwj commented at 12:45 pm on April 11, 2024: member

    Limit number of IPs learned from a single DNS seed to 32, to prevent the results from one DNS seed from dominating AddrMan. Note that the number of results from a UDP DNS query is bounded to 33 already, but it is possible for it to use TCP where a larger number of results can be returned.

    Closes #16070.

  2. net: Decrease nMaxIPs when learning from DNS seeds
    Limit number of IPs learned from a single DNS seed to 32, to prevent the results from
    one DNS seed from dominating AddrMan. Note that the number of results from a UDP DNS query is
    bounded to 33 already, but it is possible for it to use TCP where a potentially enormous
    number of results can be returned.
    
    Closes #16070.
    f2e3662e57
  3. laanwj added the label P2P on Apr 11, 2024
  4. DrahtBot commented at 12:45 pm on April 11, 2024: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage

    For detailed information about the code coverage, see the test coverage report.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK 1440000bytes, Sjors, mzumsande, achow101
    Concept ACK luke-jr

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #29605 (net: Favor peers from addrman over fetching seednodes by sr-gi)
    • #28016 (p2p: gives seednode priority over dnsseed if both are provided by sr-gi)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  5. 1440000bytes approved
  6. Sjors commented at 7:27 am on April 18, 2024: member
    utACK f2e3662e57eca1330962faf38ff428a564d50a11
  7. fanquake requested review from mzumsande on Apr 18, 2024
  8. luke-jr approved
  9. luke-jr commented at 1:59 am on April 21, 2024: member
    utACK
  10. mzumsande commented at 11:00 pm on April 21, 2024: contributor
    utACK f2e3662e57eca1330962faf38ff428a564d50a11
  11. DrahtBot requested review from luke-jr on Apr 21, 2024
  12. achow101 commented at 4:09 pm on April 22, 2024: member
    ACK f2e3662e57eca1330962faf38ff428a564d50a11
  13. achow101 merged this on Apr 22, 2024
  14. achow101 closed this on Apr 22, 2024

  15. luke-jr referenced this in commit 7af5125276 on Apr 24, 2024
  16. sr-gi commented at 3:22 pm on April 25, 2024: member
    Post-merge ACK f2e3662e57eca1330962faf38ff428a564d50a11

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-11 03:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me