Switch release builds to using GCC 13.3.0: https://gcc.gnu.org/gcc-13/, which landed in Guix in: https://git.savannah.gnu.org/cgit/guix.git/commit/?id=750148ce1ea6c65a7c14424546db0078161f7e17.
Does not solve the cross-arch non-determinism for powerpc64le-linux-gnu builds.
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
For detailed information about the code coverage, see the test coverage report.
See the guideline for information on the review process. A summary of reviews will appear here.
No conflicts as of last run.
CI should be bumped as well, if this is taken out of draft.
Added a (WIP) commit to bump a couple CIs to 13.2.0. Also bumped the time-machine further, now that we’ve upstreamed GCC 13.3.0: https://git.savannah.gnu.org/cgit/guix.git/commit/?id=750148ce1ea6c65a7c14424546db0078161f7e17.
Looks like Windows still has false positives with GCC 13.2.0 (https://github.com/bitcoin/bitcoin/pull/29881/checks?check_run_id=25320716500):
0torcontrol.cpp: In static member function ‘static void TorControlConnection::readcb(bufferevent*, void*)’:
1torcontrol.cpp:94:28: error: ‘result’ may be used uninitialized [-Werror=maybe-uninitialized]
2 94 | self->message.code = ToIntegral<int>(s.substr(0, 3)).value_or(0);
3 | ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
4In file included from ./netaddress.h:14,
5 from ./torcontrol.h:11,
6 from torcontrol.cpp:6:
7./util/strencodings.h:184:7: note: ‘result’ was declared here
8 184 | T result;
9 | ^~~~~~
10cc1plus: all warnings being treated as errors
11make[2]: *** [Makefile:11115: libbitcoin_node_a-torcontrol.o] Error 1
Will re-add -Wno-error=maybe-uninitialized.
🚧 At least one of the CI tasks failed. Make sure to run all tests locally, according to the documentation.
Possibly this is due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.
Leave a comment here, if you need help tracking down a confusing failure.
🚧 At least one of the CI tasks failed. Make sure to run all tests locally, according to the documentation.
Possibly this is due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.
Leave a comment here, if you need help tracking down a confusing failure.
6@@ -7,13 +7,10 @@
7 export LC_ALL=C.UTF-8
8
9 export CONTAINER_NAME=ci_win64
10-export CI_IMAGE_NAME_TAG="docker.io/amd64/debian:bookworm" # Check that https://packages.debian.org/bookworm/g++-mingw-w64-x86-64-posix (version 12.2, similar to guix) can cross-compile
11+export CI_IMAGE_NAME_TAG="docker.io/amd64/debian:trixie" # Check that https://packages.debian.org/trixie/g++-mingw-w64-x86-64-posix (version 13.2, similar to guix) can cross-compile
debian:trixie?
I ran the task 10 times, and it failed consistently, so I don’t think it is the same bug:
or do you need https://packages.debian.org/trixie/mingw-w64-x86-64-dev ?
Yea at some point (#30210), we’ll need the newer version, I’ll switch to Noble here, and see if things are still broken.
16 export RUN_UNIT_TESTS=true
17 export RUN_FUNCTIONAL_TESTS=false
18 export GOAL="install"
19 # -Wno-psabi is to disable ABI warnings: "note: parameter passing for argument of type ... changed in GCC 7.1"
20 # This could be removed once the ABI change warning does not show up by default
21-export BITCOIN_CONFIG="--enable-reduce-exports CXXFLAGS='-Wno-psabi -Wno-error=maybe-uninitialized'"
from CI:
0bitcoin-cli.cpp:767:13: error: ‘result’ may be used uninitialized [-Werror=maybe-uninitialized]
Labels
Build system