Switch release builds to using GCC 13.3.0: https://gcc.gnu.org/gcc-13/, which landed in Guix in: https://git.savannah.gnu.org/cgit/guix.git/commit/?id=750148ce1ea6c65a7c14424546db0078161f7e17.
Does not solve the cross-arch non-determinism for powerpc64le-linux-gnu builds.
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/29881.
See the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
No conflicts as of last run.
CI should be bumped as well, if this is taken out of draft.
Added a (WIP) commit to bump a couple CIs to 13.2.0. Also bumped the time-machine further, now that we’ve upstreamed GCC 13.3.0: https://git.savannah.gnu.org/cgit/guix.git/commit/?id=750148ce1ea6c65a7c14424546db0078161f7e17.
Looks like Windows still has false positives with GCC 13.2.0 (https://github.com/bitcoin/bitcoin/pull/29881/checks?check_run_id=25320716500):
0torcontrol.cpp: In static member function ‘static void TorControlConnection::readcb(bufferevent*, void*)’:
1torcontrol.cpp:94:28: error: ‘result’ may be used uninitialized [-Werror=maybe-uninitialized]
2 94 | self->message.code = ToIntegral<int>(s.substr(0, 3)).value_or(0);
3 | ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
4In file included from ./netaddress.h:14,
5 from ./torcontrol.h:11,
6 from torcontrol.cpp:6:
7./util/strencodings.h:184:7: note: ‘result’ was declared here
8 184 | T result;
9 | ^~~~~~
10cc1plus: all warnings being treated as errors
11make[2]: *** [Makefile:11115: libbitcoin_node_a-torcontrol.o] Error 1
Will re-add -Wno-error=maybe-uninitialized.
🚧 At least one of the CI tasks failed. Make sure to run all tests locally, according to the documentation.
Possibly this is due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.
Leave a comment here, if you need help tracking down a confusing failure.
🚧 At least one of the CI tasks failed. Make sure to run all tests locally, according to the documentation.
Possibly this is due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.
Leave a comment here, if you need help tracking down a confusing failure.
6@@ -7,13 +7,10 @@
7 export LC_ALL=C.UTF-8
8
9 export CONTAINER_NAME=ci_win64
10-export CI_IMAGE_NAME_TAG="docker.io/amd64/debian:bookworm" # Check that https://packages.debian.org/bookworm/g++-mingw-w64-x86-64-posix (version 12.2, similar to guix) can cross-compile
11+export CI_IMAGE_NAME_TAG="docker.io/amd64/debian:trixie" # Check that https://packages.debian.org/trixie/g++-mingw-w64-x86-64-posix (version 13.2, similar to guix) can cross-compile
debian:trixie?
I ran the task 10 times, and it failed consistently, so I don’t think it is the same bug:
or do you need https://packages.debian.org/trixie/mingw-w64-x86-64-dev ?
Yea at some point (#30210), we’ll need the newer version, I’ll switch to Noble here, and see if things are still broken.
16 export RUN_UNIT_TESTS=true
17 export RUN_FUNCTIONAL_TESTS=false
18 export GOAL="install"
19 # -Wno-psabi is to disable ABI warnings: "note: parameter passing for argument of type ... changed in GCC 7.1"
20 # This could be removed once the ABI change warning does not show up by default
21-export BITCOIN_CONFIG="--enable-reduce-exports CXXFLAGS='-Wno-psabi -Wno-error=maybe-uninitialized'"
from CI:
0bitcoin-cli.cpp:767:13: error: ‘result’ may be used uninitialized [-Werror=maybe-uninitialized]
What is the status/expectation of this? I presume at some point the switch will happen either way and right now it is just waiting for a good enough reason?
According to #30997 (comment), it may be required for qt6.8
Also, in the title “builds” should say “build”?
What is the status/expectation of this? I presume at some point the switch will happen either way and right now it is just waiting for a good enough reason?
The status is mostly that. It has been useful to push occasionally and see what breaks. If there are some new compelling reasons to switch we could consider it. I’ll take it out of draft, and if anyone wants to leave (conceptual) review they can.
ACK f9e0010de394ad6ae5eb6a22ead7ebc116a16fd4.
Guix build (on both x86_64 and aarch64):
0d6a2d55943232d35bc56c36341b8501af7637c1f337a1e49f2ac34baced7d884 guix-build-f9e0010de394/output/aarch64-linux-gnu/SHA256SUMS.part
13bbb9714ea3196a2fca7f2d8db8a309bc298b43ace4397f11ff8acc8b6d829d3 guix-build-f9e0010de394/output/aarch64-linux-gnu/bitcoin-f9e0010de394-aarch64-linux-gnu-debug.tar.gz
26b5402883ebef604c6c1da21d81d9414e731be41bf294a3a92f5fb5ff5be300b guix-build-f9e0010de394/output/aarch64-linux-gnu/bitcoin-f9e0010de394-aarch64-linux-gnu.tar.gz
3ad6cdd7f5ef5c9b28fe0bba69c865ba3bd23cc1edf4877358fb89a7ab4cd1f28 guix-build-f9e0010de394/output/arm-linux-gnueabihf/SHA256SUMS.part
41da99dc69b3d89a74802c8a296aea2ed60d60e5fecd1260b382bdea61b823246 guix-build-f9e0010de394/output/arm-linux-gnueabihf/bitcoin-f9e0010de394-arm-linux-gnueabihf-debug.tar.gz
5dae270589b146e9a6c3f66dbb6fdfd53fc7ea0dfe6299be8a61dfca964cd91e9 guix-build-f9e0010de394/output/arm-linux-gnueabihf/bitcoin-f9e0010de394-arm-linux-gnueabihf.tar.gz
61048c4f346f919803f2b4c6c3b06057b8a45b3abf8637378ba46aca90571764f guix-build-f9e0010de394/output/arm64-apple-darwin/SHA256SUMS.part
7b223dd80252a6c78fbf2a4b482ab6c2c56d11ba18aa07345276cf218d0f76c4e guix-build-f9e0010de394/output/arm64-apple-darwin/bitcoin-f9e0010de394-arm64-apple-darwin-unsigned.tar.gz
8a957376d954e844078ef2cd3728ffbe5c382b7411978bd3150d0d95fd45763e1 guix-build-f9e0010de394/output/arm64-apple-darwin/bitcoin-f9e0010de394-arm64-apple-darwin-unsigned.zip
9cc9abb15a467bd983db82595e623e1d99b42d3b5988cd28788b96b96305baf98 guix-build-f9e0010de394/output/arm64-apple-darwin/bitcoin-f9e0010de394-arm64-apple-darwin.tar.gz
10c96414b0de37dd22c594576847457665394beca1a3da845fd214bbbe178c45d8 guix-build-f9e0010de394/output/dist-archive/bitcoin-f9e0010de394.tar.gz
119786e7e52a136e16ee2b8a3b09b9356b2108fb74c0dfade4bf7535a6997410b7 guix-build-f9e0010de394/output/powerpc64-linux-gnu/SHA256SUMS.part
12bd9c77b7298444a8c8ad97966c7726caab1cb9ea17d1b970a2f9692b7a62346e guix-build-f9e0010de394/output/powerpc64-linux-gnu/bitcoin-f9e0010de394-powerpc64-linux-gnu-debug.tar.gz
13c9ab6cc342cf034132567da7c010fc703f2d848526d8e4ffc0ba454568891461 guix-build-f9e0010de394/output/powerpc64-linux-gnu/bitcoin-f9e0010de394-powerpc64-linux-gnu.tar.gz
149f9edfaf745f2967962b3c2be3be1b21953e129f2a508c60641a5ee08b4b3462 guix-build-f9e0010de394/output/riscv64-linux-gnu/SHA256SUMS.part
150f1310eb1e1d4cf42bff2b90f0996bfc6c3b3b4e0ac09576db62b6ef62c47d1f guix-build-f9e0010de394/output/riscv64-linux-gnu/bitcoin-f9e0010de394-riscv64-linux-gnu-debug.tar.gz
16b14e2681db33c375ee556c6adf047a431b2d149c53f731f118c52dbb30f7d7b9 guix-build-f9e0010de394/output/riscv64-linux-gnu/bitcoin-f9e0010de394-riscv64-linux-gnu.tar.gz
17ad0f4fd69c6b50a30f1ff78c057f677e5636e099d7189282f6421f4e6772bf6b guix-build-f9e0010de394/output/x86_64-apple-darwin/SHA256SUMS.part
18edec2b4151f471d643f68460630b29a57c154b9a9d9bddc9f6f3f3515cc37d7f guix-build-f9e0010de394/output/x86_64-apple-darwin/bitcoin-f9e0010de394-x86_64-apple-darwin-unsigned.tar.gz
19504e796315063a104c1973a8d0f87fbfa50d364c421c5e12d79d3e0a7a2f90cc guix-build-f9e0010de394/output/x86_64-apple-darwin/bitcoin-f9e0010de394-x86_64-apple-darwin-unsigned.zip
20eef8c4e151d2f7ae13d9b0c626284479f7397ee61175ab16e74dee3adb384389 guix-build-f9e0010de394/output/x86_64-apple-darwin/bitcoin-f9e0010de394-x86_64-apple-darwin.tar.gz
21fda7912057f4fe26ef3b280813b9da57456d9762a016d87721494a662414f200 guix-build-f9e0010de394/output/x86_64-linux-gnu/SHA256SUMS.part
2259c3ded87dcbe0a6985c25ee9444c836c5057563d011b0cc3d68762990fa5114 guix-build-f9e0010de394/output/x86_64-linux-gnu/bitcoin-f9e0010de394-x86_64-linux-gnu-debug.tar.gz
23f34bfae8fdc350c29d9f5eb17e3792df85aa98803c52496dfce59d139ae08b08 guix-build-f9e0010de394/output/x86_64-linux-gnu/bitcoin-f9e0010de394-x86_64-linux-gnu.tar.gz
24880646936419bad130b4fbfedcbe5e196159122fc174385860d6307f851c0ec5 guix-build-f9e0010de394/output/x86_64-w64-mingw32/SHA256SUMS.part
25ef2c587706867d498c58e0b26810146912181f7cdf505b9de7a9380beb8c4a38 guix-build-f9e0010de394/output/x86_64-w64-mingw32/bitcoin-f9e0010de394-win64-debug.zip
268288063ed94023f92f3dbba49ca0ef222cc6716b82dcf3d259e197fcbfc0532c guix-build-f9e0010de394/output/x86_64-w64-mingw32/bitcoin-f9e0010de394-win64-setup-unsigned.exe
2701451eeaa8f9431a9e2e0ca9d873d8a83b4f220312f1808070d9c01d285b11d8 guix-build-f9e0010de394/output/x86_64-w64-mingw32/bitcoin-f9e0010de394-win64-unsigned.tar.gz
2844190f48b8551bc5e2d76bd5a28b813a58c050a3c1404eafe70660e4ef5ad7ce guix-build-f9e0010de394/output/x86_64-w64-mingw32/bitcoin-f9e0010de394-win64.zip
[WIP] from the CI commit.
Guix Build (x86_64 & aarch64):
0c27a601dbc89ed3abccb6f742178f15f0eb256cd5086d8360dd6727c9c866cab guix-build-a4e17239ca54/output/aarch64-linux-gnu/SHA256SUMS.part
10fdb1ff5320398ec5cf6378f72c826c619909e1079a9e8ab871bac938db41c0e guix-build-a4e17239ca54/output/aarch64-linux-gnu/bitcoin-a4e17239ca54-aarch64-linux-gnu-debug.tar.gz
260f6d4f34f3d5af5aeb6cf678a6f2ca60035d52cf8c48b3dbea7a54a8ce89776 guix-build-a4e17239ca54/output/aarch64-linux-gnu/bitcoin-a4e17239ca54-aarch64-linux-gnu.tar.gz
3be804999c04a0b68aae2fb98d855940c9629ede7d915b061f266576d3449d8bb guix-build-a4e17239ca54/output/arm-linux-gnueabihf/SHA256SUMS.part
43b4d1dfcdca2bc4e7ad1a5cc843171e57020e51e2e1c4c7c9247019b2698c352 guix-build-a4e17239ca54/output/arm-linux-gnueabihf/bitcoin-a4e17239ca54-arm-linux-gnueabihf-debug.tar.gz
5628265ac50ec6f1e5bb23175975f4da4fb01d4ae1eb935cf42bceab2c228a28f guix-build-a4e17239ca54/output/arm-linux-gnueabihf/bitcoin-a4e17239ca54-arm-linux-gnueabihf.tar.gz
6fcbf15d734200d05da373c102b26e1ca9bff72177fb7e2624c7f65701ad91e20 guix-build-a4e17239ca54/output/arm64-apple-darwin/SHA256SUMS.part
7267297308e1499090f5410d6c6206e581caed37638a4ce2a4f4d91afe787e7cb guix-build-a4e17239ca54/output/arm64-apple-darwin/bitcoin-a4e17239ca54-arm64-apple-darwin-unsigned.tar.gz
8e84aade8d6b91ff00aefdb060b15ac6884b5954027bc8356deb346a1d221b272 guix-build-a4e17239ca54/output/arm64-apple-darwin/bitcoin-a4e17239ca54-arm64-apple-darwin-unsigned.zip
92d9dc9de892ac7dc7dff5a1ed5205a74569126525b86ed8af47fffafe2be2129 guix-build-a4e17239ca54/output/arm64-apple-darwin/bitcoin-a4e17239ca54-arm64-apple-darwin.tar.gz
10e20c4ae1abc8d9ce383b65b8b0bdd47575dfd1c059ff6d43a5905e1a4739da96 guix-build-a4e17239ca54/output/dist-archive/bitcoin-a4e17239ca54.tar.gz
1175d908891160ee1021d74f4f67faace4dfdd3e4be26e7ec498b1d189e64f7f79 guix-build-a4e17239ca54/output/powerpc64-linux-gnu/SHA256SUMS.part
121ec141bec169cd24b8842c49306286dc8746a89ff122e3707fcd7adf6a02a736 guix-build-a4e17239ca54/output/powerpc64-linux-gnu/bitcoin-a4e17239ca54-powerpc64-linux-gnu-debug.tar.gz
13913725fe2ce813f2a95aacb1037eb4f7a999693554aef15d0fe5b7b9683c9c35 guix-build-a4e17239ca54/output/powerpc64-linux-gnu/bitcoin-a4e17239ca54-powerpc64-linux-gnu.tar.gz
145356f158e68d4ea85f23cbabbd7071df101228d86a9ef82f5554ab97ed5b09d9 guix-build-a4e17239ca54/output/riscv64-linux-gnu/SHA256SUMS.part
152c8a9b4b7d89477f00b663eef2acde319e0a4bf0349ed3484d320196cb8e0b58 guix-build-a4e17239ca54/output/riscv64-linux-gnu/bitcoin-a4e17239ca54-riscv64-linux-gnu-debug.tar.gz
16f03e880d97780927fe2c2e0ea53d81515526f0050400150e5b8e5682f45bb28e guix-build-a4e17239ca54/output/riscv64-linux-gnu/bitcoin-a4e17239ca54-riscv64-linux-gnu.tar.gz
1719808b9433aed4a63ab202cf2fe946b045d533ef32e6811673ce4c2448d0cf48 guix-build-a4e17239ca54/output/x86_64-apple-darwin/SHA256SUMS.part
186d821208971b002c9e7b2e4a7ff34a5324175716a528ecc7a572dffaee9666f6 guix-build-a4e17239ca54/output/x86_64-apple-darwin/bitcoin-a4e17239ca54-x86_64-apple-darwin-unsigned.tar.gz
192783bcc1741ff182605acd4b1b860ae3110defd1afd2173c663b7305c3952977 guix-build-a4e17239ca54/output/x86_64-apple-darwin/bitcoin-a4e17239ca54-x86_64-apple-darwin-unsigned.zip
20d9e39e1264c672079502716b3adeb30c35f9332c1b767a0a37273dbaeac0295d guix-build-a4e17239ca54/output/x86_64-apple-darwin/bitcoin-a4e17239ca54-x86_64-apple-darwin.tar.gz
219d0ec4b097cb2d1b3aa480ae2f7e4c03f3b07a09b0f134f745dd451d36d0bb05 guix-build-a4e17239ca54/output/x86_64-linux-gnu/SHA256SUMS.part
229460e787ee27c5b0e8db6a35b03ad766a60da1d16795fcbca50befc8a645de27 guix-build-a4e17239ca54/output/x86_64-linux-gnu/bitcoin-a4e17239ca54-x86_64-linux-gnu-debug.tar.gz
2307bc463ebb5ca089a2b072f25902c2a5e4a44f03dc397c99a4b7a3a3da0a4bb3 guix-build-a4e17239ca54/output/x86_64-linux-gnu/bitcoin-a4e17239ca54-x86_64-linux-gnu.tar.gz
246085306bf8bd4e37d02240efb41a06932879c7e8b7e7b1ec7e56414afd755d6d guix-build-a4e17239ca54/output/x86_64-w64-mingw32/SHA256SUMS.part
25afe1a3a59693d35c71b32c44205fbbc0afdae7154956cacc8a0f30bea36e6215 guix-build-a4e17239ca54/output/x86_64-w64-mingw32/bitcoin-a4e17239ca54-win64-debug.zip
26d00bade6058859f1e5496c5fbdd4cda076751146fb863c2a6337d19c564e7560 guix-build-a4e17239ca54/output/x86_64-w64-mingw32/bitcoin-a4e17239ca54-win64-setup-unsigned.exe
274b224d49a94bba8a4a5d534c2d063599387760a3bda21866b06e2d8402d1dd67 guix-build-a4e17239ca54/output/x86_64-w64-mingw32/bitcoin-a4e17239ca54-win64-unsigned.tar.gz
28bfbdefa110cde6cce791c86bca46b17a0f2dcb5f69dccc84593b5d1500664e90 guix-build-a4e17239ca54/output/x86_64-w64-mingw32/bitcoin-a4e17239ca54-win64.zip
In a `x86_64-linux-gnu` build, this drops:
```bash
x86_64-linux-gnu/bin/x86_64-linux-gnu-gcov
x86_64-linux-gnu/bin/x86_64-linux-gnu-gcov-dump
x86_64-linux-gnu/bin/x86_64-linux-gnu-gcov-tool
```
For mingw-w64-gcc, `--disable-gcov` is currently passed for this
target in Guix, due to issues with mingw-w64, see
https://github.com/fanquake/guix/blob/8bed031e58c9cf895d243790e7c80808b0075de7/gnu/packages/gcc.scm#L99-L102.
However we'll add it in any case, in case it's re-enabled in future,
when the underlying issues are fixed.