refactor: Rename subprocess.hpp to follow our header name conventions #29910

1. 
   hebasto commented at 9:47 am on April 19, 2024: member

   This PR renames the header *.hpp –> *.h and adjusts the header guard name, which makes it available for processing by linters.

   Fixed the following linter warning:

   0The locale dependent function strerror(...) appears to be used:
   1src/util/subprocess.h:    std::runtime_error( err_msg + ": " + std::strerror(err_code) )
   2
   3Unnecessary locale dependence can cause bugs that are very tricky to isolate and fix. Please avoid using locale-dependent functions if possible.
   4
   5Advice not applicable in this specific case? Add an exception by updating the ignore list in /bitcoin/test/lint/lint-locale-dependence.py
   6^---- failure generated from lint-locale-dependence.py
   

2. 
   DrahtBot commented at 9:47 am on April 19, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	TheCharlatan
   Concept ACK	theStack

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   No conflicts as of last run.

3. hebasto force-pushed on Apr 19, 2024
4. 
   fanquake commented at 9:52 am on April 19, 2024: member

   Why not put the windows change with the windows change: #29868 ? Looks like the other change could just be PR’d on it’s own, and doesn’t need to be based on anything? Avoiding conflicts doesn’t seem necessary given this branch already conflicts as-is?
5. hebasto force-pushed on Apr 19, 2024
6. hebasto renamed this:
   Refactor `subprocess.hpp` to follow our conventions
   refactor: Rename `subprocess.hpp` to follow our header name conventions
   on Apr 19, 2024
7. DrahtBot added the label Refactoring on Apr 19, 2024
8. hebasto marked this as ready for review on Apr 19, 2024
9. 
   hebasto commented at 10:04 am on April 19, 2024: member

   Why not put the windows change with the windows change: #29868 ? Looks like the other change could just be PR’d on it’s own, and doesn’t need to be based on anything? Avoiding conflicts doesn’t seem necessary given this branch already conflicts as-is?

   Thanks! Reworked per your suggestions.

10. 
    hebasto commented at 10:06 am on April 19, 2024: member

    Drafted again until resolving a linter warning. (The header is processed by linters now).
11. hebasto marked this as a draft on Apr 19, 2024
12. 
    DrahtBot commented at 10:21 am on April 19, 2024: contributor

    🚧 At least one of the CI tasks failed. Make sure to run all tests locally, according to the documentation.

    Possibly this is due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.

    Leave a comment here, if you need help tracking down a confusing failure.

    Debug: https://github.com/bitcoin/bitcoin/runs/24018238387

13. DrahtBot added the label CI failed on Apr 19, 2024
14. 
    hebasto commented at 10:40 am on April 19, 2024: member

    Drafted again until resolving a linter warning. (The header is processed by linters now).

    Linter warnings have been resolved. But the PR remains as a draft because the #29865 will make the diff smaller.

15. DrahtBot removed the label CI failed on Apr 19, 2024
16. refactor: Rename `subprocess.hpp` to follow our header name conventions d8e4ba4d05
17. Replace locale-dependent `std::strerror` with `SysErrorString` 08f756bd37
18. hebasto force-pushed on Apr 23, 2024
19. hebasto marked this as ready for review on Apr 23, 2024
20. 
    hebasto commented at 5:25 pm on April 23, 2024: member

    Rebased and undrafted.
21. hebasto force-pushed on Apr 23, 2024
22. 
    theStack commented at 5:33 pm on April 23, 2024: contributor

    Concept ACK
23. 
    TheCharlatan commented at 9:04 am on April 24, 2024: contributor

    Resolved linter warnings.

    Can you mention this in the PR description?

24. 
    hebasto commented at 2:13 pm on April 24, 2024: member

    Resolved linter warnings.

    Can you mention this in the PR description?

    Thanks! The PR description has been updated.

25. TheCharlatan approved
26. 
    TheCharlatan commented at 2:22 pm on April 24, 2024: contributor

    ACK 08f756bd370c3e100b186c7e24bef6a033575b29
27. DrahtBot requested review from theStack on Apr 24, 2024
28. fanquake merged this on Apr 24, 2024
29. fanquake closed this on Apr 24, 2024

    ---

30. hebasto deleted the branch on Apr 24, 2024

Contributors
hebasto DrahtBot fanquake theStack TheCharlatan

Review Requested
theStack

Labels
Refactoring