test: Don’t fetch orphan parent when parent is in orphanage #29915

1. 
   instagibbs commented at 5:26 pm on April 19, 2024: member

   Takes a comment to that effect and makes an assertion.
2. 
   DrahtBot commented at 5:26 pm on April 19, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process. A summary of reviews will appear here.

3. DrahtBot added the label Tests on Apr 19, 2024
4. test: Don't fetch orphan parent when parent is in orphanage c54066ed25
5. instagibbs force-pushed on Apr 19, 2024
6. DrahtBot added the label CI failed on Apr 19, 2024
7. in test/functional/p2p_orphan_handling.py:368 in c54066ed25

   360@@ -357,9 +361,11 @@ def test_orphan_of_orphan(self):
   361 
   362         # The node should put the orphan into the orphanage and request missing_parent, skipping
   363         # missing_parent_orphan because it already has it in the orphanage.
   364+        peer.clear_getdata()
   365         self.relay_transaction(peer, orphan["tx"])
   366         self.nodes[0].bumpmocktime(NONPREF_PEER_TX_DELAY + TXID_RELAY_DELAY)
   367         peer.wait_for_parent_requests([int(missing_parent["txid"], 16)])
   368+        peer.assert_never_requested(int(missing_parent_orphan["txid"], 16))
   

   ---

   ---

   

   glozow commented at 10:40 am on April 22, 2024:

   wait_for_parent_requests already checks this, since it requires that the list of getdatas match exactly (nothing additional allowed)?

   ---

   

   instagibbs commented at 3:22 pm on April 22, 2024:

   hmm yeah this doesn’t add anything *unless it was requested in a separate getdata which this check wouldn’t ensure anyways.
8. instagibbs closed this on Apr 22, 2024

   ---

Contributors
instagibbs DrahtBot glozow

Labels
Tests CI failed