test: Don't fetch orphan parent when parent is in orphanage #29915

pull instagibbs wants to merge 1 commits into bitcoin:master from instagibbs:2024-04-parent_orphan_orphan_nofetch changing 1 files +6 −0

instagibbs commented at 5:26 PM on April 19, 2024: member

Takes a comment to that effect and makes an assertion.
DrahtBot commented at 5:26 PM on April 19, 2024: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Code Coverage

For detailed information about the code coverage, see the test coverage report.



Reviews

See the guideline for information on the review process. A summary of reviews will appear here.
DrahtBot added the label Tests on Apr 19, 2024
test: Don't fetch orphan parent when parent is in orphanage c54066ed25
instagibbs force-pushed on Apr 19, 2024
DrahtBot added the label CI failed on Apr 19, 2024

in test/functional/p2p_orphan_handling.py:368 in c54066ed25

 360 | @@ -357,9 +361,11 @@ def test_orphan_of_orphan(self):
 361 |  
 362 |          # The node should put the orphan into the orphanage and request missing_parent, skipping
 363 |          # missing_parent_orphan because it already has it in the orphanage.
 364 | +        peer.clear_getdata()
 365 |          self.relay_transaction(peer, orphan["tx"])
 366 |          self.nodes[0].bumpmocktime(NONPREF_PEER_TX_DELAY + TXID_RELAY_DELAY)
 367 |          peer.wait_for_parent_requests([int(missing_parent["txid"], 16)])
 368 | +        peer.assert_never_requested(int(missing_parent_orphan["txid"], 16))

glozow commented at 10:40 AM on April 22, 2024:

wait_for_parent_requests already checks this, since it requires that the list of getdatas match exactly (nothing additional allowed)?

instagibbs commented at 3:22 PM on April 22, 2024:

hmm yeah this doesn't add anything *unless it was requested in a separate getdata which this check wouldn't ensure anyways.

instagibbs closed this on Apr 22, 2024
bitcoin locked this on Apr 22, 2025

Contributors

Labels

test: Don't fetch orphan parent when parent is in orphanage #29915

Code Coverage

Reviews