test: add missing comparison of node1’s mempool in MempoolPackagesTest #29940

pull Umiiii wants to merge 3 commits into bitcoin:master from Umiiii:master changing 1 files +23 −11
  1. Umiiii commented at 12:58 pm on April 23, 2024: none

    Add missing comparison for TODO comments in mempool_packages.py

    Also, notice that the ancestor size limits and descendant size limits actually implemented in #21800 , so I removed the todo for those two size limits.

  2. test: Fix detailed check of node1's mempool in MempoolPackagesTest 0e70fdc9d1
  3. DrahtBot commented at 12:58 pm on April 23, 2024: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage

    For detailed information about the code coverage, see the test coverage report.

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

  4. chore: fix lint ba66e81196
  5. DrahtBot added the label CI failed on Apr 23, 2024
  6. DrahtBot commented at 1:06 pm on April 23, 2024: contributor

    🚧 At least one of the CI tasks failed. Make sure to run all tests locally, according to the documentation.

    Possibly this is due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.

    Leave a comment here, if you need help tracking down a confusing failure.

    Debug: https://github.com/bitcoin/bitcoin/runs/24152841866

  7. chore: remove blank line contains whitespace for fixing linting issue b94d59e46b
  8. Umiiii commented at 1:16 pm on April 23, 2024: none
    Believe the CI failed for lint problems (trailing whitespace and blank line contains whitespace), I’ve tested the code locally and passed the regression test.
  9. Umiiii renamed this:
    test(mempool): add missing comparison of node1's mempool in MempoolPackagesTest
    test: add missing comparison of node1's mempool in MempoolPackagesTest
    on Apr 23, 2024
  10. Umiiii closed this on Apr 23, 2024


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-21 09:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me