Please note that that was a PR branch from the CMake migration project. That branch detects cross-compiling basing on host and build values when building with depends.
fanquake
commented at 9:51 am on April 26, 2024:
member
Surely this isn’t the only place env vars like this would cause issues? Feels like a cat-and-mouse game.
Yea, as-is this doesn’t seem like a great fix, and may just break other things?
which would at least be using the option that is meant to be used for this.
hebasto force-pushed
on Apr 26, 2024
hebasto
commented at 10:05 am on April 26, 2024:
member
A better diff might be something like:
…
which would at least be using the option that is meant to be used for this.
I agree. Implemented.
Thanks!
hebasto renamed this:
depends: Do not consider `CC` environment variable for detecting system
depends: Use `CC_FOR_BUILD` for `config.guess `
on Apr 26, 2024
theuni
commented at 12:47 pm on April 26, 2024:
member
However, switching the CC variable context from Makefile to the shell environment breaks expectations
Arguably that’s because this wasn’t intended to be supported :)
I suppose this fix is reasonable, though supporting env vars like this seems quite brittle.
hebasto referenced this in commit
21bee57cb6
on Apr 30, 2024
hebasto referenced this in commit
516ecf1c8e
on May 2, 2024
hebasto referenced this in commit
729632c54f
on May 2, 2024
fanquake
commented at 3:37 pm on May 31, 2024:
member
Is this still an issue given recent CMake changes?
hebasto
commented at 10:10 am on June 3, 2024:
member
Is this still an issue given recent CMake changes?
Yes. Tested with the master branch @ 80bdd4b6beb878c95478b5623c9f9ff0b948ad57.
And this PR still fixes it.
DrahtBot added the label
CI failed
on Jun 18, 2024
DrahtBot removed the label
CI failed
on Jun 18, 2024
DrahtBot added the label
CI failed
on Sep 10, 2024
DrahtBot removed the label
CI failed
on Sep 14, 2024
achow101 requested review from fanquake
on Oct 15, 2024
achow101 requested review from theuni
on Oct 15, 2024
fanquake
commented at 4:03 pm on October 24, 2024:
member
theuni
commented at 6:55 pm on February 12, 2025:
member
I don’t understand this change. It seems setting CC_FOR_BUILD to CC is exactly the opposite of what we want to do?
@hebasto’s original change makes more sense to me:
0BUILD = $(shell env --unset CC ./config.guess)
That ignores what’s set in CC when detecting the native platform, which seems like the correct behavior to me.
What was your intention with this patch, @fanquake ?
DrahtBot added the label
CI failed
on Jul 3, 2025
DrahtBot removed the label
CI failed
on Jul 3, 2025
hebasto
commented at 2:47 pm on October 16, 2025:
member
DrahtBot removed the label
DrahtBot Guix build requested
on Oct 18, 2025
hebasto renamed this:
depends: Use `CC_FOR_BUILD` for `config.guess `
depends: Do not consider `CC` environment variable for detecting system
on Dec 4, 2025
ryanofsky approved
ryanofsky
commented at 1:43 pm on December 15, 2025:
contributor
Code review ACKa8cdc5872eaaffd56a8c79c6d371feb0df12431a. Seems good to unset an environment variable intended for cross compilation that is a causing a bad result when calling a native tool.
hebasto
commented at 5:53 pm on December 15, 2025:
member
ryanofsky
commented at 10:06 pm on December 16, 2025:
contributor
Current version of this PR is ok but I do think fanquake’s suggested change #29963 (comment) passing along the requested compiler to config.guess would be an improvement.
I think his change had a typo because it suggests using CC_FOR_BUILD=$CC when this should probably be CC_FOR_BUILD=$(build_CC) (or CC=$(build_CC) which is equivalent) because if a depends user specifies build_CC it makes sense to have config.guess use it instead of ignoring it and probing for alternate compilers:
This is a metadata mirror of the GitHub repository
bitcoin/bitcoin.
This site is not affiliated with GitHub.
Content is generated from a GitHub metadata backup.
generated: 2026-01-08 12:13 UTC
This site is hosted by @0xB10C More mirrored repositories can be found on mirror.b10c.me
