Remove the stack-protector check from test-security-check, as the test
no-longer fails, and given the control we have of the end, the actual
security-check test seems sufficient (this might also be applied to some
of the other checks).
Drops runtime support for Ubuntu Bionic 18.04 and RHEL-8 from the release binaries.
DrahtBot
commented at 12:59 pm on April 28, 2024:
contributor
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
Conflicts
Reviewers, this pull request conflicts with the following ones:
#27038 (security-check: test for _FORTIFY_SOURCE usage in release binaries by fanquake)
#24123 (guix: Pointer Authentication and Branch Target Identification for aarch64 Linux (Guix) by fanquake)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
fanquake added the label
DrahtBot Guix build requested
on Apr 28, 2024
laanwj added the label
Build system
on Apr 28, 2024
laanwj added the label
Linux/Unix
on Apr 28, 2024
laanwj
commented at 1:11 pm on April 28, 2024:
member
luke-jr
commented at 5:19 pm on May 7, 2024:
member
Is there a benefit to this? Just dropping patches?
fanquake
commented at 4:13 am on May 8, 2024:
member
Is there a benefit to this? Just dropping patches?
No, it’s not just dropping patches. It’s about us not having to maintain an EOL branch of glibc, us getting bugfixes (if relevant) to the branch we are using, us getting closer to properly supporting hardening features, fully static builds etc, by using a glibc that supports them.
laanwj
commented at 9:39 am on May 8, 2024:
member
New used symbols since 2.28:
81: 0000000000000000 0 FUNC GLOBAL DEFAULT UND fcntl64@GLIBC_2.28 (15)
fcntl function that can handle large file offsets on 32 bit platforms. Used in unixFileLock. unixShmLock and other posix/unix file functions.
195: 0000000000000000 0 FUNC GLOBAL DEFAULT UND statx@GLIBC_2.28 (15)
Extended file stat. Used in QFileSystemEngine::fillMetaData.
533: 0000000000000000 0 FUNC GLOBAL DEFAULT UND renameat2@GLIBC_2.28 (15
Renaming function with flag for atomic exchange and no-overwrite. Used in QFileSystemEngine::renameFile.
85: 0000000000000000 0 FUNC GLOBAL DEFAULT UND log@GLIBC_2.29 (12)
750: 0000000000116400 0 FUNC GLOBAL DEFAULT UND exp@GLIBC_2.29 (12)
776: 0000000000116c50 0 FUNC GLOBAL DEFAULT UND pow@GLIBC_2.29 (12)
Newer libm symbols (apparently more optimized, i can’t find much about it).
485: 0000000000000000 0 FUNC GLOBAL DEFAULT UND pthread_cond_clockwait@GLIBC_2.30 (32)
Wait on a condition variable until a specific clock (eg the monotonic one) reaches a certain value. Used in std::cv_status std::condition_variable::wait_for.
fanquake force-pushed
on May 14, 2024
fanquake
commented at 6:27 am on May 14, 2024:
member
Pulled in the most recent commits to the 2.31 branch. Mostly make 4.4 compat.
fanquake force-pushed
on May 22, 2024
fanquake force-pushed
on May 29, 2024
fanquake force-pushed
on Jun 4, 2024
fanquake force-pushed
on Jun 8, 2024
DrahtBot
commented at 10:38 am on June 8, 2024:
contributor
🚧 At least one of the CI tasks failed. Make sure to run all tests locally, according to the
documentation.
Possibly this is due to a silent merge conflict (the changes in this pull request being
incompatible with the current code in the target branch). If so, make sure to rebase on the latest
commit of the target branch.
Leave a comment here, if you need help tracking down a confusing failure.
DrahtBot removed the label
CI failed
on Jun 9, 2024
fanquake force-pushed
on Jun 10, 2024
fanquake force-pushed
on Jun 11, 2024
guix: use glibc 2.31
Set minimum required glibc to 2.31.
The glibc 2.31 branch is still maintained:
https://sourceware.org/git/?p=glibc.git;a=shortlog;h=refs/heads/release/2.31/master.
Remove the stack-protector check from test-security-check, as the test
no-longer fails, and given the control we have of the end, the actual
security-check test seems sufficient (this might also be applied to some
of the other checks).
Drops runtime support for Ubuntu Bionic 18.04 and RHEL-8 from the release binaries.
b5fc6d46a3
fanquake force-pushed
on Jun 12, 2024
fanquake
commented at 11:54 am on June 12, 2024:
member
This is a metadata mirror of the GitHub repository
bitcoin/bitcoin.
This site is not affiliated with GitHub.
Content is generated from a GitHub metadata backup.
generated: 2024-11-21 15:12 UTC
This site is hosted by @0xB10C More mirrored repositories can be found on mirror.b10c.me