autotools: fix a parallel build race condition spotted by the pull-tester #3001

pull theuni wants to merge 1 commits into bitcoin:master from theuni:fix-make-race changing 1 files +5 −6
  1. theuni commented at 6:05 AM on September 16, 2013: member

    libleveldb.a and libmemenv.a should be able to build in parallel, but in practice calling the leveldb makefile ends up rewriting build_config.mk. If one target tries to build while the other is halfway through writing the .mk, the make ends up in an undefined state.

    Fix that by making one depend on the other. This also reorders the variables to be passed by param rather than via the environment, and combines the targets into a single rule to avoid needless duplication.

  2. autotools: fix a parallel build race condition spotted by the pull-tester
    libleveldb.a and libmemenv.a should be able to build in parallel, but in
    practice calling the leveldb makefile ends up rewriting build_config.mk. If
    one target tries to build while the other is halfway through writing the
    .mk, the make ends up in an undefined state.
    
    Fix that by making one depend on the other. This also reorders the variables
    to be passed by param rather than via the environment, and combines the targets
    into a single rule to avoid needless duplication.
    cae63be6c9
  3. gmaxwell commented at 6:07 AM on September 16, 2013: contributor

    I've seen this too. ACK.

  4. BitcoinPullTester commented at 6:53 AM on September 16, 2013: none

    Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/cae63be6c95b19c236a2333c1f2456e016e13f0f for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

  5. gavinandresen referenced this in commit 17e0f67505 on Sep 16, 2013
  6. gavinandresen merged this on Sep 16, 2013
  7. gavinandresen closed this on Sep 16, 2013

  8. theuni deleted the branch on Sep 16, 2013
  9. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-18 15:16 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me