opportunistic 1p1c followups #30012

1. 
   glozow commented at 12:43 pm on May 1, 2024: member

   Followups from #28970:

   • #28970 (review)
   • #28970 (review)
   • #28970 (review)
   • #28970 (review)
   • #28970 (review)
2. [refactor] make MempoolAcceptResult::m_replaced_transactions non-optional 8496f69e1c
3. [txpackages] use std::lexicographical_compare instead of sorting hex strings

   No behavior change, but getting the hex string is more expensive than
   necessary.

   9a762efc7a
4. [doc] remove redundant PackageToValidate comment c2ada05307
5. [refactor] have ProcessPackageResult take a PackageToValidate 2b482dc1f3
6. glozow added the label Refactoring on May 1, 2024
7. 
   DrahtBot commented at 12:43 pm on May 1, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	instagibbs

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #29641 (scripted-diff: Use LogInfo/LogDebug over LogPrintf/LogPrint by maflcko)
   • #28984 (Cluster size 2 package rbf by instagibbs)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

8. Process every MempoolAcceptResult regardless of PackageValidationResult 6119f76ef7
9. instagibbs approved
10. 
    instagibbs commented at 7:31 pm on May 1, 2024: member

    ACK 6119f76ef72c1adc55c1a384c20f8ba9e1a01206
11. 
    fanquake commented at 4:09 am on May 2, 2024: member

    Can this also address:

     0txorphanage.cpp:281:21: error: loop variable 'child_iter' creates a copy from type '__gnu_debug::_Safe_iterator<std::_Rb_tree_iterator<std::pair<const transaction_identifier<false>, TxOrphanage::OrphanTx>>, std::map<transaction_identifier<false>, TxOrphanage::OrphanTx>> const' [-Werror,-Wrange-loop-construct]
     1  281 |     for (const auto child_iter : iters) {
     2      |                     ^
     3txorphanage.cpp:281:10: note: use reference type '__gnu_debug::_Safe_iterator<std::_Rb_tree_iterator<std::pair<const transaction_identifier<false>, TxOrphanage::OrphanTx>>, std::map<transaction_identifier<false>, TxOrphanage::OrphanTx>> const &' to prevent copying
     4  281 |     for (const auto child_iter : iters) {
     5      |          ^~~~~~~~~~~~~~~~~~~~~~~
     6      |                     &
     7txorphanage.cpp:313:21: error: loop variable 'child_iter' creates a copy from type '__gnu_debug::_Safe_iterator<std::_Rb_tree_iterator<std::pair<const transaction_identifier<false>, TxOrphanage::OrphanTx>>, std::map<transaction_identifier<false>, TxOrphanage::OrphanTx>> const' [-Werror,-Wrange-loop-construct]
     8  313 |     for (const auto child_iter : iters) {
     9      |                     ^
    10txorphanage.cpp:313:10: note: use reference type '__gnu_debug::_Safe_iterator<std::_Rb_tree_iterator<std::pair<const transaction_identifier<false>, TxOrphanage::OrphanTx>>, std::map<transaction_identifier<false>, TxOrphanage::OrphanTx>> const &' to prevent copying
    11  313 |     for (const auto child_iter : iters) {
    12      |          ^~~~~~~~~~~~~~~~~~~~~~~
    13      |                     &
    

12. [refactor] use reference in for loop through iters 7f6fb73c82
13. 
    glozow commented at 10:27 am on May 2, 2024: member

    Can this also address:

    Added. I made a copy instead of reference because it’s a pointer.

14. 
    instagibbs commented at 1:28 pm on May 2, 2024: member

    reACK https://github.com/bitcoin/bitcoin/pull/30012/commits/7f6fb73c82fdff2afe5edefcc335ba6707d5627d

    just the non-pointer copying added

15. fanquake merged this on May 3, 2024
16. fanquake closed this on May 3, 2024

    ---

17. glozow deleted the branch on May 9, 2024

Contributors
glozow DrahtBot instagibbs fanquake

Labels
Refactoring