msvc: Compile test\fuzz\miniscript.cpp #30031

1. 
   hebasto commented at 12:17 pm on May 3, 2024: member

   This PR resolves the remained point from the #29774 (comment):

   What is the issue with the … miniscript fuzz tests?

   From the CI log:

   0miniscript_script: succeeded against 721 files in 1s.
   1Run miniscript_script with args ['D:\\a\\bitcoin\\bitcoin\\src\\fuzz.exe', WindowsPath('D:/a/_temp/qa-assets/fuzz_seed_corpus/miniscript_script')]
   2miniscript_smart: succeeded against 1429 files in 2s.
   3Run miniscript_smart with args ['D:\\a\\bitcoin\\bitcoin\\src\\fuzz.exe', WindowsPath('D:/a/_temp/qa-assets/fuzz_seed_corpus/miniscript_smart')]
   4miniscript_stable: succeeded against 1871 files in 2s.
   5Run miniscript_stable with args ['D:\\a\\bitcoin\\bitcoin\\src\\fuzz.exe', WindowsPath('D:/a/_temp/qa-assets/fuzz_seed_corpus/miniscript_stable')]
   6miniscript_string: succeeded against 918 files in 3s.
   7Run miniscript_string with args ['D:\\a\\bitcoin\\bitcoin\\src\\fuzz.exe', WindowsPath('D:/a/_temp/qa-assets/fuzz_seed_corpus/miniscript_string')]
   

2. 
   DrahtBot commented at 12:17 pm on May 3, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	maflcko, TheCharlatan

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

3. hebasto force-pushed on May 3, 2024
4. hebasto force-pushed on May 3, 2024
5. hebasto force-pushed on May 3, 2024
6. hebasto closed this on May 3, 2024

   ---

7. hebasto reopened this on May 3, 2024

   ---

8. hebasto force-pushed on May 3, 2024
9. 
   fanquake commented at 1:17 am on May 4, 2024: member

   Based on #28657.

   Can be rebased now.

10. build, msvc: Compile test\fuzz\miniscript.cpp 9155b733e1
11. hebasto marked this as ready for review on May 4, 2024
12. hebasto force-pushed on May 4, 2024
13. 
    hebasto commented at 8:05 am on May 4, 2024: member

    Based on #28657.

    Can be rebased now.

    Rebased and undrafted.

14. hebasto added the label Needs CMake port on May 4, 2024
15. 
    maflcko commented at 8:34 am on May 4, 2024: member

    ACK 9155b733e153e799f09cc7f7e9199ad776b2cbb1
16. TheCharlatan approved
17. 
    TheCharlatan commented at 9:04 am on May 4, 2024: contributor

    ACK 9155b733e153e799f09cc7f7e9199ad776b2cbb1
18. DrahtBot added the label CI failed on May 4, 2024
19. 
    emc99 commented at 11:25 am on May 4, 2024: none

    There is no file at test/fuzz/miniscript
20. 
    hebasto commented at 11:27 am on May 4, 2024: member

    There is no file at test/fuzz/miniscript

    0$ file src/test/fuzz/miniscript.cpp
    1src/test/fuzz/miniscript.cpp: C++ source, ASCII text
    

21. 
    hebasto commented at 1:23 pm on May 4, 2024: member

    Ported to the CMake-based build system in https://github.com/hebasto/bitcoin/pull/187.
22. hebasto removed the label Needs CMake port on May 4, 2024
23. 
    emc99 commented at 6:12 pm on May 4, 2024: none

    @hebasto Are you looking for someone to compile this file on msvc?
24. DrahtBot removed the label CI failed on May 5, 2024
25. fanquake merged this on May 6, 2024
26. fanquake closed this on May 6, 2024

    ---

27. hebasto deleted the branch on May 6, 2024

Contributors
hebasto DrahtBot fanquake maflcko TheCharlatan emc99