build, test: Remove unused `TIMEOUT` environment variable #30063

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:240508-timeout changing 1 files +2 −2
  1. hebasto commented at 1:33 PM on May 8, 2024: member

    Setting the TIMEOUT environment variable has been a noop in both cases since its introduction.

    It seems to have been inadvertently copy-pasted from existed code. For example, in commit d80e3cbece857b293a4903ef49c4d543bb2cfb7f, it was needlessly copied from a valid case a few lines above for the qa/pull-tester/run-bitcoind-for-test.sh script.

  2. build, test: Remove unused `TIMEOUT` environment variable
    Setting the `TIMEOUT` environment variable has been a noop in both cases
    since its introduction.
    
    It seems to have been inadvertently copy-pasted from existing code. For
    example, in commit d80e3cbece857b293a4903ef49c4d543bb2cfb7f, it was
    needlessly copied from a valid case a few line above for the
    `qa/pull-tester/run-bitcoind-for-test.sh` script.
    189d0da3f6
  3. DrahtBot commented at 1:33 PM on May 8, 2024: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage

    For detailed information about the code coverage, see the test coverage report.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK maflcko, edilmedeiros

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. maflcko commented at 2:03 PM on May 8, 2024: member

    utACK 189d0da3f6f561c808fdd9fbd4dfd34ccfa23fe1

  5. edilmedeiros commented at 5:43 PM on May 8, 2024: contributor

    ACK 189d0da3f6f561c808fdd9fbd4dfd34ccfa23fe1

    Kind of tested with

    ❯ ./configure --with-boost=/opt/local/libexec/boost/1.78 --disable-wallet --with-gui=no --disable-gui-tests --disable-zmq --disable-man --without-bdb --enable-lcov
    ❯ make -j11 cov
    

    which I guess would cover the functional_test.info rule.

  6. edilmedeiros approved
  7. fanquake merged this on May 9, 2024
  8. fanquake closed this on May 9, 2024

  9. hebasto deleted the branch on May 9, 2024
  10. bitcoin locked this on May 9, 2025

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-24 21:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me