It is expected to have some Bitcoin nodes unreachable some of the time. A failure to connect to an IPv4 or IPv6 node is already properly logged under category=net/severity=debug. Do the same when a connection fails when using a SOCKS5 proxy. This could be either to an .onion address or to an IPv4 or IPv6 address (via a Tor exit node).
Related: #29759
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
For detailed information about the code coverage, see the test coverage report.
See the guideline for information on the review process.
| Type | Reviewers |
|---|---|
| ACK | mzumsande, tdb3, achow101 |
| Concept ACK | jonatack, BrandonOdiwuor |
| Stale ACK | laanwj, kristapsk |
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
Reviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
544@@ -544,9 +545,9 @@ template<typename... Args>
545 static void LogConnectFailure(bool manual_connection, const char* fmt, const Args&... args) {
546 std::string error_message = tfm::format(fmt, args...);
547 if (manual_connection) {
548- LogPrintf("%s\n", error_message);
549+ LogPrintLevel(BCLog::NET, BCLog::Level::Info, "%s\n", error_message);
In this case, I had added Manual and considered it an error (or perhaps warning), what do you think: https://github.com/bitcoin/bitcoin/pull/25203/commits/a0be62c9043caaebf64b3178b9bea080fa200ec7#diff-3499e52d708f04ebd0bfeec799dd26464ca6bd26a802c700460227c4f41ec4b5R541
0 LogPrintLevel(BCLog::NET, BCLog::Level::Error, "Manual %s\n", error_message);
LogConnectFailure is not related to SOCKS5 but also reached through ConnectDirectly(), so it’s not clear to me from the commit msg or PR description why the log is changed.
a0be62c (#25203) from two years ago contains these changes and further ones, perhaps look if other ones there could be done here.
It is expected to have some Bitcoin nodes unreachable some of the time.
A failure to connect to an IPv4 or IPv6 node is already properly logged
under category=net/severity=debug. Do the same when a connection fails
when using a SOCKS5 proxy. This could be either to an .onion address or
to an IPv4 or IPv6 address (via a Tor exit node).
Related: https://github.com/bitcoin/bitcoin/issues/29759
7524aaf58f...f3cfbd65f5: drop the changes to LogConnectFailure(). They were somewhat related, but not directly to the SOCKS5 stuff.
perhaps look if other ones there could be done here
The changes from #25203 look sound, but I want to keep this PR small, just to address the noisy and inconsistent logging due to connection failures via the SOCKS5 proxy.
