refactor: Remove unused code from subprocess.h header #30081

1. 
   hebasto commented at 2:04 pm on May 10, 2024: member

   This PR continues #29961.

   Please note that Popen::poll() is not required for #29868 anymore.

2. refactor, subprocess: Remove `Popen::pid()` 24b53fc84a
3. refactor, subprocess: Remove unused `Popen::poll()` 9e1ccf55e1
4. refactor, subprocess: Remove unused `Popen::child_created_` data member 05b6f8793c
5. refactor, subprocess: Remove unused stream API calls 5a11d3023f
6. 
   DrahtBot commented at 2:04 pm on May 10, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	theuni, theStack
   Concept ACK	katesalazar

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

7. DrahtBot added the label Refactoring on May 10, 2024
8. 
   katesalazar commented at 2:14 pm on May 10, 2024: contributor

   Concept ACK
9. theuni approved
10. 
    theuni commented at 6:27 pm on May 10, 2024: member

    Easy code review ACK 5a11d3023f7d0cde777f3496c0f3aa381823d749 since it’s all removals :)

    I assume since c-i is green that this code is all unneeded, but I can’t attest to the specifics.

11. theStack approved
12. 
    theStack commented at 4:32 am on May 11, 2024: contributor

    Code-review ACK 5a11d3023f7d0cde777f3496c0f3aa381823d749

    Thanks for following up!

13. fanquake merged this on May 11, 2024
14. fanquake closed this on May 11, 2024

    ---

15. hebasto deleted the branch on May 11, 2024

Contributors
hebasto DrahtBot katesalazar theuni theStack

Labels
Refactoring