This PR continues #29961.
Please note that Popen::poll() is not required for #29868 anymore.
refactor: Remove unused code from `subprocess.h` header #30081
pull hebasto wants to merge 4 commits into bitcoin:master from hebasto:240510-clean-sp changing 1 files +1 −75-
hebasto commented at 2:04 PM on May 10, 2024: member
-
refactor, subprocess: Remove `Popen::pid()` 24b53fc84a
-
refactor, subprocess: Remove unused `Popen::poll()` 9e1ccf55e1
-
refactor, subprocess: Remove unused `Popen::child_created_` data member 05b6f8793c
-
refactor, subprocess: Remove unused stream API calls 5a11d3023f
-
DrahtBot commented at 2:04 PM on May 10, 2024: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage
For detailed information about the code coverage, see the test coverage report.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK theuni, theStack Concept ACK katesalazar If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
- DrahtBot added the label Refactoring on May 10, 2024
-
katesalazar commented at 2:14 PM on May 10, 2024: contributor
Concept ACK
- theuni approved
-
theuni commented at 6:27 PM on May 10, 2024: member
Easy code review ACK 5a11d3023f7d0cde777f3496c0f3aa381823d749 since it's all removals :)
I assume since c-i is green that this code is all unneeded, but I can't attest to the specifics.
- theStack approved
-
theStack commented at 4:32 AM on May 11, 2024: contributor
Code-review ACK 5a11d3023f7d0cde777f3496c0f3aa381823d749
Thanks for following up!
- fanquake merged this on May 11, 2024
- fanquake closed this on May 11, 2024
- hebasto deleted the branch on May 11, 2024
- bitcoin locked this on May 11, 2025
