crypto: disable asan for sha256_sse4 with clang and -O0 #30097

1. 
   theuni commented at 6:16 pm on May 13, 2024: member

   Clang is unable to compile the Transform function for that combination of options.

   Fixes #29801.

2. 
   DrahtBot commented at 6:16 pm on May 13, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	achow101
   Concept ACK	fanquake

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

3. DrahtBot added the label Utils/log/libs on May 13, 2024
4. 
   theuni commented at 6:18 pm on May 13, 2024: member

   Ping @achow101. Sorry this took so long!
5. 
   fanquake commented at 2:13 am on May 14, 2024: member

   Concept ACK - Think I prefer fixing this inline, than in global flags / build. I guess we didn’t end up making an issue upstream (https://github.com/llvm/llvm-project/issues)? If there is something to link to, would be good to add it here.
6. fanquake added the label Needs backport (27.x) on May 14, 2024
7. 
   fanquake commented at 8:05 am on May 14, 2024: member

   Checked this (./configure --enable-debug --with-sanitizers=address CC=clang CXX=clang++) works with Ubuntu clang version 18.1.3 (1) on x86_64.
8. 
   theuni commented at 9:40 pm on May 14, 2024: member

   Concept ACK - Think I prefer fixing this inline, than in global flags / build. I guess we didn’t end up making an issue upstream (https://github.com/llvm/llvm-project/issues)? If there is something to link to, would be good to add it here.

   Upstream issue filed here: https://github.com/llvm/llvm-project/issues/92182

9. 
   fanquake commented at 5:17 am on May 15, 2024: member

   Upstream issue filed here: https://github.com/llvm/llvm-project/issues/92182

   Thanks. Could you like to that thread from the comment added to the source, then this is probably good to go.

10. crypto: disable asan for sha256_sse4 with clang and -O0

    Clang is unable to compile the Transform function for that combination of
    options.

    141df0a288
11. theuni force-pushed on May 15, 2024
12. 
    theuni commented at 1:51 pm on May 15, 2024: member

    Could you like to that thread from the comment added to the source, then this is probably good to go.

    Done

13. 
    achow101 commented at 6:33 pm on May 15, 2024: member

    ACK 141df0a28810470e53fdbc6d32d3cb4020fe3ca1

    It builds :tada:

14. DrahtBot requested review from fanquake on May 15, 2024
15. fanquake merged this on May 16, 2024
16. fanquake closed this on May 16, 2024

    ---

17. fanquake referenced this in commit 3c26058da2 on May 16, 2024
18. fanquake removed the label Needs backport (27.x) on May 16, 2024
19. 
    fanquake commented at 0:43 am on May 16, 2024: member

    Backported to 27.x in #30092.

Contributors
theuni DrahtBot fanquake achow101

Review Requested
fanquake

Labels
Utils/log/libs