ci: Add missing -Wno-error=maybe-uninitialized to armhf task #30144

1. 
   maflcko commented at 4:49 am on May 21, 2024: member

   This happens after bd597c33e3e58cd3c6b22ed42f8f1fd7ff886bb2 in many pull requests as a silent merge conflict. For example:

   • #29720 (comment)
   • #29521 (comment)
   • (Probably many undetected, because the CI task was not yet re-run)
   • …
2. ci: Add mising -Wno-error=maybe-uninitialized to armhf task fa73431dd4
3. 
   DrahtBot commented at 4:49 am on May 21, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	fjahr, fanquake

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

4. DrahtBot added the label Tests on May 21, 2024
5. maflcko added the label Needs CMake port on May 21, 2024
6. 
   fjahr commented at 9:14 am on May 21, 2024: contributor

   utACK fa73431dd4709754c34a4d5ad1c940ff9e628cf3
7. maflcko requested review from fanquake on May 21, 2024
8. in ci/test/00_setup_env_arm.sh:20 in fa73431dd4

   16@@ -17,4 +17,4 @@ export RUN_FUNCTIONAL_TESTS=false
   17 export GOAL="install"
   18 # -Wno-psabi is to disable ABI warnings: "note: parameter passing for argument of type ... changed in GCC 7.1"
   19 # This could be removed once the ABI change warning does not show up by default
   20-export BITCOIN_CONFIG="--enable-reduce-exports CXXFLAGS=-Wno-psabi"
   21+export BITCOIN_CONFIG="--enable-reduce-exports CXXFLAGS='-Wno-psabi -Wno-error=maybe-uninitialized'"
   

   ---

   ---

   

   cbergqvist commented at 11:39 am on May 21, 2024:

   Good to see. Might be worth adding a comment about why the warning is disabled here and in ci/test/00_setup_env_win64.sh?

   ---

   

   maflcko commented at 12:02 pm on May 21, 2024:

   All -Wno-error= in ./ci/ are due to false positives. I may address this, if I have to re-push for other reasons.
9. 
   adityajatnika commented at 2:38 pm on May 21, 2024: none

   lgtm
10. fanquake approved
11. 
    fanquake commented at 8:18 am on May 22, 2024: member

    ACK fa73431dd4709754c34a4d5ad1c940ff9e628cf3 - many fixed with 13.x
12. fanquake merged this on May 22, 2024
13. fanquake closed this on May 22, 2024

    ---

14. maflcko deleted the branch on May 22, 2024
15. 
    hebasto commented at 9:40 am on May 22, 2024: member

    Ported to the CMake-based build system in https://github.com/hebasto/bitcoin/pull/207.
16. hebasto removed the label Needs CMake port on May 22, 2024
17. hebasto referenced this in commit 80620aef4f on May 22, 2024
18. maflcko renamed this:
    ci: Add mising -Wno-error=maybe-uninitialized to armhf task
    ci: Add missing -Wno-error=maybe-uninitialized to armhf task
    on Jul 1, 2024

Contributors
maflcko DrahtBot fjahr cbergqvist adityajatnika fanquake hebasto

Labels
Tests