script is confusing, because in the context of Bitcoin, it usually means Bitcoin script (c.f. CScript in script.h, or pull requests such as #27122 using the prefix).
This could be fixed by renaming it to scripts (with a plural s at the end), however, looking at the current usage contrib and cli seem more common (https://github.com/bitcoin/bitcoin/pull/29687, #26953, #26584, #24864, #30074, #29433 …)
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
For detailed information about the code coverage, see the test coverage report.
See the guideline for information on the review process.
| Type | Reviewers |
|---|---|
| ACK | fanquake, willcl-ark, hebasto, theuni |
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
ACK fa3e1151a28345edff8f371283745bdd647f9a74
I’m half tempted to bikeshed this to using tools, but this also seems totally fine to me :)
I’m half tempted to bikeshed this to using
tools, but this also seems totally fine to me :)
The bot will understand it, so you are free to use it. :)
Edit: But I haven’t seen anyone use it yet, so updating the docs can be done as a follow-up when people are using tools.
