depends: Fetch miniupnpc sources from an alternative website #30151

1. 
   hebasto commented at 9:18 am on May 22, 2024: member

   The https://miniupnp.tuxfamily.org website is unavailable now.
2. 
   DrahtBot commented at 9:18 am on May 22, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	achow101, theuni

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

3. DrahtBot added the label Build system on May 22, 2024
4. 
   fanquake commented at 9:30 am on May 22, 2024: member

   website is unavailable now.

   Forever? Temporarily? Why not use the other official site?

   Also no mention that this is now downloading a bunch of other stuff that we don’t use?

5. 
   hebasto commented at 9:34 am on May 22, 2024: member

   website is unavailable now.

   Forever?

   I don’t know.

   Temporarily?

   I don’t know.

   Why not use the other official site?

   Which one? http://miniupnp.free.fr without HTTPS?

   Also no mention that this is now downloading a bunch of other stuff that we don’t use?

   Mentioned in the PR description.

6. 
   laanwj commented at 11:00 am on May 22, 2024: member

   Which one? http://miniupnp.free.fr/ without HTTPS?

   If that does keep the sha256 hash the same then maybe. Mind that github-generated tar.gzs aren’t guaranteed to have a stable hash.

7. depends: Fetch miniupnpc sources from an alternative website

   The https://miniupnp.tuxfamily.org website is unavailable now.

   21b8a14d37
8. hebasto force-pushed on May 22, 2024
9. hebasto renamed this:
   depends: Fetch miniupnpc sources from GitHub
   depends: Fetch miniupnpc sources from an alternative website
   on May 22, 2024
10. 
    hebasto commented at 11:07 am on May 22, 2024: member

    Which one? http://miniupnp.free.fr/ without HTTPS?

    If that does keep the sha256 hash the same then maybe.

    It does. Switched to that website.

11. 
    laanwj commented at 11:19 am on May 22, 2024: member

    It does. Switched to that website.

    Thanks. Agree it’s really suboptimal to use http because of protocol-level mischief, though. i hope tuxfamily will be back.

12. hebasto referenced this in commit bae096a2f2 on May 22, 2024
13. 
    achow101 commented at 4:09 pm on May 22, 2024: member

    ACK 21b8a14d37c19ce292d5529597e0d52338db48a9

    The main page of tuxfamily.org has 2 posts stating that they’ve had weeks of downtime in the past 6 months, so I think it makes sense to switch to a different mirror as they seem to be having issues. It’s unfortunate that miniupnp.free.fr is http only, but we check the hash so I think it’s fine.

14. theuni approved
15. 
    theuni commented at 7:20 pm on May 22, 2024: member

    Agree with @laanwj and @achow101.

    This is unfortunate, but seems like the best solution for now. The checksum should point out any hijinks.

    utACK 21b8a14d37c19ce292d5529597e0d52338db48a9

16. 
    edilmedeiros commented at 10:55 pm on May 22, 2024: contributor

    utACK 21b8a14d37c19ce292d5529597e0d52338db48a9

    Which one? http://miniupnp.free.fr/ without HTTPS?

    If that does keep the sha256 hash the same then maybe.

    It does. Switched to that website.

    This is the same URL I used to update the MacOS package in the macports project a couple of months ago, so there will be more people watching it.

17. fanquake merged this on May 23, 2024
18. fanquake closed this on May 23, 2024

    ---

19. fanquake referenced this in commit 77b2321ca0 on May 23, 2024
20. 
    fanquake commented at 8:46 am on May 23, 2024: member

    Backported to 27.x in #30092.
21. hebasto deleted the branch on May 23, 2024
22. fanquake referenced this in commit fccd32efe6 on May 29, 2024
23. fanquake added the label Needs backport (26.x) on Jun 3, 2024
24. glozow referenced this in commit 7b2489f57f on Jun 10, 2024
25. 
    glozow commented at 1:16 pm on June 10, 2024: member

    backported to 26.x in #30260
26. glozow removed the label Needs backport (26.x) on Jun 10, 2024
27. glozow referenced this in commit d10cf127e5 on Jun 12, 2024
28. 
    hebasto commented at 2:37 pm on July 22, 2024: member

    That’s unfortunate.

    As for today, https://miniupnp.free.fr/ is unavailable for me (

29. 
    edilmedeiros commented at 3:18 pm on July 22, 2024: contributor

    Isn’t possible/desirable to try to get it from the Github repo instead?

    https://github.com/miniupnp/miniupnp

30. 
    hebasto commented at 3:20 pm on July 22, 2024: member

    Isn’t possible/desirable to try to get it from the Github repo instead?

    See #30151 (comment):

    If that does keep the sha256 hash the same then maybe. Mind that github-generated tar.gzs aren’t guaranteed to have a stable hash.

Contributors
hebasto DrahtBot fanquake laanwj achow101 theuni edilmedeiros glozow

Labels
Build system