As we don't have any releases enforcing this yet, and no others that have picked it up, we can change this without harm. It has the advantage of on average decreasing signatures by 0.5 byte, and avoiding DER padding problems.
Use 'low S' as malleability breaker rather than 'even S' #3016
pull sipa wants to merge 1 commits into bitcoin:master from sipa:lows changing 1 files +11 −9-
sipa commented at 9:39 PM on September 18, 2013: member
-
gmaxwell commented at 11:48 PM on September 18, 2013: contributor
Pieter and I had discussed this a few weeks ago before his vacation.
ACK code, also, I ran 30,000 signatures through this and confirmed that the average signature size is reduced by 0.5 byte, the maximum is reduced by 1 byte, and all 30,000 resulting signatures validated.
-
gavinandresen commented at 12:01 AM on September 19, 2013: contributor
ACK
-
gavinandresen commented at 2:02 AM on September 20, 2013: contributor
Ignore pull-tester errors for now, I'm debugging it...
-
Use 'low S' as malleability breaker rather than 'even S' e0e14e43d9
-
BitcoinPullTester commented at 7:52 AM on September 23, 2013: none
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/e0e14e43d9586409e42919f6cb955540134cda2a for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
- sipa referenced this in commit a28fb70e45 on Sep 23, 2013
- sipa merged this on Sep 23, 2013
- sipa closed this on Sep 23, 2013
- metalicjames referenced this in commit fc3fa5f92d on Feb 16, 2017
- Bushstar referenced this in commit 54ab2048ca on Apr 8, 2020
- DrahtBot locked this on Sep 8, 2021
Contributors