guix: show *_FLAGS variables in pre-build output #30185

1. 
   fanquake commented at 3:53 pm on May 28, 2024: member

   For example:

    0# ADDITIONAL_GUIX_COMMON_FLAGS set in the ENV
    1ADDITIONAL_GUIX_ENVIRONMENT_FLAGS="--emulate-fhs" ./contrib/guix/guix-build
    2<snip>
    3INFO: Building f751991 for platform triple x86_64-linux-gnu:
    4      ...using reference timestamp: 1716905119
    5      ...running at most 10 jobs
    6      ...from worktree directory: '/bitcoin'
    7          ...bind-mounted in container to: '/bitcoin'
    8      ...in build directory: '/bitcoin/guix-build-f75199182133/distsrc-f75199182133-x86_64-linux-gnu'
    9          ...bind-mounted in container to: '/distsrc-base/distsrc-f75199182133-x86_64-linux-gnu'
   10      ...outputting in: '/bitcoin/guix-build-f75199182133/output/x86_64-linux-gnu'
   11          ...bind-mounted in container to: '/outdir-base/x86_64-linux-gnu'
   12      ADDITIONAL FLAGS (if set)
   13          ADDITIONAL_GUIX_COMMON_FLAGS: --no-substitutes
   14          ADDITIONAL_GUIX_ENVIRONMENT_FLAGS: --emulate-fhs
   15          ADDITIONAL_GUIX_TIMEMACHINE_FLAGS:
   

2. 
   DrahtBot commented at 3:53 pm on May 28, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	hebasto

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

3. DrahtBot added the label Build system on May 28, 2024
4. guix: show *_FLAGS variables in pre-build output

   For example:
   ```bash
   ADDITIONAL_GUIX_COMMON_FLAGS set in the ENV
   ADDITIONAL_GUIX_ENVIRONMENT_FLAGS="--emulate-fhs" ./contrib/guix/guix-build
   <snip>
   INFO: Building f75199182133 for platform triple x86_64-linux-gnu:
         ...using reference timestamp: 1716905119
         ...running at most 10 jobs
         ...from worktree directory: '/bitcoin'
             ...bind-mounted in container to: '/bitcoin'
         ...in build directory: '/bitcoin/guix-build-f75199182133/distsrc-f75199182133-x86_64-linux-gnu'
             ...bind-mounted in container to: '/distsrc-base/distsrc-f75199182133-x86_64-linux-gnu'
         ...outputting in: '/bitcoin/guix-build-f75199182133/output/x86_64-linux-gnu'
             ...bind-mounted in container to: '/outdir-base/x86_64-linux-gnu'
         ADDITIONAL FLAGS (if set)
             ADDITIONAL_GUIX_COMMON_FLAGS: --no-substitutes
             ADDITIONAL_GUIX_ENVIRONMENT_FLAGS: --emulate-fhs
             ADDITIONAL_GUIX_TIMEMACHINE_FLAGS:
   ```

   5f2c1d84e3
5. in contrib/guix/guix-build:366 in 842e15b0a1 outdated

   360@@ -361,6 +361,9 @@ INFO: Building ${VERSION:?not set} for platform triple ${HOST:?not set}:
   361           ...bind-mounted in container to: '$(DISTSRC_BASE=/distsrc-base && distsrc_for_host "$HOST")'
   362       ...outputting in: '$(outdir_for_host "$HOST")'
   363           ...bind-mounted in container to: '$(OUTDIR_BASE=/outdir-base && outdir_for_host "$HOST")'
   364+      ADDITIONAL FLAGS (if set)
   365+          ADDITIONAL_GUIX_COMMON_FLAGS: ${ADDITIONAL_GUIX_COMMON_FLAGS}
   366+          ADDITIONAL_GUIX_ENVIRONMENT_FLAGS: ${ADDITIONAL_GUIX_ENVIRONMENT_FLAGS}
   

   ---

   ---

   

   hebasto commented at 10:25 am on June 3, 2024:

   Why ADDITIONAL_GUIX_TIMEMACHINE_FLAGS skipped? ~Despite that it was used before this point,~ it can be useful for users and consistency.

   ---

   

   fanquake commented at 11:00 am on June 3, 2024:

   Sure. Added that as well
6. fanquake force-pushed on Jun 3, 2024
7. hebasto approved
8. 
   hebasto commented at 11:13 am on June 3, 2024: member

   ACK 5f2c1d84e37697f4f8a20e3c12f37bba71b3c2a6.
9. fanquake merged this on Jun 5, 2024
10. fanquake closed this on Jun 5, 2024

    ---

11. fanquake deleted the branch on Jun 5, 2024

Contributors
fanquake DrahtBot hebasto

Labels
Build system