depends: qt 5.15.14 and fix macOS build with Clang 18

fanquake commented at 11:15 am on May 30, 2024: member

Also adds a patch to Qts internal libpng, to fix compilation using Clang 18, when targetting macOS. I’d like to get this patched, so we can continue working on removing FORCE_USE_SYSTEM_CLANG (#30201); otherwise builds will be broken using the default Clang (18) on the current Ubuntu LTS (24.04).

With this PR, anyone using Ubuntu 24.04 should be able to apt install clang llvm lld, and then cross-compile for macOS using:

0# clang --version
1Ubuntu clang version 18.1.3 (1)
2make -C depends HOST=arm64-apple-darwin FORCE_USE_SYSTEM_CLANG=1
3./autogen.sh
4CONFIG_SITE=/path/to/depends/arm64-apple-darwin/share/config.site ./configure
5make
6# file src/qt/bitcoin-qt
7src/qt/bitcoin-qt: Mach-O 64-bit arm64 executable, flags:<NOUNDEFS|DYLDLINK|TWOLEVEL|WEAK_DEFINES|BINDS_TO_WEAK|PIE|HAS_TLV_DESCRIPTORS>

depends: qt 5.15.14 b018bd779d

depends: fix Qt macOS build with Clang 18

Patch Qts internal libpng to resolve the failure.

I would like to have this patched, so we can continue working on the
removal of `FORCE_USE_SYSTEM_CLANG`. Otherwise builds will be broken using
the default clang (18) on the current Ubuntu LTS (24.04).

0a3631fc35

DrahtBot commented at 11:15 am on May 30, 2024: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	TheCharlatan, theuni, hebasto

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#29923 (depends: Remove Qt build-time dependencies by laanwj)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

DrahtBot added the label Build system on May 30, 2024

fanquake added the label DrahtBot Guix build requested on May 30, 2024

fanquake commented at 12:32 pm on May 30, 2024: member

Guix Build (aarch64 and x86_64):

 01efa3e0205032d6cfe5517ce36ab63379afa22268dcbb0b92150719baa030682  guix-build-0a3631fc352e/output/aarch64-linux-gnu/SHA256SUMS.part
 1e3db302484148c00cab7150e3451d2c95dae14062cb4165c8e5a28d71d77e630  guix-build-0a3631fc352e/output/aarch64-linux-gnu/bitcoin-0a3631fc352e-aarch64-linux-gnu-debug.tar.gz
 2f9792f8db8635bb19f6a2d7c73f1b0780e5776734c12912c5e7172f357f7fa1f  guix-build-0a3631fc352e/output/aarch64-linux-gnu/bitcoin-0a3631fc352e-aarch64-linux-gnu.tar.gz
 3708374dcac162523ae5e2e4e7d70ff9459047a81bc9361d88b13dfdd785ebce7  guix-build-0a3631fc352e/output/arm-linux-gnueabihf/SHA256SUMS.part
 4e52744067d4f62b923bf9632a2021dbe5ff6eb43ad31f54c217614ff8f2e1d25  guix-build-0a3631fc352e/output/arm-linux-gnueabihf/bitcoin-0a3631fc352e-arm-linux-gnueabihf-debug.tar.gz
 5c08428f467d559301c6033520eacc79a4072f5baaf309bec2735d9231bb1033c  guix-build-0a3631fc352e/output/arm-linux-gnueabihf/bitcoin-0a3631fc352e-arm-linux-gnueabihf.tar.gz
 6fb2f0e76c43b608b53408a13208d80f823f7835b02a77185f24f174986f5d655  guix-build-0a3631fc352e/output/arm64-apple-darwin/SHA256SUMS.part
 7f1311d3211111d64ba55b3c515822903e8922722bacbd89b369cb1f27e492db0  guix-build-0a3631fc352e/output/arm64-apple-darwin/bitcoin-0a3631fc352e-arm64-apple-darwin-unsigned.tar.gz
 8d6d54939550b68a8c4e908fd7f45d6ecc6b06ee20453930f85fa9942849cda30  guix-build-0a3631fc352e/output/arm64-apple-darwin/bitcoin-0a3631fc352e-arm64-apple-darwin-unsigned.zip
 9cbcc8d26437325d8910f6f7e81dbdf29a30e8f02670cd13b78d5c2d81b88fb36  guix-build-0a3631fc352e/output/arm64-apple-darwin/bitcoin-0a3631fc352e-arm64-apple-darwin.tar.gz
100b00c0d2ae7ffd16161ecbe652409634b1d6a3ab36d50f15890a4fdae12f394c  guix-build-0a3631fc352e/output/dist-archive/bitcoin-0a3631fc352e.tar.gz
1149ce76f35afa05205d15ba7a187fb64d2872eca0594b3aadeb53cb75487cbf9d  guix-build-0a3631fc352e/output/powerpc64-linux-gnu/SHA256SUMS.part
12bec44a5a60d434c462362fe22cea05d9de5cc32ff053397bbedfcffe714e6c11  guix-build-0a3631fc352e/output/powerpc64-linux-gnu/bitcoin-0a3631fc352e-powerpc64-linux-gnu-debug.tar.gz
1352121a4e6c3843569d455863fcebc494384ccaf10dcb2e5a6fe316efe1e03ab3  guix-build-0a3631fc352e/output/powerpc64-linux-gnu/bitcoin-0a3631fc352e-powerpc64-linux-gnu.tar.gz
14387dc56f8990a814f98a9458e6df3d34dfa7d8d19e77c84839093f8f9fb33271  guix-build-0a3631fc352e/output/riscv64-linux-gnu/SHA256SUMS.part
151ff58588d9eae9064b29834e50b8c5ca201d599672c117fbc104e4e36c797d60  guix-build-0a3631fc352e/output/riscv64-linux-gnu/bitcoin-0a3631fc352e-riscv64-linux-gnu-debug.tar.gz
164b17f0727b683e3552343f8187f184bdc21e74b1c3a6668ab0b806a08cb9ef91  guix-build-0a3631fc352e/output/riscv64-linux-gnu/bitcoin-0a3631fc352e-riscv64-linux-gnu.tar.gz
17385902545f37891d2f5dca84a695d5f80e104aaea984eabab68f1454b8453a94  guix-build-0a3631fc352e/output/x86_64-apple-darwin/SHA256SUMS.part
18e52be71b1cf0eb0ef37a6488bffb384ecbf5dc0a76b5eca8c7ec49e3ea380073  guix-build-0a3631fc352e/output/x86_64-apple-darwin/bitcoin-0a3631fc352e-x86_64-apple-darwin-unsigned.tar.gz
1980c726574fa9fb2822d313262c34501888dd4fa58f6c71be247b5a3b152b6b19  guix-build-0a3631fc352e/output/x86_64-apple-darwin/bitcoin-0a3631fc352e-x86_64-apple-darwin-unsigned.zip
2042de5d078bfc1afb646e9c25c8adce6ad3a2f2a4bc53341c17ac17fd1a132653  guix-build-0a3631fc352e/output/x86_64-apple-darwin/bitcoin-0a3631fc352e-x86_64-apple-darwin.tar.gz
2183d24dc27fa4f51382492345daa1515b73e1646c3e00b088affa2edf481c8d1a  guix-build-0a3631fc352e/output/x86_64-linux-gnu/SHA256SUMS.part
225e2aa04d77f563d6261fe4575a014f6226b949282c873f4126f2f3d89645d8c6  guix-build-0a3631fc352e/output/x86_64-linux-gnu/bitcoin-0a3631fc352e-x86_64-linux-gnu-debug.tar.gz
236636337a95cf886670c88e43e6da01481efe8a415a2fea576a0ab759ac2f06f3  guix-build-0a3631fc352e/output/x86_64-linux-gnu/bitcoin-0a3631fc352e-x86_64-linux-gnu.tar.gz
24628236de61ed3cf621f9f1c094e2849777c9b67cd7faf1b3ebb1fcc453e59f89  guix-build-0a3631fc352e/output/x86_64-w64-mingw32/SHA256SUMS.part
2549bfa94d4c37158b32ef9e560b7211da6b998937eee46573efd3627ec9f8050c  guix-build-0a3631fc352e/output/x86_64-w64-mingw32/bitcoin-0a3631fc352e-win64-debug.zip
26641767ffd7fe4d72ddb326885cc74c12a79f7719c8c27d87cc2b9fe902e31669  guix-build-0a3631fc352e/output/x86_64-w64-mingw32/bitcoin-0a3631fc352e-win64-setup-unsigned.exe
27c2eed2510db96247a3627766b0474ff374aa266e46f5f4376875971952b8dcf4  guix-build-0a3631fc352e/output/x86_64-w64-mingw32/bitcoin-0a3631fc352e-win64-unsigned.tar.gz
28f14bad165f6a434d60befe6060573a15e9c481756046843c856c6278efc07f46  guix-build-0a3631fc352e/output/x86_64-w64-mingw32/bitcoin-0a3631fc352e-win64.zip

TheCharlatan commented at 1:31 pm on May 30, 2024: contributor

0a3631fc352eda849290db940844e5ef723436df Patch and version bump looks good to me, but I’m getting an error when building with your instructions:

 0# clang --version
 1Ubuntu clang version 18.1.3 (1)
 2# make -C depends HOST=arm64-apple-darwin FORCE_USE_SYSTEM_CLANG=1 V=1
 3make: Entering directory '/home/drgrid/bitcoin/depends'
 4echo Configuring libevent...
 5Configuring libevent...
 6rm -rf /home/drgrid/bitcoin/depends/arm64-apple-darwin; mkdir -p /home/drgrid/bitcoin/depends/arm64-apple-darwin/lib; cd /home/drgrid/bitcoin/depends/arm64-apple-darwin; 
 7mkdir -p /home/drgrid/bitcoin/depends/work/build/arm64-apple-darwin/libevent/2.1.12-stable-f322713a5e4/.
 8{ cd /home/drgrid/bitcoin/depends/work/build/arm64-apple-darwin/libevent/2.1.12-stable-f322713a5e4/.; export  PKG_CONFIG_LIBDIR=/home/drgrid/bitcoin/depends/arm64-apple-darwin/lib/pkgconfig PKG_CONFIG_PATH=/home/drgrid/bitcoin/depends/arm64-apple-darwin/share/pkgconfig PKG_CONFIG_SYSROOT_DIR=/ CMAKE_MODULE_PATH=/home/drgrid/bitcoin/depends/arm64-apple-darwin/lib/cmake PATH="/home/drgrid/bitcoin/depends/arm64-apple-darwin/native/bin:/home/drgrid/.cargo/bin:/home/drgrid/.local/bin:/home/drgrid/.config/guix/current/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin:/snap/bin:/usr/local/go/bin:/home/drgrid/.local/bin";   ./configure --build=x86_64-pc-linux-gnu --host=arm64-apple-darwin --prefix=/home/drgrid/bitcoin/depends/arm64-apple-darwin --with-pic --disable-shared --disable-openssl --disable-libevent-regress --disable-samples --disable-dependency-tracking --enable-option-checking --disable-debug-mode       CC="env -u C_INCLUDE_PATH -u CPLUS_INCLUDE_PATH -u OBJC_INCLUDE_PATH -u OBJCPLUS_INCLUDE_PATH -u CPATH -u LIBRARY_PATH /usr/bin/clang --target=arm64-apple-darwin -B/home/drgrid/bitcoin/depends/arm64-apple-darwin/native/bin -isysroot/home/drgrid/bitcoin/depends/SDKs/Xcode-15.0-15A240d-extracted-SDK-with-libcxx-headers -nostdlibinc -iwithsysroot/usr/include -iframeworkwithsysroot/System/Library/Frameworks" CXX="env -u C_INCLUDE_PATH -u CPLUS_INCLUDE_PATH -u OBJC_INCLUDE_PATH -u OBJCPLUS_INCLUDE_PATH -u CPATH -u LIBRARY_PATH /usr/bin/clang++ --target=arm64-apple-darwin -B/home/drgrid/bitcoin/depends/arm64-apple-darwin/native/bin -isysroot/home/drgrid/bitcoin/depends/SDKs/Xcode-15.0-15A240d-extracted-SDK-with-libcxx-headers -nostdlibinc -iwithsysroot/usr/include/c++/v1 -iwithsysroot/usr/include -iframeworkwithsysroot/System/Library/Frameworks" NM="/usr/bin/llvm-nm" RANLIB="/usr/bin/llvm-ranlib" AR="/usr/bin/llvm-ar" CFLAGS="-pipe -std=c11 -mmacosx-version-min=11.0 -mlinker-version=711 -O2" CXXFLAGS="-pipe -std=c++20 -mmacosx-version-min=11.0 -mlinker-version=711 -O2" CPPFLAGS="  -I/home/drgrid/bitcoin/depends/arm64-apple-darwin/include -D_FORTIFY_SOURCE=3" LDFLAGS="-Wl,-platform_version,macos,11.0,14.0 -Wl,-no_adhoc_codesign -fuse-ld=lld  -L/home/drgrid/bitcoin/depends/arm64-apple-darwin/lib"; } 
 9checking for a BSD-compatible install... /usr/bin/install -c
10checking whether build environment is sane... yes
11checking for arm64-apple-darwin-strip... no
12checking for strip... strip
13configure: WARNING: using cross tools not prefixed with host triplet
14checking for a thread-safe mkdir -p... /usr/bin/mkdir -p
15checking for gawk... no
16checking for mawk... mawk
17checking whether make sets $(MAKE)... yes
18checking whether make supports nested variables... yes
19checking whether make supports nested variables... (cached) yes
20checking whether make supports the include directive... yes (GNU style)
21checking for arm64-apple-darwin-gcc... env -u C_INCLUDE_PATH -u CPLUS_INCLUDE_PATH -u OBJC_INCLUDE_PATH -u OBJCPLUS_INCLUDE_PATH -u CPATH -u LIBRARY_PATH /usr/bin/clang --target=arm64-apple-darwin -B/home/drgrid/bitcoin/depends/arm64-apple-darwin/native/bin -isysroot/home/drgrid/bitcoin/depends/SDKs/Xcode-15.0-15A240d-extracted-SDK-with-libcxx-headers -nostdlibinc -iwithsysroot/usr/include -iframeworkwithsysroot/System/Library/Frameworks
22checking whether the C compiler works... no
23configure: error: in `/home/drgrid/bitcoin/depends/work/build/arm64-apple-darwin/libevent/2.1.12-stable-f322713a5e4':
24configure: error: C compiler cannot create executables
25See `config.log' for more details
26make: *** [funcs.mk:302: /home/drgrid/bitcoin/depends/arm64-apple-darwin/.libevent_stamp_configured] Error 77
27make: Leaving directory '/home/drgrid/bitcoin/depends'

If I look into config.log:

 0110 configure:3787: env -u C_INCLUDE_PATH -u CPLUS_INCLUDE_PATH -u OBJC_INCLUDE_PATH -u OBJCPLUS_INCLUDE_PATH -u CPATH -u LIBRARY_PATH /usr/bin/clang --target=arm64-apple-darwin -B/home/d    rgrid/bitcoin/depends/arm64-apple-darwin/native/bin -isysroot/home/drgrid/bitcoin/depends/SDKs/Xcode-15.0-15A240d-extracted-SDK-with-libcxx-headers -nostdlibinc -iwithsysroot/usr/incl    ude -iframeworkwithsysroot/System/Library/Frameworks -pipe -std=c11 -mmacosx-version-min=11.0 -mlinker-version=711 -O2   -I/home/drgrid/bitcoin/depends/arm64-apple-darwin/include -D_F    ORTIFY_SOURCE=3 -Wl,-platform_version,macos,11.0,14.0 -Wl,-no_adhoc_codesign -fuse-ld=lld  -L/home/drgrid/bitcoin/depends/arm64-apple-darwin/lib conftest.c  >&5
 1111 clang: error: invalid linker name in argument '-fuse-ld=lld'
 2112 configure:3791: $? = 1 
 3113 configure:3829: result: no
 4114 configure: failed program was:
 5115 | /* confdefs.h */
 6116 | #define PACKAGE_NAME "libevent"
 7117 | #define PACKAGE_TARNAME "libevent"
 8118 | #define PACKAGE_VERSION "2.1.12-stable"
 9119 | #define PACKAGE_STRING "libevent 2.1.12-stable"
10120 | #define PACKAGE_BUGREPORT ""
11121 | #define PACKAGE_URL ""
12122 | #define PACKAGE "libevent"
13123 | #define VERSION "2.1.12-stable"
14124 | #define NUMERIC_VERSION 0x02010c00
15125 | /* end confdefs.h.  */
16126 | 
17127 | int 
18128 | main ()
19129 | {
20130 |
21131 |   ;
22132 |   return 0;
23133 | }
24134 configure:3834: error: in `/home/drgrid/bitcoin/depends/work/build/arm64-apple-darwin/libevent/2.1.12-stable-f322713a5e4':
25135 configure:3836: error: C compiler cannot create executables
26136 See `config.log' for more details

So I did apt install lld and it worked. Should that be added to the instructions?

fanquake commented at 1:32 pm on May 30, 2024: member

So I did apt install lld and it worked. Should that be added to the instructions?

I’ve added that to the PR instructions here. Adding it the depends install instructions will be part of the next PR, which removes FORCE_USE_SYSTEM_CLANG.

theuni commented at 3:37 pm on May 30, 2024: member

Is the bump to .14 also for clang 18, or is that just incidental?

fanquake commented at 3:41 pm on May 30, 2024: member

or is that just incidental?

Mostly incidental. We’ve got to rebuild all Qts after dropping the android patches changes from #30049, so seemed like a convenient time. I also try to bump to the newest source (if possible) before introducing new patches.

TheCharlatan approved

TheCharlatan commented at 4:11 pm on May 30, 2024: contributor

ACK 0a3631fc352eda849290db940844e5ef723436df

Guix build (aarch64)

 01efa3e0205032d6cfe5517ce36ab63379afa22268dcbb0b92150719baa030682  guix-build-0a3631fc352e/output/aarch64-linux-gnu/SHA256SUMS.part
 1e3db302484148c00cab7150e3451d2c95dae14062cb4165c8e5a28d71d77e630  guix-build-0a3631fc352e/output/aarch64-linux-gnu/bitcoin-0a3631fc352e-aarch64-linux-gnu-debug.tar.gz
 2f9792f8db8635bb19f6a2d7c73f1b0780e5776734c12912c5e7172f357f7fa1f  guix-build-0a3631fc352e/output/aarch64-linux-gnu/bitcoin-0a3631fc352e-aarch64-linux-gnu.tar.gz
 3708374dcac162523ae5e2e4e7d70ff9459047a81bc9361d88b13dfdd785ebce7  guix-build-0a3631fc352e/output/arm-linux-gnueabihf/SHA256SUMS.part
 4e52744067d4f62b923bf9632a2021dbe5ff6eb43ad31f54c217614ff8f2e1d25  guix-build-0a3631fc352e/output/arm-linux-gnueabihf/bitcoin-0a3631fc352e-arm-linux-gnueabihf-debug.tar.gz
 5c08428f467d559301c6033520eacc79a4072f5baaf309bec2735d9231bb1033c  guix-build-0a3631fc352e/output/arm-linux-gnueabihf/bitcoin-0a3631fc352e-arm-linux-gnueabihf.tar.gz
 6fb2f0e76c43b608b53408a13208d80f823f7835b02a77185f24f174986f5d655  guix-build-0a3631fc352e/output/arm64-apple-darwin/SHA256SUMS.part
 7f1311d3211111d64ba55b3c515822903e8922722bacbd89b369cb1f27e492db0  guix-build-0a3631fc352e/output/arm64-apple-darwin/bitcoin-0a3631fc352e-arm64-apple-darwin-unsigned.tar.gz
 8d6d54939550b68a8c4e908fd7f45d6ecc6b06ee20453930f85fa9942849cda30  guix-build-0a3631fc352e/output/arm64-apple-darwin/bitcoin-0a3631fc352e-arm64-apple-darwin-unsigned.zip
 9cbcc8d26437325d8910f6f7e81dbdf29a30e8f02670cd13b78d5c2d81b88fb36  guix-build-0a3631fc352e/output/arm64-apple-darwin/bitcoin-0a3631fc352e-arm64-apple-darwin.tar.gz
100b00c0d2ae7ffd16161ecbe652409634b1d6a3ab36d50f15890a4fdae12f394c  guix-build-0a3631fc352e/output/dist-archive/bitcoin-0a3631fc352e.tar.gz
1149ce76f35afa05205d15ba7a187fb64d2872eca0594b3aadeb53cb75487cbf9d  guix-build-0a3631fc352e/output/powerpc64-linux-gnu/SHA256SUMS.part
12bec44a5a60d434c462362fe22cea05d9de5cc32ff053397bbedfcffe714e6c11  guix-build-0a3631fc352e/output/powerpc64-linux-gnu/bitcoin-0a3631fc352e-powerpc64-linux-gnu-debug.tar.gz
1352121a4e6c3843569d455863fcebc494384ccaf10dcb2e5a6fe316efe1e03ab3  guix-build-0a3631fc352e/output/powerpc64-linux-gnu/bitcoin-0a3631fc352e-powerpc64-linux-gnu.tar.gz
14387dc56f8990a814f98a9458e6df3d34dfa7d8d19e77c84839093f8f9fb33271  guix-build-0a3631fc352e/output/riscv64-linux-gnu/SHA256SUMS.part
151ff58588d9eae9064b29834e50b8c5ca201d599672c117fbc104e4e36c797d60  guix-build-0a3631fc352e/output/riscv64-linux-gnu/bitcoin-0a3631fc352e-riscv64-linux-gnu-debug.tar.gz
164b17f0727b683e3552343f8187f184bdc21e74b1c3a6668ab0b806a08cb9ef91  guix-build-0a3631fc352e/output/riscv64-linux-gnu/bitcoin-0a3631fc352e-riscv64-linux-gnu.tar.gz
17385902545f37891d2f5dca84a695d5f80e104aaea984eabab68f1454b8453a94  guix-build-0a3631fc352e/output/x86_64-apple-darwin/SHA256SUMS.part
18e52be71b1cf0eb0ef37a6488bffb384ecbf5dc0a76b5eca8c7ec49e3ea380073  guix-build-0a3631fc352e/output/x86_64-apple-darwin/bitcoin-0a3631fc352e-x86_64-apple-darwin-unsigned.tar.gz
1980c726574fa9fb2822d313262c34501888dd4fa58f6c71be247b5a3b152b6b19  guix-build-0a3631fc352e/output/x86_64-apple-darwin/bitcoin-0a3631fc352e-x86_64-apple-darwin-unsigned.zip
2042de5d078bfc1afb646e9c25c8adce6ad3a2f2a4bc53341c17ac17fd1a132653  guix-build-0a3631fc352e/output/x86_64-apple-darwin/bitcoin-0a3631fc352e-x86_64-apple-darwin.tar.gz
2183d24dc27fa4f51382492345daa1515b73e1646c3e00b088affa2edf481c8d1a  guix-build-0a3631fc352e/output/x86_64-linux-gnu/SHA256SUMS.part
225e2aa04d77f563d6261fe4575a014f6226b949282c873f4126f2f3d89645d8c6  guix-build-0a3631fc352e/output/x86_64-linux-gnu/bitcoin-0a3631fc352e-x86_64-linux-gnu-debug.tar.gz
236636337a95cf886670c88e43e6da01481efe8a415a2fea576a0ab759ac2f06f3  guix-build-0a3631fc352e/output/x86_64-linux-gnu/bitcoin-0a3631fc352e-x86_64-linux-gnu.tar.gz
24628236de61ed3cf621f9f1c094e2849777c9b67cd7faf1b3ebb1fcc453e59f89  guix-build-0a3631fc352e/output/x86_64-w64-mingw32/SHA256SUMS.part
2549bfa94d4c37158b32ef9e560b7211da6b998937eee46573efd3627ec9f8050c  guix-build-0a3631fc352e/output/x86_64-w64-mingw32/bitcoin-0a3631fc352e-win64-debug.zip
26641767ffd7fe4d72ddb326885cc74c12a79f7719c8c27d87cc2b9fe902e31669  guix-build-0a3631fc352e/output/x86_64-w64-mingw32/bitcoin-0a3631fc352e-win64-setup-unsigned.exe
27c2eed2510db96247a3627766b0474ff374aa266e46f5f4376875971952b8dcf4  guix-build-0a3631fc352e/output/x86_64-w64-mingw32/bitcoin-0a3631fc352e-win64-unsigned.tar.gz
28f14bad165f6a434d60befe6060573a15e9c481756046843c856c6278efc07f46  guix-build-0a3631fc352e/output/x86_64-w64-mingw32/bitcoin-0a3631fc352e-win64.zip

theuni approved

theuni commented at 4:13 pm on May 30, 2024: member

utACK 0a3631fc352eda849290db940844e5ef723436df

DrahtBot commented at 10:07 pm on May 30, 2024: contributor

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

File	commit 0a7c650fcd322a46dac7239b421046a61a6a5a20(master)	commit 4d39de63df5d4a75d572c05a4132311a1c07b1ff(master and this pull)
SHA256SUMS.part	`f34401acc02c8e5b...`	`8ae2b10fa3087837...`
*-aarch64-linux-gnu-debug.tar.gz	`13cc9cd358972d37...`	`34b82854d4fcd539...`
*-aarch64-linux-gnu.tar.gz	`37451a0f005ae6e7...`	`9d9a2b810afa70c5...`
*-arm-linux-gnueabihf-debug.tar.gz	`14f679b94795331f...`	`3cb3e39e716e9171...`
*-arm-linux-gnueabihf.tar.gz	`fc0ac7c024ec9965...`	`b890f0ee05f1180c...`
*-arm64-apple-darwin-unsigned.tar.gz	`074243719a9fa030...`	`9b620527df1b1654...`
*-arm64-apple-darwin-unsigned.zip	`b5a2c7cab4149196...`	`de31255997773d89...`
*-arm64-apple-darwin.tar.gz	`3f75d19ef3d4d0e3...`	`0e3945acc97f776c...`
*-powerpc64-linux-gnu-debug.tar.gz	`e7aafdcfda7dbf19...`	`92a19f5e692c7d01...`
*-powerpc64-linux-gnu.tar.gz	`3fb560d4cb5c428e...`	`f806c76c1177fc76...`
*-riscv64-linux-gnu-debug.tar.gz	`e8d9437947da47fe...`	`e8be5877ead9003e...`
*-riscv64-linux-gnu.tar.gz	`7e108ac41b7e3b42...`	`ddd51cf6b3b3fdaf...`
*-x86_64-apple-darwin-unsigned.tar.gz	`c8af0f5f3a5597bd...`	`ddf80ea092171b18...`
*-x86_64-apple-darwin-unsigned.zip	`2e77c8cc0ccba962...`	`491077ca80aa940f...`
*-x86_64-apple-darwin.tar.gz	`e118f1773b0cfba6...`	`f49989f1bc693034...`
*-x86_64-linux-gnu-debug.tar.gz	`e1f582e8c913e6f8...`	`43f16615dbd35be3...`
*-x86_64-linux-gnu.tar.gz	`6301a99a96b464f2...`	`c21d9feeb3b99ff5...`
*.tar.gz	`e12e9626fc7e6f51...`	`5aa7431673fade47...`
guix_build.log	`663ee5e738acc55a...`	`d76f26d17a53bcc8...`
guix_build.log.diff		`9f1136b1c1d2f434...`

DrahtBot removed the label DrahtBot Guix build requested on May 30, 2024

maflcko commented at 5:15 am on May 31, 2024: member

Tested on:

0# clang --version && file src/qt/bitcoin-qt 
1Ubuntu clang version 18.1.3 (1)
2Target: riscv64-unknown-linux-gnu
3Thread model: posix
4InstalledDir: /usr/bin
5src/qt/bitcoin-qt: Mach-O 64-bit arm64 executable, flags:<NOUNDEFS|DYLDLINK|TWOLEVEL|WEAK_DEFINES|BINDS_TO_WEAK|PIE|HAS_TLV_DESCRIPTORS>

0# clang --version && file src/qt/bitcoin-qt
1Ubuntu clang version 18.1.3 (1)
2Target: powerpc64le-unknown-linux-gnu
3Thread model: posix
4InstalledDir: /usr/bin
5src/qt/bitcoin-qt: Mach-O 64-bit arm64 executable, flags:<NOUNDEFS|DYLDLINK|TWOLEVEL|WEAK_DEFINES|BINDS_TO_WEAK|PIE|HAS_TLV_DESCRIPTORS>

hebasto commented at 10:17 am on May 31, 2024: member

My Guix builds:

 0x86_64
 11efa3e0205032d6cfe5517ce36ab63379afa22268dcbb0b92150719baa030682  guix-build-0a3631fc352e/output/aarch64-linux-gnu/SHA256SUMS.part
 2e3db302484148c00cab7150e3451d2c95dae14062cb4165c8e5a28d71d77e630  guix-build-0a3631fc352e/output/aarch64-linux-gnu/bitcoin-0a3631fc352e-aarch64-linux-gnu-debug.tar.gz
 3f9792f8db8635bb19f6a2d7c73f1b0780e5776734c12912c5e7172f357f7fa1f  guix-build-0a3631fc352e/output/aarch64-linux-gnu/bitcoin-0a3631fc352e-aarch64-linux-gnu.tar.gz
 4708374dcac162523ae5e2e4e7d70ff9459047a81bc9361d88b13dfdd785ebce7  guix-build-0a3631fc352e/output/arm-linux-gnueabihf/SHA256SUMS.part
 5e52744067d4f62b923bf9632a2021dbe5ff6eb43ad31f54c217614ff8f2e1d25  guix-build-0a3631fc352e/output/arm-linux-gnueabihf/bitcoin-0a3631fc352e-arm-linux-gnueabihf-debug.tar.gz
 6c08428f467d559301c6033520eacc79a4072f5baaf309bec2735d9231bb1033c  guix-build-0a3631fc352e/output/arm-linux-gnueabihf/bitcoin-0a3631fc352e-arm-linux-gnueabihf.tar.gz
 7fb2f0e76c43b608b53408a13208d80f823f7835b02a77185f24f174986f5d655  guix-build-0a3631fc352e/output/arm64-apple-darwin/SHA256SUMS.part
 8f1311d3211111d64ba55b3c515822903e8922722bacbd89b369cb1f27e492db0  guix-build-0a3631fc352e/output/arm64-apple-darwin/bitcoin-0a3631fc352e-arm64-apple-darwin-unsigned.tar.gz
 9d6d54939550b68a8c4e908fd7f45d6ecc6b06ee20453930f85fa9942849cda30  guix-build-0a3631fc352e/output/arm64-apple-darwin/bitcoin-0a3631fc352e-arm64-apple-darwin-unsigned.zip
10cbcc8d26437325d8910f6f7e81dbdf29a30e8f02670cd13b78d5c2d81b88fb36  guix-build-0a3631fc352e/output/arm64-apple-darwin/bitcoin-0a3631fc352e-arm64-apple-darwin.tar.gz
110b00c0d2ae7ffd16161ecbe652409634b1d6a3ab36d50f15890a4fdae12f394c  guix-build-0a3631fc352e/output/dist-archive/bitcoin-0a3631fc352e.tar.gz
1249ce76f35afa05205d15ba7a187fb64d2872eca0594b3aadeb53cb75487cbf9d  guix-build-0a3631fc352e/output/powerpc64-linux-gnu/SHA256SUMS.part
13bec44a5a60d434c462362fe22cea05d9de5cc32ff053397bbedfcffe714e6c11  guix-build-0a3631fc352e/output/powerpc64-linux-gnu/bitcoin-0a3631fc352e-powerpc64-linux-gnu-debug.tar.gz
1452121a4e6c3843569d455863fcebc494384ccaf10dcb2e5a6fe316efe1e03ab3  guix-build-0a3631fc352e/output/powerpc64-linux-gnu/bitcoin-0a3631fc352e-powerpc64-linux-gnu.tar.gz
15387dc56f8990a814f98a9458e6df3d34dfa7d8d19e77c84839093f8f9fb33271  guix-build-0a3631fc352e/output/riscv64-linux-gnu/SHA256SUMS.part
161ff58588d9eae9064b29834e50b8c5ca201d599672c117fbc104e4e36c797d60  guix-build-0a3631fc352e/output/riscv64-linux-gnu/bitcoin-0a3631fc352e-riscv64-linux-gnu-debug.tar.gz
174b17f0727b683e3552343f8187f184bdc21e74b1c3a6668ab0b806a08cb9ef91  guix-build-0a3631fc352e/output/riscv64-linux-gnu/bitcoin-0a3631fc352e-riscv64-linux-gnu.tar.gz
18385902545f37891d2f5dca84a695d5f80e104aaea984eabab68f1454b8453a94  guix-build-0a3631fc352e/output/x86_64-apple-darwin/SHA256SUMS.part
19e52be71b1cf0eb0ef37a6488bffb384ecbf5dc0a76b5eca8c7ec49e3ea380073  guix-build-0a3631fc352e/output/x86_64-apple-darwin/bitcoin-0a3631fc352e-x86_64-apple-darwin-unsigned.tar.gz
2080c726574fa9fb2822d313262c34501888dd4fa58f6c71be247b5a3b152b6b19  guix-build-0a3631fc352e/output/x86_64-apple-darwin/bitcoin-0a3631fc352e-x86_64-apple-darwin-unsigned.zip
2142de5d078bfc1afb646e9c25c8adce6ad3a2f2a4bc53341c17ac17fd1a132653  guix-build-0a3631fc352e/output/x86_64-apple-darwin/bitcoin-0a3631fc352e-x86_64-apple-darwin.tar.gz
2283d24dc27fa4f51382492345daa1515b73e1646c3e00b088affa2edf481c8d1a  guix-build-0a3631fc352e/output/x86_64-linux-gnu/SHA256SUMS.part
235e2aa04d77f563d6261fe4575a014f6226b949282c873f4126f2f3d89645d8c6  guix-build-0a3631fc352e/output/x86_64-linux-gnu/bitcoin-0a3631fc352e-x86_64-linux-gnu-debug.tar.gz
246636337a95cf886670c88e43e6da01481efe8a415a2fea576a0ab759ac2f06f3  guix-build-0a3631fc352e/output/x86_64-linux-gnu/bitcoin-0a3631fc352e-x86_64-linux-gnu.tar.gz
25628236de61ed3cf621f9f1c094e2849777c9b67cd7faf1b3ebb1fcc453e59f89  guix-build-0a3631fc352e/output/x86_64-w64-mingw32/SHA256SUMS.part
2649bfa94d4c37158b32ef9e560b7211da6b998937eee46573efd3627ec9f8050c  guix-build-0a3631fc352e/output/x86_64-w64-mingw32/bitcoin-0a3631fc352e-win64-debug.zip
27641767ffd7fe4d72ddb326885cc74c12a79f7719c8c27d87cc2b9fe902e31669  guix-build-0a3631fc352e/output/x86_64-w64-mingw32/bitcoin-0a3631fc352e-win64-setup-unsigned.exe
28c2eed2510db96247a3627766b0474ff374aa266e46f5f4376875971952b8dcf4  guix-build-0a3631fc352e/output/x86_64-w64-mingw32/bitcoin-0a3631fc352e-win64-unsigned.tar.gz
29f14bad165f6a434d60befe6060573a15e9c481756046843c856c6278efc07f46  guix-build-0a3631fc352e/output/x86_64-w64-mingw32/bitcoin-0a3631fc352e-win64.zip

hebasto approved

hebasto commented at 11:58 am on May 31, 2024: member

ACK 0a3631fc352eda849290db940844e5ef723436df, a new patch indeed fixes cross-compiling on Ubuntu 24.04 with FORCE_USE_SYSTEM_CLANG=1.

fanquake merged this on May 31, 2024

fanquake closed this on May 31, 2024

fanquake deleted the branch on May 31, 2024

luke-jr commented at 5:49 pm on June 4, 2024: member

You forgot to update doc/dependencies.md

depends: qt 5.15.14 and fix macOS build with Clang 18 #30198

Code Coverage

Reviews

Conflicts

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]