depends: consolidate dependency docs #30204

1. 
   fanquake commented at 3:17 pm on May 30, 2024: member

   Adds missing g++ for macOS. This is needed by Qt:

   0Configuring qt...
   1Creating qmake...
   2gmake[1]: Entering directory '/bitcoin/depends/work/build/arm64-apple-darwin/qt/5.15.14-4bca24c8f89/qtbase/qmake'
   3gmake[1]: g++: No such file or directory
   4gmake[1]: *** [Makefile:250: main.o] Error 127
   

   xz-utils was also missing (but generally already installed), and is needed for the .tar.xz tarballs.

   Remove bsdmainutils, as this is only needed by the main build system (for tests), and isn’t needed to complete a depends build.

2. 
   DrahtBot commented at 3:17 pm on May 30, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	maflcko
   Stale ACK	theuni

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #30201 (depends: remove FORCE_USE_SYSTEM_CLANG by fanquake)
   • #29923 (depends: Remove Qt build-time dependencies by laanwj)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

3. DrahtBot added the label Build system on May 30, 2024
4. 
   maflcko commented at 3:27 pm on May 30, 2024: member

   utACK e99ecf01a54dd0d1b3b384b70125caa819724578
5. 
   theuni commented at 3:54 pm on May 30, 2024: member

   Removes bsdmainutils for macOS, as couldn’t see where it’s needed, and could complete a build with it uninstalled. Can re-add if someone knows what it’s needed for.

   IIRC this was needed for hexdump, which is needed to build some tests. Maybe it’s already installed by something else?

6. 
   fanquake commented at 3:56 pm on May 30, 2024: member

   IIRC this was needed for hexdump, which is needed to build some tests.

   Right. So not needed to compile depends, but needed by our buildsystem for test-related things. Given that sounds like it’s a dependency for all platforms in any case, then it could just be moved into Common, if we want to keep it in the depends readme?

7. fanquake force-pushed on May 30, 2024
8. 
   fanquake commented at 4:00 pm on May 30, 2024: member

   then it could just be moved into Common,

   Have done this.

9. theuni approved
10. 
    theuni commented at 4:13 pm on May 30, 2024: member

    ACK 01cd425f083b2d38bced8bda8163d87359ea1f59
11. DrahtBot requested review from maflcko on May 30, 2024
12. in depends/README.md:48 in 01cd425f08 outdated

    42@@ -43,9 +43,13 @@ The paths are automatically configured and no other options are needed.
    43 
    44 ### Install the required dependencies: Ubuntu & Debian
    45 
    46+#### Common
    47+
    48+    apt install automake bison bsdmainutils cmake curl libtool make patch pkg-config python3 xz-utils
    

    ---

    ---

    

    maflcko commented at 4:25 pm on May 30, 2024:

    Might as well put in build-essential when this includes Bitcoin Core dependencies such as bsdmainutils?

    Ref: https://github.com/bitcoin/bitcoin/blob/master/doc/build-unix.md#dependency-build-instructions

    ---

    

    fanquake commented at 4:31 pm on May 30, 2024:

    Right, we could, but https://packages.ubuntu.com/mantic/build-essential is basically gcc, g++ and make. Should we then remove make from this list too, and g++ from the macOS list?

    I think I’d actually rather remove bsdmainutils, as I really wanted the dependencies listed here to just be what is required to actually build depends, rather than everything needed for Bitcoin Core.

    ---

    

    fanquake commented at 4:32 pm on May 30, 2024:

    Happy to also update build-unix at the same time, to add anything that is missing.

    ---

    

    maflcko commented at 4:32 pm on May 30, 2024:

    I agree, but probably it doesn’t matter much. Should be fine to merge either.

    ---

    

    theuni commented at 4:57 pm on May 30, 2024:

    I think I’d actually rather remove bsdmainutils, as I really wanted the dependencies listed here to just be what is required to actually build depends, rather than everything needed for Bitcoin Core.

    Works for me.

    ---

    

    fanquake commented at 8:31 am on May 31, 2024:

    Pushed that now.
13. DrahtBot requested review from maflcko on May 30, 2024
14. depends: consolidate dependency docs

    Adds missing `g++` for macOS. This is needed by Qt:
    ```bash
    Configuring qt...
    Creating qmake...
    gmake[1]: Entering directory '/bitcoin/depends/work/build/arm64-apple-darwin/qt/5.15.14-4bca24c8f89/qtbase/qmake'
    gmake[1]: g++: No such file or directory
    gmake[1]: *** [Makefile:250: main.o] Error 127
    ```
    
    `xz-utils` was also missing (but generally already installed), and is
    needed for the `.tar.xz` tarballs.
    
    Remove bsdmainutils, as this is only needed by the main build system
    (for tests), and isn't needed to complete a depends build.

    a27e1ceb9f
15. fanquake force-pushed on May 31, 2024
16. 
    maflcko commented at 1:10 pm on May 31, 2024: member

    ACK a27e1ceb9f9c9239af9b0a151c84a57573ea646a
17. DrahtBot requested review from theuni on May 31, 2024
18. fanquake merged this on May 31, 2024
19. fanquake closed this on May 31, 2024

    ---

20. fanquake deleted the branch on May 31, 2024

Contributors
fanquake DrahtBot maflcko theuni

Review Requested
theuni maflcko

Labels
Build system