ci: Native Windows CI job cleanup #30242

pull hebasto wants to merge 2 commits into bitcoin:master from hebasto:240607-ci-win changing 1 files +5 −9
  1. hebasto commented at 9:05 am on June 7, 2024: member

    This PR:

    1. Removes no longer needed workaround for GHA Windows images.

    GHA Windows images previously had multiple VC Build Tools installed, which required specifying the VCPKG_PLATFORM_TOOLSET_VERSION explicitly to avoid linker errors. This issue has been resolved as per https://github.com/actions/runner-images/issues/9701.

    1. Switches all references to temporary files to relative ones for consistency and readability.
  2. ci: Remove no longer needed workaround for GHA Windows images
    GHA Windows images previously had multiple VC Build Tools installed,
    which required specifying the `VCPKG_PLATFORM_TOOLSET_VERSION`
    explicitly to avoid linker errors. This issue has been resolved as per
    https://github.com/actions/runner-images/issues/9701.
    501aceefcf
  3. hebasto added the label Windows on Jun 7, 2024
  4. hebasto added the label Tests on Jun 7, 2024
  5. DrahtBot commented at 9:05 am on June 7, 2024: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage

    For detailed information about the code coverage, see the test coverage report.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK sipsorcery, maflcko

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #29790 ([DO NOT MERGE] cmake: Migrate CI scripts to CMake-based build system – WIP by hebasto)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  6. hebasto marked this as a draft on Jun 7, 2024
  7. ci: Use relative paths in `win64-native` CI job consistently
    This change improves readability. Also the `Tee-Object` cmdlet is used
    when appropriate.
    0d3ef83433
  8. hebasto force-pushed on Jun 7, 2024
  9. hebasto marked this as ready for review on Jun 7, 2024
  10. hebasto commented at 9:55 am on June 7, 2024: member
    Friendly ping @m3dwards @sipsorcery ;)
  11. hebasto referenced this in commit 6cb2b793b3 on Jun 7, 2024
  12. hebasto referenced this in commit 9eee18869a on Jun 7, 2024
  13. sipsorcery commented at 9:17 pm on June 7, 2024: member
    ACK 0d3ef83433805d3f367130fd5bd227a8ed5a7ccd.
  14. maflcko commented at 8:55 am on June 9, 2024: member
    ACK 0d3ef83433805d3f367130fd5bd227a8ed5a7ccd
  15. fanquake merged this on Jun 10, 2024
  16. fanquake closed this on Jun 10, 2024

  17. hebasto deleted the branch on Jun 10, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-09-28 22:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me