refactor: Add explicit cast to expected_last_page to silence fuzz ISan #30248

pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2406-bdb-fuzz-isan changing 1 files +1 −1
  1. maflcko commented at 3:33 pm on June 7, 2024: member

    Fixes #30247

    I don’t think this implicit cast can lead to any bugs, so make it explicit to silence the fuzz integer sanitizer.

    Can be tested with:

    0FUZZ=wallet_bdb_parser UBSAN_OPTIONS="suppressions=$(pwd)/test/sanitizer_suppressions/ubsan:print_stacktrace=1:halt_on_error=1:report_error_type=1" ./src/test/fuzz/fuzz /tmp/1376869be72eebcc87fe737020add634b1a29533
    

    After downloading the raw fuzz input from https://github.com/bitcoin-core/qa-assets/blob/24c507b3ea6263e6b121fb8dced01123065c44c2/fuzz_seed_corpus/wallet_bdb_parser/1376869be72eebcc87fe737020add634b1a29533

  2. refactor: Add explicit cast to expected_last_page to silence fuzz ISan fa9cb101cf
  3. DrahtBot commented at 3:33 pm on June 7, 2024: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage

    For detailed information about the code coverage, see the test coverage report.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK dergoegge

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. DrahtBot added the label Refactoring on Jun 7, 2024
  5. fanquake requested review from dergoegge on Jun 10, 2024
  6. fanquake requested review from achow101 on Jun 10, 2024
  7. dergoegge approved
  8. dergoegge commented at 8:37 am on June 13, 2024: member
    utACK fa9cb101cf33b57b2c043b29f1f3d55b990ba4c6
  9. maflcko added this to the milestone 28.0 on Jun 18, 2024
  10. fanquake merged this on Jun 20, 2024
  11. fanquake closed this on Jun 20, 2024

  12. maflcko deleted the branch on Jun 20, 2024


maflcko DrahtBot dergoegge


achow101

Labels
Refactoring

Milestone
28.0


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-03 18:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me