[27.x] More backports #30305

1. 
   fanquake commented at 9:13 am on June 19, 2024: member

   Backports:

   • #30193
   • #30283
   • https://github.com/bitcoin/bitcoin/pull/30299
2. fanquake added this to the milestone 27.2 on Jun 19, 2024
3. 
   DrahtBot commented at 9:13 am on June 19, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	willcl-ark, stickies-v

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

4. DrahtBot added the label Backport on Jun 19, 2024
5. 
   maflcko commented at 11:42 am on June 19, 2024: member

   CI note: If you want the Asan task, you’ll have to backport it from GHA
6. ci: add IPV6 network to ci container

   Allows IPV6 functional tests to run inside the container
   
   Github-Pull: #30193
   Rebased-From: 4b527fa93b9763a33842069bc07446313cbf5e0f

   43c40dd808
7. ci: move Asan / LSan / USDT job to Github Actions

   Moving it from Cirrus CI so it can be easier to maintain and used by forks
   
   Github-Pull: #30193
   Rebased-From: 9eea51d9058ad638861aa4b94c1c6e71caeb8765

   0d524b1484
8. ci: remove unused bcc variable from workflow

   Github-Pull: #30299
   Rebased-From: 518b06c4b889d71a3fdd61f8fe38d519ea5e4a1b

   f34e44616d
9. upnp: add compatibility for miniupnpc 2.2.8

   See: https://github.com/miniupnp/miniupnp/commit/c0a50ce33e3b99ce8a96fd43049bb5b53ffac62f
   
   The return value of 2 now indicates:
   "A valid connected IGD has been found but its IP address is reserved (non routable)"
   
   We continue to ignore any return value other than 1.
   
   Github-Pull: #30283
   Rebased-From: 8acdf66540834b9f9cf28f16d389e8b6a48516d5

   6338f92260
10. fanquake force-pushed on Jun 19, 2024
11. fanquake marked this as ready for review on Jun 24, 2024
12. doc: Update rel notes for 27.x b3093eb755
13. fanquake force-pushed on Jun 24, 2024
14. willcl-ark approved
15. 
    willcl-ark commented at 10:47 am on June 24, 2024: member

    ACK b3093eb755c00f0dc6c71d8384c9078603ef4862

    Manually compared each backported commit with its original version.

16. stickies-v approved
17. 
    stickies-v commented at 11:24 am on June 24, 2024: contributor

    ACK b3093eb755c00f0dc6c71d8384c9078603ef4862

    All backports are clean, except:

    • 0d524b14847f94d6e19413fde27f12e39e34694c backported from 9eea51d9058ad638861aa4b94c1c6e71caeb8765: win64-native CI steps Clone fuzz corpus and RUun fuzz binaries aren’t backported, they are part of #29774
18. in doc/release-notes.md:4 in b3093eb755

    0@@ -1,9 +1,9 @@
    1-27.1 Release Notes
    2+27.x Release Notes
    3 =====================
    4 
    5-Bitcoin Core version 27.1 is now available from:
    6+Bitcoin Core version 27.x is now available from:
    

    ---

    ---

    

    stickies-v commented at 11:29 am on June 24, 2024:

    I know we usually do it this way, but what’s the harm in just making this (and other references, except for the git tag) 27.2rc1 right away?

    ---

    

    fanquake commented at 11:30 am on June 24, 2024:

    The next release might not be 27.2. It could be 27.1.1 etc.

    ---

    

    stickies-v commented at 11:48 am on June 24, 2024:

    Sure, but that seems to be an undocumented exception? Since 0.10.0, it seems we only have 3 (in the root dir) releases where we we had a non-zero patch number. We also don’t mention patch versions in our documentation.

    Keeping the git tag to .x makes sense because it gives us the flexibility to release as a minor or a patch version, i.e. we can still easily update the release notes to 27.1.1 if necessary. It just seems like currently the code/doc updates just add a bit of unnecessary churn? Anyway, no biggie either way.

    ---

    

    fanquake commented at 12:35 pm on June 24, 2024:

    Ok. Lets follow up with ways we might want to streamline this for 28.x.
19. fanquake merged this on Jun 24, 2024
20. fanquake closed this on Jun 24, 2024

    ---

21. fanquake deleted the branch on Jun 24, 2024

Contributors
fanquake DrahtBot maflcko willcl-ark stickies-v

Labels
Backport

Milestone
27.2