QA: Expect PACKAGE_NAME rather than constant “Bitcoin Core” #30308

1. 
   luke-jr commented at 2:59 pm on June 19, 2024: member

   Followup to #29144
2. QA: Expect PACKAGE_NAME rather than constant "Bitcoin Core" 197b5404b0
3. 
   DrahtBot commented at 3:00 pm on June 19, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	kevkevinpal, tdb3

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

4. DrahtBot added the label Tests on Jun 19, 2024
5. 
   kevkevinpal commented at 3:03 pm on June 19, 2024: contributor

   ACK 197b540

   we’re doing this in these files aswell so seems fine to me

   0test/functional/wallet_multiwallet.py 
   1test/functional/tool_wallet.py 
   2test/functional/interface_bitcoin_cli.py 
   3test/functional/feature_filelock.py
   

6. 
   kevkevinpal commented at 3:10 pm on June 19, 2024: contributor

   I see we’re doing something similar in ./test/functional/wallet_backwards_compatibility.py

   0node_v17.assert_start_raises_init_error(["-wallet=w3"], "Error: Error loading w3: Wallet requires newer version of Bitcoin Core")
   1
   2and
   3
   4node_v16.assert_start_raises_init_error([f"-wallet={wallet_name}"], f"Error: Error loading {wallet_name}: Wallet requires newer version of Bitcoin Core")
   

   not sure if you want to update here aswell in this PR

7. tdb3 approved
8. 
   tdb3 commented at 8:51 pm on June 19, 2024: contributor

   ACK 197b5404b0f4a1d6e989000845b45c8bd24e0bc6 grepped for other instances of Bitcoin Core in test/functional/ and didn’t see any beyond what @kevkevinpal identified.
9. 
   fanquake commented at 8:37 am on June 20, 2024: member

   not sure if you want to update here aswell in this PR @luke-jr can you update this PR to include the additional changes.

10. 
    maflcko commented at 8:56 am on June 20, 2024: member

    previous releaseas are hardcoded to be Bitcoin Core, so no need to change that

    I wonder if one CI task should modify the PACKAGE_NAME to be something else, e.g. Bitcoin Core CI-build?

11. 
    fanquake commented at 9:00 am on June 20, 2024: member

    previous releaseas are hardcoded to be Bitcoin Core, so need to change that

    It can be changed just for consistency, and to prevent similar issues in future when devs copy-paste code.

12. 
    luke-jr commented at 7:20 pm on June 21, 2024: member

    It can be changed just for consistency, and to prevent similar issues in future when devs copy-paste code.

    Changing it would break that test.

    I don’t think there’s anything more to do here at the moment. (CI is a good idea, but seems suited to a different PR)

13. nehtech9 approved
14. 
    fanquake commented at 2:17 pm on June 24, 2024: member

    Changing it would break that test.

    Not in our repository though? In any case, this could be revisited if someone follows up with a CI change.

15. fanquake merged this on Jun 24, 2024
16. fanquake closed this on Jun 24, 2024

    ---

Contributors
luke-jr DrahtBot kevkevinpal tdb3 fanquake maflcko nehtech9

Labels
Tests