[26.x] upnp: fix build with miniupnpc 2.2.8 #30319

pull fanquake wants to merge 2 commits into bitcoin:26.x from fanquake:backport_upnp_api_fix changing 2 files +6 −1
  1. fanquake commented at 2:51 pm on June 21, 2024: member
    Backports #30283 to the 26.x branch.
  2. upnp: add compatibility for miniupnpc 2.2.8
    See: https://github.com/miniupnp/miniupnp/commit/c0a50ce33e3b99ce8a96fd43049bb5b53ffac62f
    
    The return value of 2 now indicates:
    "A valid connected IGD has been found but its IP address is reserved (non routable)"
    
    We continue to ignore any return value other than 1.
    
    Github-Pull: #30283
    Rebased-From: 8acdf66540834b9f9cf28f16d389e8b6a48516d5
    391ce775f4
  3. doc: add 30283 cherry-pick to rel notes 10413ac46c
  4. fanquake requested review from theuni on Jun 21, 2024
  5. DrahtBot commented at 2:51 pm on June 21, 2024: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage

    For detailed information about the code coverage, see the test coverage report.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK theuni, edilmedeiros

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  6. DrahtBot renamed this:
    [26.x] upnp: fix build with miniupnpc 2.2.8
    [26.x] upnp: fix build with miniupnpc 2.2.8
    on Jun 21, 2024
  7. DrahtBot added the label Backport on Jun 21, 2024
  8. theuni approved
  9. theuni commented at 7:06 pm on June 21, 2024: member
    ACK 10413ac46c07d3a45dc9d71818f59ffdb1129032
  10. edilmedeiros commented at 3:01 am on June 24, 2024: contributor
    ACK 10413ac46c07d3a45dc9d71818f59ffdb1129032
  11. fanquake merged this on Jun 24, 2024
  12. fanquake closed this on Jun 24, 2024

  13. fanquake deleted the branch on Jun 24, 2024
  14. Bbjj88h approved

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-21 18:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me