fuzz: improve utxo_snapshot target #30329

1. 
   mzumsande commented at 7:41 pm on June 24, 2024: contributor

   Add the possibility of giving more guidance to the creation of the metadata and/or coins, so that the fuzzer gets the chance to reach more error conditions in ActivateSnapshot and sometimes successfully creates a valid snapshot.

   This also changes the asserts for the success case that were outdated (after #29370) and only didn’t result in a crash because the fuzzer wasn’t able to reach this code before.

2. 
   DrahtBot commented at 7:41 pm on June 24, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   Concept ACK	fjahr

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #30320 (assumeutxo: Don’t load a snapshot if it’s not in the best header chain by mzumsande)
   • #30267 (assumeutxo: Check snapshot base block is not in invalid chain by fjahr)
   • #29656 (chainparams: Change nChainTx type to uint64_t by fjahr)
   • #29307 (util: explicitly close all AutoFiles that have been written by vasild)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

3. DrahtBot added the label Tests on Jun 24, 2024
4. mzumsande force-pushed on Jun 24, 2024
5. DrahtBot added the label CI failed on Jun 24, 2024
6. 
   DrahtBot commented at 8:51 pm on June 24, 2024: contributor

   🚧 At least one of the CI tasks failed. Make sure to run all tests locally, according to the documentation.

   Possibly this is due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.

   Leave a comment here, if you need help tracking down a confusing failure.

   Debug: https://github.com/bitcoin/bitcoin/runs/26619261177

7. mzumsande force-pushed on Jun 24, 2024
8. 
   fjahr commented at 9:47 pm on June 24, 2024: contributor

   Concept ACK
9. fuzz: improve utxo_snapshot target

   Add the possibility of giving more guidance to the creation of the
   metadata and/or coins, so that the fuzzer gets the chance
   to reach more error conditions in ActivateSnapshot and sometimes
   successfully creates a valid snapshot.
   
   This also changes the asserts for the success case that were outdated,
   and only didn't result in a crash because the fuzzer wasn't able
   to reach this code before.

   3c8d883b3e
10. mzumsande force-pushed on Jun 24, 2024
11. DrahtBot removed the label CI failed on Jun 24, 2024

Contributors
mzumsande DrahtBot fjahr

Labels
Tests