depends: update doc in Qt pwd patch #30336

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:qt_pwd_patch_upstream changing 1 files +7 −7
  1. fanquake commented at 4:03 pm on June 25, 2024: member
    Now that upstream has gotten around to fixing this. We don’t need any more of the patch, and it likely wont apply to our version of Qt in any case. See: https://github.com/qt/qtbase/commit/3388de698bfb9bbc456c08f03e83bf3e749df35c.
  2. depends: update doc in Qt pwd patch
    Now that upstream has gotten around to fixing this. We don't need any
    more of the patch, and it likely wont apply to our version of Qt in any
    case. See:
    https://github.com/qt/qtbase/commit/3388de698bfb9bbc456c08f03e83bf3e749df35c.
    f170fe04ca
  3. DrahtBot commented at 4:03 pm on June 25, 2024: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage

    For detailed information about the code coverage, see the test coverage report.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK theuni

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. DrahtBot added the label Build system on Jun 25, 2024
  5. theuni commented at 6:31 pm on July 11, 2024: member
    Nice, utACK. Any reason not to just take their full patch, though? Guessing it doesn’t apply cleanly?
  6. fanquake commented at 6:36 pm on July 11, 2024: member
    Yea, iirc. Also didn’t want to change anything else here, and possibly break anything else, given we don’t need any other changes.
  7. theuni approved
  8. theuni commented at 6:39 pm on July 11, 2024: member
    ACK f170fe04ca03fe4021cbff7c5450ce3cc7fda17f
  9. fanquake merged this on Jul 12, 2024
  10. fanquake closed this on Jul 12, 2024

  11. fanquake deleted the branch on Jul 12, 2024
  12. PastaPastaPasta referenced this in commit fda46b685a on Oct 25, 2024
  13. PastaPastaPasta referenced this in commit ebed8af1d0 on Oct 27, 2024
  14. PastaPastaPasta referenced this in commit 565f2db930 on Oct 27, 2024
  15. bitcoin locked this on Jul 12, 2025

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-07-15 18:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me