GetTime is mockable in tests and system-changeable in production. This should be fine and not lead to issues, but using SteadyClock is more correct in this context to do an expensive task only so often.
util: Use SteadyClock in RandAddSeedPerfmon #30372
pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2407-rand-steady changing 1 files +3 −3-
maflcko commented at 3:43 PM on July 1, 2024: member
-
util: Use SteadyClock in RandAddSeedPerfmon fa360b047f
-
DrahtBot commented at 3:43 PM on July 1, 2024: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage
For detailed information about the code coverage, see the test coverage report.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK sipa, TheCharlatan If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
- DrahtBot added the label Utils/log/libs on Jul 1, 2024
-
sipa commented at 4:47 PM on July 1, 2024: member
utACK fa360b047fc578fd855b8f7420d84dc967884f4a
- TheCharlatan approved
-
TheCharlatan commented at 1:01 PM on July 2, 2024: contributor
ACK fa360b047fc578fd855b8f7420d84dc967884f4a
- fanquake merged this on Jul 12, 2024
- fanquake closed this on Jul 12, 2024
- maflcko deleted the branch on Jul 12, 2024
- PastaPastaPasta referenced this in commit 53aca84e5c on Oct 25, 2024
- PastaPastaPasta referenced this in commit 69c04b2c48 on Oct 27, 2024
- PastaPastaPasta referenced this in commit 565f2db930 on Oct 27, 2024
- bitcoin locked this on Jul 12, 2025
Contributors
Labels