Revert “test: p2p: check that connecting to ourself leads to disconnect” #30374

1. 
   theStack commented at 6:55 pm on July 1, 2024: contributor

   As suggested in #30368 (comment), this PR reverts the recently added test #30362 that causes frequent CI failures. A TODO is added in the functional test file to re-add it later when the race condition is fixed.
2. Revert "test: p2p: check that connecting to ourself leads to disconnect"

   This reverts commit 5d2fb14bafe4e80c0a482d99e5ebde07c477f000 and
   adds a TODO to add it later again once the race condition is fixed.

   9ec2c53701
3. 
   DrahtBot commented at 6:55 pm on July 1, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	mzumsande, brunoerg, tdb3

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

4. 
   mzumsande commented at 7:06 pm on July 1, 2024: contributor

   utACK 9ec2c53701a391629b55aeb2804e8060d2c453a4
5. brunoerg approved
6. 
   brunoerg commented at 7:11 pm on July 1, 2024: contributor

   utACK 9ec2c53701a391629b55aeb2804e8060d2c453a4
7. tdb3 approved
8. 
   tdb3 commented at 10:33 pm on July 1, 2024: contributor

   ACK 9ec2c53701a391629b55aeb2804e8060d2c453a4 Glad this test found a bug! Makes sense to revert this out until the issue is fixed. Ran the test locally.
9. maflcko approved
10. 
    maflcko commented at 6:21 am on July 2, 2024: member

    lgtm
11. fanquake merged this on Jul 2, 2024
12. fanquake closed this on Jul 2, 2024

    ---

13. theStack deleted the branch on Jul 2, 2024

Contributors
theStack DrahtBot mzumsande brunoerg tdb3 maflcko