As suggested in #30368 (comment), this PR reverts the recently added test #30362 that causes frequent CI failures. A TODO is added in the functional test file to re-add it later when the race condition is fixed.
Revert "test: p2p: check that connecting to ourself leads to disconnect" #30374
pull theStack wants to merge 1 commits into bitcoin:master from theStack:revert-pr30362 changing 1 files +3 −6-
theStack commented at 6:55 PM on July 1, 2024: contributor
-
9ec2c53701
Revert "test: p2p: check that connecting to ourself leads to disconnect"
This reverts commit 5d2fb14bafe4e80c0a482d99e5ebde07c477f000 and adds a TODO to add it later again once the race condition is fixed.
-
DrahtBot commented at 6:55 PM on July 1, 2024: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage
For detailed information about the code coverage, see the test coverage report.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
-
mzumsande commented at 7:06 PM on July 1, 2024: contributor
utACK 9ec2c53701a391629b55aeb2804e8060d2c453a4
- brunoerg approved
-
brunoerg commented at 7:11 PM on July 1, 2024: contributor
utACK 9ec2c53701a391629b55aeb2804e8060d2c453a4
- tdb3 approved
-
tdb3 commented at 10:33 PM on July 1, 2024: contributor
ACK 9ec2c53701a391629b55aeb2804e8060d2c453a4 Glad this test found a bug! Makes sense to revert this out until the issue is fixed. Ran the test locally.
- maflcko approved
-
maflcko commented at 6:21 AM on July 2, 2024: member
lgtm
- fanquake merged this on Jul 2, 2024
- fanquake closed this on Jul 2, 2024
- theStack deleted the branch on Jul 2, 2024
- bitcoin locked this on Jul 2, 2025
