contrib: use c++ compiler rather than c compiler for binary checks #30387

pull theuni wants to merge 3 commits into bitcoin:master from theuni:cxx-security-check changing 3 files +75 −75
  1. theuni commented at 0:48 am on July 4, 2024: member

    From hebasto’s CMake repo. See discussion here: https://github.com/hebasto/bitcoin/pull/252#discussion_r1664657488

    Use CXX/CXXFLAGS rather than CC/CFLAGS to test our actual compiler for binary checks rather than the one we only forward to secp256k1.

  2. DrahtBot commented at 0:48 am on July 4, 2024: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage

    For detailed information about the code coverage, see the test coverage report.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK hebasto, fanquake

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #30423 (contrib: simplify test-security-check by fanquake)
    • #27038 (security-check: test for _FORTIFY_SOURCE usage in release binaries by fanquake)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  3. DrahtBot added the label Scripts and tools on Jul 4, 2024
  4. theuni added the label DrahtBot Guix build requested on Jul 4, 2024
  5. Tina1L approved
  6. hebasto commented at 9:07 am on July 4, 2024: member

    Use CXX/CXXFLAGS rather than CC/CFLAGS to test our actual compiler for binary checks rather than the one we only forward to secp256k1.

    Concept ACK on that.

    From hebasto’s CMake repo. See discussion here: hebasto#252 (comment)

    While the discussion was raised in the CMake project, I’d like to note that this change is not required for it. However, the CMake project’s implementation depends on this PR.

  7. DrahtBot commented at 12:58 pm on July 4, 2024: contributor

    Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

    File commit 3714692644f45808a6480525abc36870aeee1de4(master) commit 3c8ae9f87da307d1047df4bf51b2896b95313539(master and this pull)
    SHA256SUMS.part d41c7d41da575672... 829f749d8e9d9291...
    *-aarch64-linux-gnu-debug.tar.gz f7897c27a1d2ced4... 752b54f93c7a4a97...
    *-aarch64-linux-gnu.tar.gz 18bb14e300355588... 0d9dd43ce855883b...
    *-arm-linux-gnueabihf-debug.tar.gz b3a532343e46beb5... ebae117737f31eb0...
    *-arm-linux-gnueabihf.tar.gz 81a760da1d4ab412... 49632047ddd9a441...
    *-arm64-apple-darwin-unsigned.tar.gz 070a3855d640a915... b54e9deda9887c13...
    *-arm64-apple-darwin-unsigned.zip 6ae4adba654de987... 96ed754c507c1006...
    *-arm64-apple-darwin.tar.gz 29173dc0eff64a18... fce87d809244ec40...
    *-powerpc64-linux-gnu-debug.tar.gz b7aebe8bc1ebb018... 20bb5242cf6834e0...
    *-powerpc64-linux-gnu.tar.gz b98a53be49a46a34... 04acbd61aee7d764...
    *-riscv64-linux-gnu-debug.tar.gz 697f47773a0f543d... ca3aac67fa562e62...
    *-riscv64-linux-gnu.tar.gz d03f94ad770d885c... 29f01dbdce7cdacb...
    *-x86_64-apple-darwin-unsigned.tar.gz bb7d800856a9ab70... c738537791d55571...
    *-x86_64-apple-darwin-unsigned.zip 44905a4c82c02b38... a78b0730b194daf4...
    *-x86_64-apple-darwin.tar.gz d3ec6e7f9187097f... 1778dd05872182cb...
    *-x86_64-linux-gnu-debug.tar.gz 0a7e1ee671d4599c... f32406f3487ede58...
    *-x86_64-linux-gnu.tar.gz f08b8a57703e94d2... 9fb0bc023d8543b7...
    *.tar.gz 05a1b03d4c612d47... 68d44148ba75ed22...
    guix_build.log 7ea72927f335e155... aedcdef7094e6084...
    guix_build.log.diff ddecbfe38841329d...
  8. DrahtBot removed the label DrahtBot Guix build requested on Jul 4, 2024
  9. hebasto commented at 1:12 pm on July 4, 2024: member

    My Guix build:

     0x86_64
     133e4e9bba968ed9ee96f67a8535b71bc1b1c5ede7038a2b636f406262474ddca  guix-build-98ff3703b81f/output/aarch64-linux-gnu/SHA256SUMS.part
     2d670e9a8cc34c7b8e9567ee8654b5323ee102e18cbbd53d541deae779100f344  guix-build-98ff3703b81f/output/aarch64-linux-gnu/bitcoin-98ff3703b81f-aarch64-linux-gnu-debug.tar.gz
     38a96d7fb1539524b8d29eb768cf3d4ed2428df203fba3bce0ff173b733cb8d51  guix-build-98ff3703b81f/output/aarch64-linux-gnu/bitcoin-98ff3703b81f-aarch64-linux-gnu.tar.gz
     4d0e0d95561427154082def7876ffab0af623434bd560fee2abbed4c83fe33d9c  guix-build-98ff3703b81f/output/arm-linux-gnueabihf/SHA256SUMS.part
     58790f82d3810aaf07fa72062074daf8ac65bf42316a4521ee3a068647ea1aae2  guix-build-98ff3703b81f/output/arm-linux-gnueabihf/bitcoin-98ff3703b81f-arm-linux-gnueabihf-debug.tar.gz
     62a9b099feb1f962ff7680f5a750713d292758d140c63698fddc14c2482937e67  guix-build-98ff3703b81f/output/arm-linux-gnueabihf/bitcoin-98ff3703b81f-arm-linux-gnueabihf.tar.gz
     74d1db0f3aa39c100a991056950a07593aa9e65b35b5412faddc50fae560de4c1  guix-build-98ff3703b81f/output/arm64-apple-darwin/SHA256SUMS.part
     823e03471b7ab74326b2f61ce4b35c5aa20e2890769da1d98f3d5d7c7193d7516  guix-build-98ff3703b81f/output/arm64-apple-darwin/bitcoin-98ff3703b81f-arm64-apple-darwin-unsigned.tar.gz
     95c45236ecf9b0c6159e27d4448723be8eb68fdf1a9117ce9bded3744ef2c4b1a  guix-build-98ff3703b81f/output/arm64-apple-darwin/bitcoin-98ff3703b81f-arm64-apple-darwin-unsigned.zip
    1045885dbedd8281b22e3ddb755eaee84ec663a73c31e157812c714145f786f335  guix-build-98ff3703b81f/output/arm64-apple-darwin/bitcoin-98ff3703b81f-arm64-apple-darwin.tar.gz
    116b0da9684b9a5859ead9c7bd25726981a90b6f7fd4be73163b536c7530726ea9  guix-build-98ff3703b81f/output/dist-archive/bitcoin-98ff3703b81f.tar.gz
    125b3f4865f3364d199c1576e407037e048ddfe2f93f98f48df18dfce42c1f175e  guix-build-98ff3703b81f/output/powerpc64-linux-gnu/SHA256SUMS.part
    134980bdc614462e55ccd68e3178d1e5ad1f1e25f333d1e7b6f1b046c5609f2a92  guix-build-98ff3703b81f/output/powerpc64-linux-gnu/bitcoin-98ff3703b81f-powerpc64-linux-gnu-debug.tar.gz
    14ec4860223d80225f6b4685ba98c7543bc3dec943dfab6ac4d5e5b175ed1eb684  guix-build-98ff3703b81f/output/powerpc64-linux-gnu/bitcoin-98ff3703b81f-powerpc64-linux-gnu.tar.gz
    150554ff03b10b32c75cbc35c4720d8b430a7a74efcfd4b5b921188d590bf7b655  guix-build-98ff3703b81f/output/riscv64-linux-gnu/SHA256SUMS.part
    16419c9b417c7acc80cc630983ae6c3719665d4cc9e81f127ea32e6731f210ff0d  guix-build-98ff3703b81f/output/riscv64-linux-gnu/bitcoin-98ff3703b81f-riscv64-linux-gnu-debug.tar.gz
    17a8061147d63315222e44cd835f700be982a47daaaf6f3b17f1c9846e91898e69  guix-build-98ff3703b81f/output/riscv64-linux-gnu/bitcoin-98ff3703b81f-riscv64-linux-gnu.tar.gz
    189dc82d3d8309408323240f4ee33c4285f24f6c92bf749f035fce7aad948abe2c  guix-build-98ff3703b81f/output/x86_64-apple-darwin/SHA256SUMS.part
    19691389f8d49485b7918e780f4824e27384994a8d71baba03075ec616d7da012e  guix-build-98ff3703b81f/output/x86_64-apple-darwin/bitcoin-98ff3703b81f-x86_64-apple-darwin-unsigned.tar.gz
    20bb85b07f7d8487a069e64a18325eba27f7e32128e8f17224f44aa38e6f7a9673  guix-build-98ff3703b81f/output/x86_64-apple-darwin/bitcoin-98ff3703b81f-x86_64-apple-darwin-unsigned.zip
    2145c0ef2485906f55858177ed11a6ef881c77675e9cf252d7fa8214a840b07479  guix-build-98ff3703b81f/output/x86_64-apple-darwin/bitcoin-98ff3703b81f-x86_64-apple-darwin.tar.gz
    22ae23df193d78011cf9c67346c4e410c9c5b023140d8d16ffdfed172848fe4b07  guix-build-98ff3703b81f/output/x86_64-linux-gnu/SHA256SUMS.part
    233a3600cf67dd3e34b402e2d140ea7b6d8bc881a1a929ccde167072f43ae86e01  guix-build-98ff3703b81f/output/x86_64-linux-gnu/bitcoin-98ff3703b81f-x86_64-linux-gnu-debug.tar.gz
    24f41075bf832bd0a05d458f756983f993ce703e04f3a530268386c66ddb440f85  guix-build-98ff3703b81f/output/x86_64-linux-gnu/bitcoin-98ff3703b81f-x86_64-linux-gnu.tar.gz
    259ec320d7e496e5bc6ad34f2e388a13b02161b5308ca8fc4c467ea771ccbd3780  guix-build-98ff3703b81f/output/x86_64-w64-mingw32/SHA256SUMS.part
    260e9c003212e5f9cb3e005472b75d68dd86f10a005bcdf9bd8b1c9af40364cf81  guix-build-98ff3703b81f/output/x86_64-w64-mingw32/bitcoin-98ff3703b81f-win64-debug.zip
    27c39f2f213590c95d6dbe098b8e18a34d3ad0a531884c5a5e41141b927c5aa0a3  guix-build-98ff3703b81f/output/x86_64-w64-mingw32/bitcoin-98ff3703b81f-win64-setup-unsigned.exe
    28d3a5158a714c843c15146c13a85829f08e4bca2d969f06ec5998814a1af592b0  guix-build-98ff3703b81f/output/x86_64-w64-mingw32/bitcoin-98ff3703b81f-win64-unsigned.tar.gz
    29cac0c37a2d8baf280c8235fee992f9176e2f7f8be32a321053cd4bec069511e6  guix-build-98ff3703b81f/output/x86_64-w64-mingw32/bitcoin-98ff3703b81f-win64.zip
    
  10. hebasto approved
  11. hebasto commented at 1:19 pm on July 4, 2024: member
    ACK 98ff3703b81fbcece22eed55433cfe0fe101704f, I have reviewed the code and it looks OK. The Guix build script works as expected..
  12. fanquake commented at 1:29 pm on July 4, 2024: member

    Concept ACK - probably also the right time to switch the C code to something more C++. i.e:

    0#include <stdio.h>
    1int main() {
    2        printf("the quick brown fox jumps over the lazy god\\n");
    3        return 0;
    4}
    

    to

    0#include <cstdio>
    1int main() {
    2	std::printf("the quick brown fox jumps over the lazy god\n");
    3        return 0;
    4}
    
  13. in Makefile.am:342 in 98ff3703b8 outdated
    341 endif
    342 if TARGET_WINDOWS
    343-	$(AM_V_at) CC='$(CC)' CFLAGS='$(CFLAGS)' CPPFLAGS='$(CPPFLAGS)' LDFLAGS='$(LDFLAGS)' $(PYTHON) $(top_srcdir)/contrib/devtools/test-security-check.py TestSecurityChecks.test_PE
    344-	$(AM_V_at) CC='$(CC)' CFLAGS='$(CFLAGS)' CPPFLAGS='$(CPPFLAGS)' LDFLAGS='$(LDFLAGS)' $(PYTHON) $(top_srcdir)/contrib/devtools/test-symbol-check.py TestSymbolChecks.test_PE
    345+	$(AM_V_at) CC='$(CXX)' CXXFLAGS='$(CXXFLAGS)' CPPFLAGS='$(CPPFLAGS)' LDFLAGS='$(LDFLAGS)' $(PYTHON) $(top_srcdir)/contrib/devtools/test-security-check.py TestSecurityChecks.test_PE
    346+	$(AM_V_at) CC='$(CXX)' CXXFLAGS='$(CXXFLAGS)' CPPFLAGS='$(CPPFLAGS)' LDFLAGS='$(LDFLAGS)' $(PYTHON) $(top_srcdir)/contrib/devtools/test-symbol-check.py TestSymbolChecks.test_PE
    


    TheCharlatan commented at 7:48 pm on July 4, 2024:
    Why is this left as CC?

    theuni commented at 8:17 pm on July 4, 2024:
    Whoops, fixed (along with another typo)
  14. contrib: use c++ rather than c for binary tests
    We don't actually use a c compiler as part of Core's build (only for secp).
    We should be testing against what we're actually using instead.
    a38c960005
  15. contrib: rename cc to cxx in binary checking scripts 261f770333
  16. theuni force-pushed on Jul 4, 2024
  17. TheCharlatan commented at 9:49 am on July 5, 2024: contributor

    Getting a check failure during a guix build:

     0.
     1----------------------------------------------------------------------
     2Ran 1 test in 5.525s
     3
     4OK
     5F
     6======================================================================
     7FAIL: test_ELF (__main__.TestSymbolChecks)
     8----------------------------------------------------------------------
     9Traceback (most recent call last):
    10  File "/distsrc-base/distsrc-dae34eb480c8-arm-linux-gnueabihf/./contrib/devtools/test-symbol-check.py", line 69, in test_ELF
    11    self.assertEqual(call_symbol_check(cxx, source, executable, []),
    12AssertionError: Tuples differ: (1, 'test3: export of symbol __cxa_begin_c[216 chars]OLS') != (0, '')
    13
    14First differing element 0:
    151
    160
    17
    18+ (0, '')
    19- (1,
    20-  'test3: export of symbol __cxa_begin_cleanup not allowed!\n'
    21-  'test3: export of symbol __cxa_call_unexpected not allowed!\n'
    22-  'test3: export of symbol __aeabi_atexit not allowed!\n'
    23-  'test3: export of symbol __cxa_type_match not allowed!\n'
    24-  'test3: failed EXPORTED_SYMBOLS')
    25
    26----------------------------------------------------------------------
    27Ran 1 test in 1.004s
    28
    29FAILED (failures=1)
    30make: *** [Makefile:1351: test-security-check] Error 1
    
  18. hebasto commented at 10:14 am on July 11, 2024: member

    Getting a check failure during a guix build:

    I think we should avoid #include <iostream> in our test stubs, which

    behaves as if it defines a static storage duration object…

  19. in contrib/devtools/test-symbol-check.py:60 in dae34eb480 outdated
    58+        source = 'test3.cpp'
    59         executable = 'test3'
    60         with open(source, 'w', encoding="utf8") as f:
    61             f.write('''
    62-                #include <stdio.h>
    63+                #include <iostream>
    


    hebasto commented at 10:18 am on July 11, 2024:
    0                #include <cstdio>
    

    as suggested in #30387 (comment).

  20. in contrib/devtools/test-symbol-check.py:64 in dae34eb480 outdated
    63+                #include <iostream>
    64 
    65                 int main()
    66                 {
    67-                    printf("42");
    68+                    std::cout << 42 << std::endl;
    


    hebasto commented at 10:19 am on July 11, 2024:
    0                    std::printf("42");
    

    as suggested in #30387 (comment).

  21. theuni force-pushed on Jul 11, 2024
  22. DrahtBot added the label CI failed on Jul 11, 2024
  23. contrib: c++ify test stubs after switching to c++ compilers 9010b1343b
  24. in contrib/devtools/test-security-check.py:21 in dc4dfd2a8e outdated
    14@@ -15,10 +15,10 @@
    15 def write_testcode(filename):
    16     with open(filename, 'w', encoding="utf8") as f:
    17         f.write('''
    18-    #include <stdio.h>
    19+    #include <cstdio>
    20     int main()
    21     {
    22-        printf("the quick brown fox jumps over the lazy god\\n");
    23+        std::printf("the quick brown fox jumps over the lazy god\n");
    


    hebasto commented at 4:19 pm on July 11, 2024:
    0        std::printf("the quick brown fox jumps over the lazy god\\n");
    

    Otherwise, it fails:

     0test1.cpp:5:21: warning: missing terminating " character
     1    5 |         std::printf("the quick brown fox jumps over the lazy god
     2      |                     ^
     3test1.cpp:5:21: error: missing terminating " character
     4    5 |         std::printf("the quick brown fox jumps over the lazy god
     5      |                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     6test1.cpp:6:1: warning: missing terminating " character
     7    6 | ");
     8      | ^
     9test1.cpp:6:1: error: missing terminating " character
    10    6 | ");
    11      | ^~~
    12test1.cpp: In function 'int main()':
    13test1.cpp:7:9: error: expected primary-expression before 'return'
    14    7 |         return 0;
    15      |         ^~~~~~
    

    theuni commented at 5:27 pm on July 11, 2024:
    GRRRRR!!!
  25. theuni force-pushed on Jul 11, 2024
  26. fanquake added the label DrahtBot Guix build requested on Jul 11, 2024
  27. hebasto approved
  28. hebasto commented at 7:55 pm on July 11, 2024: member

    ACK 9010b1343b9f931f771d3d49dd03b57868c24d5d.

    My Guix build:

     0x86_64
     177365de6a5a0dd40d79f2c4ba8ac8f105c44348076ef64eb36c9ae030ce833f8  guix-build-9010b1343b9f/output/aarch64-linux-gnu/SHA256SUMS.part
     2af1b2f2cd45ce3b510903c674d68545e0ec0ad4cb5b7e65b7e6e8f17eabb4f4f  guix-build-9010b1343b9f/output/aarch64-linux-gnu/bitcoin-9010b1343b9f-aarch64-linux-gnu-debug.tar.gz
     3a88c00e179e1302a3ffd438c175b2f6331b58f0484757c1f843ca2d2a386fd59  guix-build-9010b1343b9f/output/aarch64-linux-gnu/bitcoin-9010b1343b9f-aarch64-linux-gnu.tar.gz
     4bf1763fd485bd84585d5793348abe8e7e9d0bed245d01fb8a3df1639d77a90ab  guix-build-9010b1343b9f/output/arm-linux-gnueabihf/SHA256SUMS.part
     5982aea1f79f9ba0ec39563bcd18d0cfff187eb1dd089b543da6ec208552c7b4f  guix-build-9010b1343b9f/output/arm-linux-gnueabihf/bitcoin-9010b1343b9f-arm-linux-gnueabihf-debug.tar.gz
     6b9b91132a3ae437a53840d96f0bd3a36986251600243638eab481aeb73acb78c  guix-build-9010b1343b9f/output/arm-linux-gnueabihf/bitcoin-9010b1343b9f-arm-linux-gnueabihf.tar.gz
     75971881d40d0357a67185f17a7416d98e2ffdcfea612991f06c83c02e8514828  guix-build-9010b1343b9f/output/arm64-apple-darwin/SHA256SUMS.part
     866c1e765885f3dac977208025b169a9f7a12cdb3b474bb87a7703c6a9bbb3cd7  guix-build-9010b1343b9f/output/arm64-apple-darwin/bitcoin-9010b1343b9f-arm64-apple-darwin-unsigned.tar.gz
     9fd5c497dc98eb38e13c37d67fb19845b8fdaed5e98503bbc62b89fc5ae4c080f  guix-build-9010b1343b9f/output/arm64-apple-darwin/bitcoin-9010b1343b9f-arm64-apple-darwin-unsigned.zip
    10c736677cdf4c164550b1dbac82de2fff8f85880a48ec75894a813b1dc46a2741  guix-build-9010b1343b9f/output/arm64-apple-darwin/bitcoin-9010b1343b9f-arm64-apple-darwin.tar.gz
    112242e3da93ca6baf06643127669cbba377b64b5de9073a1ce4be52e611f34cf4  guix-build-9010b1343b9f/output/dist-archive/bitcoin-9010b1343b9f.tar.gz
    1255b4104744d48f8d632fac313792e89aa75d89608632115b0214b6c0633482db  guix-build-9010b1343b9f/output/powerpc64-linux-gnu/SHA256SUMS.part
    139f9c3b89510974f08380113e6c30e644058e96650cd05e9f34935d54fdbcb405  guix-build-9010b1343b9f/output/powerpc64-linux-gnu/bitcoin-9010b1343b9f-powerpc64-linux-gnu-debug.tar.gz
    148f57a0489292c542cf20406c474f6d6f7c6c3cac27983722df6382534669e5a4  guix-build-9010b1343b9f/output/powerpc64-linux-gnu/bitcoin-9010b1343b9f-powerpc64-linux-gnu.tar.gz
    152c09aae42ba4b37cd146984eae1f7f6d7a6f37fe6b62568a2f6ec0f1e3b18c47  guix-build-9010b1343b9f/output/riscv64-linux-gnu/SHA256SUMS.part
    16a34b7bf6e240dada36ba031068bb8145142749659865f2394dcb018703e8cd0c  guix-build-9010b1343b9f/output/riscv64-linux-gnu/bitcoin-9010b1343b9f-riscv64-linux-gnu-debug.tar.gz
    17901f86eca2a038c0e1aae9b3a1ac21d49952604bfe7f49f5b1e4c3d52a1d8322  guix-build-9010b1343b9f/output/riscv64-linux-gnu/bitcoin-9010b1343b9f-riscv64-linux-gnu.tar.gz
    18c43c381562d7e3c4705d22ed759258c60e5cc2d18c317563669e4710e0c980e1  guix-build-9010b1343b9f/output/x86_64-apple-darwin/SHA256SUMS.part
    196da70cdabaa4d347c517a5bc73f68ca64487ea6d39a98400979f776acd089519  guix-build-9010b1343b9f/output/x86_64-apple-darwin/bitcoin-9010b1343b9f-x86_64-apple-darwin-unsigned.tar.gz
    206167d2e284305345abbd3d0bf78bb3c1e9a1e83592ddb0ba423a741d77067cbe  guix-build-9010b1343b9f/output/x86_64-apple-darwin/bitcoin-9010b1343b9f-x86_64-apple-darwin-unsigned.zip
    21af663e49542cdfb0b5f27cdd687e94744b8a1c5fee5ca9612afbfb5b4ef7713b  guix-build-9010b1343b9f/output/x86_64-apple-darwin/bitcoin-9010b1343b9f-x86_64-apple-darwin.tar.gz
    2293d2fe4810d4e85ec616927f9f9cb4da5dae3bd049c0e1b0a0f238c0defe47af  guix-build-9010b1343b9f/output/x86_64-linux-gnu/SHA256SUMS.part
    235a3acd323aaef9973578bd70eadef6c47999362f2437b4a17a74ccaa38f09479  guix-build-9010b1343b9f/output/x86_64-linux-gnu/bitcoin-9010b1343b9f-x86_64-linux-gnu-debug.tar.gz
    24e17960a39e6499265c47f4bdd098e5be287677c56cb0e98acfd432088055964e  guix-build-9010b1343b9f/output/x86_64-linux-gnu/bitcoin-9010b1343b9f-x86_64-linux-gnu.tar.gz
    252c96ce22a6ef5a4b3cde7ba594acc9247029602219ac5cafd39442f6e3a2493f  guix-build-9010b1343b9f/output/x86_64-w64-mingw32/SHA256SUMS.part
    265a1573063f333eef59ff6010a6c7618349899b920112f2d2d42a62f91cb0923a  guix-build-9010b1343b9f/output/x86_64-w64-mingw32/bitcoin-9010b1343b9f-win64-debug.zip
    27d61cbcf3152333caf54a2b168a3e94aa9a604cec81e53d8aeef7ee553977a92c  guix-build-9010b1343b9f/output/x86_64-w64-mingw32/bitcoin-9010b1343b9f-win64-setup-unsigned.exe
    289ff74a859b4ab8f758ccddeae032fc14402149c39cb32fd11d58ad7ea2bdeae0  guix-build-9010b1343b9f/output/x86_64-w64-mingw32/bitcoin-9010b1343b9f-win64-unsigned.tar.gz
    29b4525271b451180a7bf3e9954d8ddc79af98a36b69c534c8b35158bc7dce99b5  guix-build-9010b1343b9f/output/x86_64-w64-mingw32/bitcoin-9010b1343b9f-win64.zip
    
  29. DrahtBot requested review from fanquake on Jul 11, 2024
  30. DrahtBot commented at 4:58 am on July 12, 2024: contributor

    Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

    File commit 33af14e31b9fa436029a2bb8c2b11de8feb32f86(master) commit 81d9306cb6ccbcbcf5583e512bb1665cbafe05ae(master and this pull)
    SHA256SUMS.part d8e5b36649e40a4c... df788fcb86c4274c...
    *-aarch64-linux-gnu-debug.tar.gz 5a47f15b9408d7f4... 05e7f80e72b19299...
    *-aarch64-linux-gnu.tar.gz 41241ef7c8f4ed1b... 02816fac5725840e...
    *-arm-linux-gnueabihf-debug.tar.gz 51821eca108d3504... d8d2a81e0d7df001...
    *-arm-linux-gnueabihf.tar.gz ba65286caa7fdc0a... 5aa7d41a19c0602b...
    *-arm64-apple-darwin-unsigned.tar.gz 024035dab6cb8a97... 342d959e8eb84ffe...
    *-arm64-apple-darwin-unsigned.zip 16124af5c06e1c50... 1d5dc3981b6405e7...
    *-arm64-apple-darwin.tar.gz 1bf1df820984af09... e8e868bed7da8292...
    *-powerpc64-linux-gnu-debug.tar.gz 3d9ad6d234e0992a... 848431d8788a8911...
    *-powerpc64-linux-gnu.tar.gz d674464cfef17d7e... 8ead7849bd40dea9...
    *-riscv64-linux-gnu-debug.tar.gz a7b724f2f3e3b585... d39972da71861eb1...
    *-riscv64-linux-gnu.tar.gz 53fcfce9ca89f53b... 56f8f5b5f157e064...
    *-x86_64-apple-darwin-unsigned.tar.gz c38525b75b917ec4... 5956af410cae9f37...
    *-x86_64-apple-darwin-unsigned.zip e0a8f6b7b4ff43ed... 2f84fca3a7b268e2...
    *-x86_64-apple-darwin.tar.gz c54321f27f5db6cb... 708983f5d0b6450c...
    *-x86_64-linux-gnu-debug.tar.gz ba152c8170e75643... 2e6c608db9f696a4...
    *-x86_64-linux-gnu.tar.gz 67d87654a67da03d... 0933440158e10676...
    *.tar.gz 0c8407c13e7f0586... 581927276a91f882...
    guix_build.log 06e67ba18f4bb03d... 573d30013d954320...
    guix_build.log.diff 2e145ed8023a92e0...
  31. DrahtBot removed the label DrahtBot Guix build requested on Jul 12, 2024
  32. DrahtBot removed the label CI failed on Jul 12, 2024
  33. fanquake approved
  34. fanquake commented at 8:47 am on July 16, 2024: member

    ACK 9010b1343b9f931f771d3d49dd03b57868c24d5d

    Guix Build (aarch64):

     077365de6a5a0dd40d79f2c4ba8ac8f105c44348076ef64eb36c9ae030ce833f8  guix-build-9010b1343b9f/output/aarch64-linux-gnu/SHA256SUMS.part
     1af1b2f2cd45ce3b510903c674d68545e0ec0ad4cb5b7e65b7e6e8f17eabb4f4f  guix-build-9010b1343b9f/output/aarch64-linux-gnu/bitcoin-9010b1343b9f-aarch64-linux-gnu-debug.tar.gz
     2a88c00e179e1302a3ffd438c175b2f6331b58f0484757c1f843ca2d2a386fd59  guix-build-9010b1343b9f/output/aarch64-linux-gnu/bitcoin-9010b1343b9f-aarch64-linux-gnu.tar.gz
     3bf1763fd485bd84585d5793348abe8e7e9d0bed245d01fb8a3df1639d77a90ab  guix-build-9010b1343b9f/output/arm-linux-gnueabihf/SHA256SUMS.part
     4982aea1f79f9ba0ec39563bcd18d0cfff187eb1dd089b543da6ec208552c7b4f  guix-build-9010b1343b9f/output/arm-linux-gnueabihf/bitcoin-9010b1343b9f-arm-linux-gnueabihf-debug.tar.gz
     5b9b91132a3ae437a53840d96f0bd3a36986251600243638eab481aeb73acb78c  guix-build-9010b1343b9f/output/arm-linux-gnueabihf/bitcoin-9010b1343b9f-arm-linux-gnueabihf.tar.gz
     65971881d40d0357a67185f17a7416d98e2ffdcfea612991f06c83c02e8514828  guix-build-9010b1343b9f/output/arm64-apple-darwin/SHA256SUMS.part
     766c1e765885f3dac977208025b169a9f7a12cdb3b474bb87a7703c6a9bbb3cd7  guix-build-9010b1343b9f/output/arm64-apple-darwin/bitcoin-9010b1343b9f-arm64-apple-darwin-unsigned.tar.gz
     8fd5c497dc98eb38e13c37d67fb19845b8fdaed5e98503bbc62b89fc5ae4c080f  guix-build-9010b1343b9f/output/arm64-apple-darwin/bitcoin-9010b1343b9f-arm64-apple-darwin-unsigned.zip
     9c736677cdf4c164550b1dbac82de2fff8f85880a48ec75894a813b1dc46a2741  guix-build-9010b1343b9f/output/arm64-apple-darwin/bitcoin-9010b1343b9f-arm64-apple-darwin.tar.gz
    102242e3da93ca6baf06643127669cbba377b64b5de9073a1ce4be52e611f34cf4  guix-build-9010b1343b9f/output/dist-archive/bitcoin-9010b1343b9f.tar.gz
    1155b4104744d48f8d632fac313792e89aa75d89608632115b0214b6c0633482db  guix-build-9010b1343b9f/output/powerpc64-linux-gnu/SHA256SUMS.part
    129f9c3b89510974f08380113e6c30e644058e96650cd05e9f34935d54fdbcb405  guix-build-9010b1343b9f/output/powerpc64-linux-gnu/bitcoin-9010b1343b9f-powerpc64-linux-gnu-debug.tar.gz
    138f57a0489292c542cf20406c474f6d6f7c6c3cac27983722df6382534669e5a4  guix-build-9010b1343b9f/output/powerpc64-linux-gnu/bitcoin-9010b1343b9f-powerpc64-linux-gnu.tar.gz
    142c09aae42ba4b37cd146984eae1f7f6d7a6f37fe6b62568a2f6ec0f1e3b18c47  guix-build-9010b1343b9f/output/riscv64-linux-gnu/SHA256SUMS.part
    15a34b7bf6e240dada36ba031068bb8145142749659865f2394dcb018703e8cd0c  guix-build-9010b1343b9f/output/riscv64-linux-gnu/bitcoin-9010b1343b9f-riscv64-linux-gnu-debug.tar.gz
    16901f86eca2a038c0e1aae9b3a1ac21d49952604bfe7f49f5b1e4c3d52a1d8322  guix-build-9010b1343b9f/output/riscv64-linux-gnu/bitcoin-9010b1343b9f-riscv64-linux-gnu.tar.gz
    17c43c381562d7e3c4705d22ed759258c60e5cc2d18c317563669e4710e0c980e1  guix-build-9010b1343b9f/output/x86_64-apple-darwin/SHA256SUMS.part
    186da70cdabaa4d347c517a5bc73f68ca64487ea6d39a98400979f776acd089519  guix-build-9010b1343b9f/output/x86_64-apple-darwin/bitcoin-9010b1343b9f-x86_64-apple-darwin-unsigned.tar.gz
    196167d2e284305345abbd3d0bf78bb3c1e9a1e83592ddb0ba423a741d77067cbe  guix-build-9010b1343b9f/output/x86_64-apple-darwin/bitcoin-9010b1343b9f-x86_64-apple-darwin-unsigned.zip
    20af663e49542cdfb0b5f27cdd687e94744b8a1c5fee5ca9612afbfb5b4ef7713b  guix-build-9010b1343b9f/output/x86_64-apple-darwin/bitcoin-9010b1343b9f-x86_64-apple-darwin.tar.gz
    2193d2fe4810d4e85ec616927f9f9cb4da5dae3bd049c0e1b0a0f238c0defe47af  guix-build-9010b1343b9f/output/x86_64-linux-gnu/SHA256SUMS.part
    225a3acd323aaef9973578bd70eadef6c47999362f2437b4a17a74ccaa38f09479  guix-build-9010b1343b9f/output/x86_64-linux-gnu/bitcoin-9010b1343b9f-x86_64-linux-gnu-debug.tar.gz
    23e17960a39e6499265c47f4bdd098e5be287677c56cb0e98acfd432088055964e  guix-build-9010b1343b9f/output/x86_64-linux-gnu/bitcoin-9010b1343b9f-x86_64-linux-gnu.tar.gz
    242c96ce22a6ef5a4b3cde7ba594acc9247029602219ac5cafd39442f6e3a2493f  guix-build-9010b1343b9f/output/x86_64-w64-mingw32/SHA256SUMS.part
    255a1573063f333eef59ff6010a6c7618349899b920112f2d2d42a62f91cb0923a  guix-build-9010b1343b9f/output/x86_64-w64-mingw32/bitcoin-9010b1343b9f-win64-debug.zip
    26d61cbcf3152333caf54a2b168a3e94aa9a604cec81e53d8aeef7ee553977a92c  guix-build-9010b1343b9f/output/x86_64-w64-mingw32/bitcoin-9010b1343b9f-win64-setup-unsigned.exe
    279ff74a859b4ab8f758ccddeae032fc14402149c39cb32fd11d58ad7ea2bdeae0  guix-build-9010b1343b9f/output/x86_64-w64-mingw32/bitcoin-9010b1343b9f-win64-unsigned.tar.gz
    28b4525271b451180a7bf3e9954d8ddc79af98a36b69c534c8b35158bc7dce99b5  guix-build-9010b1343b9f/output/x86_64-w64-mingw32/bitcoin-9010b1343b9f-win64.zip
    
  35. fanquake merged this on Jul 16, 2024
  36. fanquake closed this on Jul 16, 2024


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-09-29 01:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me