refactor: use existing RNG object in ProcessGetBlockData #30393

1. 
   maflcko commented at 12:07 pm on July 4, 2024: member

   Small follow-up to commit 8e31cf9c9b5e9fdd01e8b220c08a3ccde5cf584c
2. 
   DrahtBot commented at 12:07 pm on July 4, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	dergoegge, glozow

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #30385 ([WIP] p2p: send not_found msgs for unknown, pruned or unwilling to share blocks by furszy)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

3. DrahtBot renamed this:
   net_processing: use existing RNG object in ProcessGetBlockData
   net_processing: use existing RNG object in ProcessGetBlockData
   on Jul 4, 2024
4. maflcko renamed this:
   net_processing: use existing RNG object in ProcessGetBlockData
   refactor: use existing RNG object in ProcessGetBlockData
   on Jul 4, 2024
5. DrahtBot added the label Refactoring on Jul 4, 2024
6. dergoegge approved
7. 
   dergoegge commented at 1:16 pm on July 4, 2024: member

   utACK fa01c2af9eb91aebcdb87947145ba34b519bdfd8

   There was some discussion on #29625 about reverting #28558 but this lgtm for now.

8. 
   maflcko commented at 1:41 pm on July 4, 2024: member

   There was some discussion on #29625 about reverting #28558 but this lgtm for now.

   Happy to drop it, if the reason still applies, but I couldn’t find one.

9. 
   sipa commented at 2:54 pm on July 5, 2024: member

   It appears we can drop Shuffle entirely: https://github.com/bitcoin/bitcoin/pull/30396
10. maflcko marked this as a draft on Jul 5, 2024
11. maflcko marked this as ready for review on Jul 5, 2024
12. net_processing: use existing RNG object in ProcessGetBlockData

    Minor follow-up to 8e31cf9c9b5e9fdd01e8b220c08a3ccde5cf584c, which did
    the same.

    fa2e74879a
13. maflcko force-pushed on Jul 5, 2024
14. 
    maflcko commented at 3:00 pm on July 5, 2024: member

    Nice. Dropped that commit here.
15. dergoegge approved
16. 
    dergoegge commented at 9:57 am on July 9, 2024: member

    Code review ACK fa2e74879a3f7423c8d01aa1376b2bd9ccf5658d
17. 
    glozow commented at 1:27 pm on July 9, 2024: member

    ACK fa2e74879a3f7423c8d01aa1376b2bd9ccf5658d
18. glozow merged this on Jul 9, 2024
19. glozow closed this on Jul 9, 2024

    ---

20. maflcko deleted the branch on Jul 9, 2024

Contributors
maflcko DrahtBot dergoegge sipa glozow

Labels
Refactoring