refactor: Use designated initializer in test/util/net.cpp #30397

pull hodlinator wants to merge 1 commits into bitcoin:master from hodlinator:2024-07_net_designated_initializer changing 1 files +14 −14
  1. hodlinator commented at 8:11 pm on July 5, 2024: contributor

    Block was recently touched (e2d1f84858485650ff743753ffa5c679f210a992) and the codebase recently switched to C++20 which allows this to improve robustness.

    Follow-up suggested in #29625 (review)

  2. refactor: Use designated initializer
    Block was recently touched (e2d1f84858485650ff743753ffa5c679f210a992) and the codebase recently switched to C++20 which allows this to improve robustness.
    e233ec036d
  3. DrahtBot commented at 8:11 pm on July 5, 2024: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage

    For detailed information about the code coverage, see the test coverage report.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK maflcko

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. DrahtBot added the label Refactoring on Jul 5, 2024
  5. maflcko commented at 7:42 am on July 8, 2024: member

    ACK e233ec036dc972a5847ab769ad22d418fd9404d1

    Previously clang-tidy couldn’t understand the named args, because of list-initialization. (Even if it did, catching them right in the any C++ compiler is always better than only in clang-tidy)

  6. fanquake merged this on Jul 11, 2024
  7. fanquake closed this on Jul 11, 2024

  8. hodlinator deleted the branch on Jul 12, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-21 12:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me