Block was recently touched (e2d1f84858485650ff743753ffa5c679f210a992) and the codebase recently switched to C++20 which allows this to improve robustness.
Follow-up suggested in #29625 (review)
refactor: Use designated initializer in test/util/net.cpp #30397
pull hodlinator wants to merge 1 commits into bitcoin:master from hodlinator:2024-07_net_designated_initializer changing 1 files +14 −14-
hodlinator commented at 8:11 PM on July 5, 2024: contributor
-
e233ec036d
refactor: Use designated initializer
Block was recently touched (e2d1f84858485650ff743753ffa5c679f210a992) and the codebase recently switched to C++20 which allows this to improve robustness.
-
DrahtBot commented at 8:11 PM on July 5, 2024: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage
For detailed information about the code coverage, see the test coverage report.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK maflcko If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
- DrahtBot added the label Refactoring on Jul 5, 2024
-
maflcko commented at 7:42 AM on July 8, 2024: member
ACK e233ec036dc972a5847ab769ad22d418fd9404d1
Previously clang-tidy couldn't understand the named args, because of list-initialization. (Even if it did, catching them right in the any C++ compiler is always better than only in clang-tidy)
- fanquake merged this on Jul 11, 2024
- fanquake closed this on Jul 11, 2024
- hodlinator deleted the branch on Jul 12, 2024
- bitcoin locked this on Jul 12, 2025
Contributors
Labels