remove truc_policy from libbitcoin_common_a_SOURCES #30427

pull glozow wants to merge 1 commits into bitcoin:master from glozow:2024-07-truc-common changing 1 files +0 −1

glozow commented at 10:57 AM on July 11, 2024: member

Hebasto pointed out that it doesn't need to be there since it's in libbitcoin_node_a_SOURCES

remove truc_policy.cpp from libbitcoin_common_a_SOURCES

It doesn't need it

Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>

e8c3b7172c

DrahtBot commented at 10:57 AM on July 11, 2024: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Code Coverage

For detailed information about the code coverage, see the test coverage report.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK hebasto, ismaelsadeeq, maflcko

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
maflcko commented at 11:21 AM on July 11, 2024: member

In theory libbitcoin_wallet may want to use it at some point? Though, I guess it can be moved back then, if needed.
hebasto commented at 11:25 AM on July 11, 2024: member

In theory libbitcoin_wallet may want to use it at some point? Though, I guess it can be moved back then, if needed.

If/when it happens, the policy/truc_policy.cpp source file can be moved from libbitcoin_node.a to the libbitcoin_common.a static library sources.
hebasto approved
hebasto commented at 11:27 AM on July 11, 2024: member

ACK e8c3b7172c33929e4e5bf6059da2d25a4ea8779c, this change follows the design docs.
ismaelsadeeq commented at 12:50 PM on July 11, 2024: member

ACK e8c3b7172c33929e4e5bf6059da2d25a4ea8779c
maflcko commented at 3:03 PM on July 11, 2024: member

ACK e8c3b7172c33929e4e5bf6059da2d25a4ea8779c
fanquake merged this on Jul 11, 2024
fanquake closed this on Jul 11, 2024
hebasto added the label Needs CMake port on Jul 11, 2024
glozow deleted the branch on Jul 12, 2024
hebasto commented at 6:58 AM on July 14, 2024: member

Ported to the CMake-based build system in https://github.com/hebasto/bitcoin/pull/264.
hebasto removed the label Needs CMake port on Jul 14, 2024
hebasto added the label Build system on Jul 14, 2024
bitcoin locked this on Jul 14, 2025

Type	Reviewers
ACK	hebasto, ismaelsadeeq, maflcko

Contributors

Labels

remove truc_policy from libbitcoin_common_a_SOURCES #30427

Code Coverage

Reviews