build: add `standard branch-protection` to hardening flags for aarch64-linux

fanquake commented at 4:51 pm on July 11, 2024: member

Use -mbranch-protection=standard when targetting *aarch64-*-linux*. Part of #24123, but this flag can already be used on a best effort basis.

Note that this flag is also already used by default, in the toolchain, on various distros (i.e Fedora).

DrahtBot commented at 4:51 pm on July 11, 2024: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	hebasto, TheCharlatan

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

No conflicts as of last run.

DrahtBot added the label Build system on Jul 11, 2024

fanquake added the label DrahtBot Guix build requested on Jul 11, 2024

in configure.ac:866 in 704cdca082 outdated

860@@ -861,7 +861,11 @@ if test "$use_hardening" != "no"; then
861   esac
862 
863   case $host in
864-    *aarch64*)
865+    *aarch64-*-linux*)
866+      AX_CHECK_COMPILE_FLAG([-mbranch-protection=standard], [HARDENED_CXXFLAGS="$HARDENED_CXXFLAGS -mbranch-protection=standard"])

luke-jr commented at 8:15 pm on July 11, 2024:

Will this override the user if he sets a stronger mode?

fanquake commented at 10:40 am on August 23, 2024:

The same logic as all other flags applies, the user has the final say.

in configure.ac:866 in 704cdca082 outdated

860@@ -861,7 +861,11 @@ if test "$use_hardening" != "no"; then
861   esac
862 
863   case $host in
864-    *aarch64*)
865+    *aarch64-*-linux*)
866+      AX_CHECK_COMPILE_FLAG([-mbranch-protection=standard], [HARDENED_CXXFLAGS="$HARDENED_CXXFLAGS -mbranch-protection=standard"])
867+      AX_CHECK_LINK_FLAG([-Wl,-z,pac-plt], [HARDENED_LDFLAGS="$HARDENED_LDFLAGS -Wl,-z,pac-plt"], [], [$LDFLAG_WERROR])

luke-jr commented at 8:18 pm on July 11, 2024:

Could this be an issue?

https://sourceware.org/bugzilla/show_bug.cgi?id=26312

fanquake commented at 10:40 am on August 23, 2024:

I’ll take a look, and we can backport something if relevant.

DrahtBot commented at 1:54 am on July 12, 2024: contributor

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

File	commit 33af14e31b9fa436029a2bb8c2b11de8feb32f86(master)	commit 5b0ad00b0e00cbed57a54eec25bc28086d7d1b9f(master and this pull)
SHA256SUMS.part	`d8e5b36649e40a4c...`	`e2c10e0dc37f16a8...`
*-aarch64-linux-gnu-debug.tar.gz	`5a47f15b9408d7f4...`	`ac74e0b681e3e712...`
*-aarch64-linux-gnu.tar.gz	`41241ef7c8f4ed1b...`	`a4a5c424d19f98c4...`
*-arm-linux-gnueabihf-debug.tar.gz	`51821eca108d3504...`	`3985c71e7c08b1e6...`
*-arm-linux-gnueabihf.tar.gz	`ba65286caa7fdc0a...`	`9551e6f4fb197252...`
*-arm64-apple-darwin-unsigned.tar.gz	`024035dab6cb8a97...`	`a4692aad48846d25...`
*-arm64-apple-darwin-unsigned.zip	`16124af5c06e1c50...`	`9fbbbcd7c20a2ebd...`
*-arm64-apple-darwin.tar.gz	`1bf1df820984af09...`	`ce490fe2fd8fcc8e...`
*-powerpc64-linux-gnu-debug.tar.gz	`3d9ad6d234e0992a...`	`737560621fcdd722...`
*-powerpc64-linux-gnu.tar.gz	`d674464cfef17d7e...`	`2bea369eef61b051...`
*-riscv64-linux-gnu-debug.tar.gz	`a7b724f2f3e3b585...`	`c94c3afb86f2cfb5...`
*-riscv64-linux-gnu.tar.gz	`53fcfce9ca89f53b...`	`70b84682f4f606fc...`
*-x86_64-apple-darwin-unsigned.tar.gz	`c38525b75b917ec4...`	`3fe71ec84520b4dc...`
*-x86_64-apple-darwin-unsigned.zip	`e0a8f6b7b4ff43ed...`	`340f0ab35e54a613...`
*-x86_64-apple-darwin.tar.gz	`c54321f27f5db6cb...`	`3394440bdca56fba...`
*-x86_64-linux-gnu-debug.tar.gz	`ba152c8170e75643...`	`5a915822ae0e675e...`
*-x86_64-linux-gnu.tar.gz	`67d87654a67da03d...`	`be1fc9db45b1e4a2...`
*.tar.gz	`0c8407c13e7f0586...`	`cb8fe7cb61629751...`
guix_build.log	`06e67ba18f4bb03d...`	`4503b44d15edd9cc...`
guix_build.log.diff		`ae7519d70284d423...`

DrahtBot removed the label DrahtBot Guix build requested on Jul 12, 2024

hebasto added the label Needs CMake port on Aug 16, 2024

fanquake force-pushed on Aug 23, 2024

hebasto approved

hebasto commented at 3:01 pm on August 27, 2024: member

ACK 03171002e5de04953ecd220cce40313f42315fcb. Tested in both cross and native build scenarios.

fanquake force-pushed on Aug 28, 2024

fanquake removed the label Needs CMake port on Aug 28, 2024

fanquake force-pushed on Aug 30, 2024

fanquake force-pushed on Sep 10, 2024

DrahtBot added the label CI failed on Sep 10, 2024

fanquake force-pushed on Sep 12, 2024

fanquake force-pushed on Sep 13, 2024

fanquake requested review from hebasto on Sep 13, 2024

fanquake added the label DrahtBot Guix build requested on Sep 13, 2024

TheCharlatan approved

TheCharlatan commented at 9:25 am on September 13, 2024: contributor

ACK 0bb8cdbe8cf1d634fb6555913dc9b498c95aeee1

master:

0/usr/bin/aarch64-linux-gnu-readelf --notes build/src/CMakeFiles/bitcoind.dir/init/bitcoind.cpp.o
1
2Displaying notes found in: .note.gnu.property
3  Owner                Data size 	Description
4  GNU                  0x00000010	NT_GNU_PROPERTY_TYPE_0
5      Properties: AArch64 feature: BTI

This PR:

0/usr/bin/aarch64-linux-gnu-readelf --notes build_b/src/CMakeFiles/bitcoind.dir/init/bitcoind.cpp.o
1
2Displaying notes found in: .note.gnu.property
3  Owner                Data size 	Description
4  GNU                  0x00000010	NT_GNU_PROPERTY_TYPE_0
5      Properties: AArch64 feature: BTI, PAC

fanquake force-pushed on Sep 13, 2024

build: use standard branch-protection for aarch64-linux 001b1cf010

fanquake force-pushed on Sep 13, 2024

fanquake commented at 10:28 am on September 13, 2024: member

Sorry, fixed the buggy previous version.

fanquake commented at 11:54 am on September 13, 2024: member

Guix Build:

 086d20fcaf2331084035fba29305dbcd22665a7a0f910ffbe1667541a338129ed  guix-build-001b1cf01045/output/aarch64-linux-gnu/SHA256SUMS.part
 106ec1b29ed2ac24733fa24083460298e4c9a2cbba8845164f849aebb50c94e91  guix-build-001b1cf01045/output/aarch64-linux-gnu/bitcoin-001b1cf01045-aarch64-linux-gnu-debug.tar.gz
 216b21d25dab9222dc69774e0e788c10bac4f15783c4ccb46c11e0608d132021d  guix-build-001b1cf01045/output/aarch64-linux-gnu/bitcoin-001b1cf01045-aarch64-linux-gnu.tar.gz
 33cdd10a2eb9e0bdba787fbb4c7ae63f74b3d238fbfed9a94a11fc3be90fafb4f  guix-build-001b1cf01045/output/arm-linux-gnueabihf/SHA256SUMS.part
 43b2dc9c09e761dc75f6ae15bb8cd5fcdc4e056600e68e0c452db619a933eb24f  guix-build-001b1cf01045/output/arm-linux-gnueabihf/bitcoin-001b1cf01045-arm-linux-gnueabihf-debug.tar.gz
 56bb830a6bcb831cbb2ccfb68bd70c691d73661561cc4f60b224dc8d946b9bd73  guix-build-001b1cf01045/output/arm-linux-gnueabihf/bitcoin-001b1cf01045-arm-linux-gnueabihf.tar.gz
 63715ca06ff1771bc35e1e4265ce939ad25c731fd94ee4266248e6658450898c3  guix-build-001b1cf01045/output/arm64-apple-darwin/SHA256SUMS.part
 73f78d59c99461020ee190ad8665d9b595df3cb42c895a615887bf0a8fb4cb112  guix-build-001b1cf01045/output/arm64-apple-darwin/bitcoin-001b1cf01045-arm64-apple-darwin-unsigned.tar.gz
 8ba816c0fdb632391b1528d4cb858da12a43c0a061b5aaacd077fd2901963df53  guix-build-001b1cf01045/output/arm64-apple-darwin/bitcoin-001b1cf01045-arm64-apple-darwin-unsigned.zip
 93d5312341c52b4f076341102aeb46d20ece44d49a14985314d63fc2787e04d15  guix-build-001b1cf01045/output/arm64-apple-darwin/bitcoin-001b1cf01045-arm64-apple-darwin.tar.gz
10b704319015b4e670ed1e4add637d80c6d1d9cac3d8363d6f36e8e3daa157589d  guix-build-001b1cf01045/output/dist-archive/bitcoin-001b1cf01045.tar.gz
11faf0f14db65a8f40afe12e6382b04d7b59d5fa6c247bb972a8624cf9c92a02eb  guix-build-001b1cf01045/output/powerpc64-linux-gnu/SHA256SUMS.part
121070564b98617051a4bf1327e1d81f610ac6edf67223e803843d3e2360f40e70  guix-build-001b1cf01045/output/powerpc64-linux-gnu/bitcoin-001b1cf01045-powerpc64-linux-gnu-debug.tar.gz
139b3264c70a26c1895b7ae123d361f90935fb467b822e4a5580bdcade07f9a288  guix-build-001b1cf01045/output/powerpc64-linux-gnu/bitcoin-001b1cf01045-powerpc64-linux-gnu.tar.gz
142d1fbdc38c66a05d58c05f3391760655326e8b656dfe490627bcceaa6e29d7c1  guix-build-001b1cf01045/output/riscv64-linux-gnu/SHA256SUMS.part
156b20bedd0116c6790e9edf349a914f50efe444e4e6edcc0c46c48706b66217ae  guix-build-001b1cf01045/output/riscv64-linux-gnu/bitcoin-001b1cf01045-riscv64-linux-gnu-debug.tar.gz
16490579ecf6b8a7b6d6a276d511186b7f8d762a31fae25f39d0a513928b3ae8fe  guix-build-001b1cf01045/output/riscv64-linux-gnu/bitcoin-001b1cf01045-riscv64-linux-gnu.tar.gz
177941addc7669097a27d8208673c558fb269c86fa7f78d2e53c0a0cc17df47a8a  guix-build-001b1cf01045/output/x86_64-apple-darwin/SHA256SUMS.part
1895b260680fdcda7674e85e29017e98671236fc00d65436a67b109fdc9bf7183d  guix-build-001b1cf01045/output/x86_64-apple-darwin/bitcoin-001b1cf01045-x86_64-apple-darwin-unsigned.tar.gz
190c7b959445ce1b30a509502fae56faeac03349c497ccc9aa2e24c9a1e26c5562  guix-build-001b1cf01045/output/x86_64-apple-darwin/bitcoin-001b1cf01045-x86_64-apple-darwin-unsigned.zip
2051ae91ae7d1eefcc3260b2bb2876ec2c0c75bc4b9bb81e9b89f0fdabce72af28  guix-build-001b1cf01045/output/x86_64-apple-darwin/bitcoin-001b1cf01045-x86_64-apple-darwin.tar.gz
21ed5773a890bf66366c5dd891e103d01964dca5ecede308c8da1dad8b69a0c369  guix-build-001b1cf01045/output/x86_64-linux-gnu/SHA256SUMS.part
224dca5d09d5781e92658713f5275cef98463a2cd1dd944c735e633369a692b03d  guix-build-001b1cf01045/output/x86_64-linux-gnu/bitcoin-001b1cf01045-x86_64-linux-gnu-debug.tar.gz
23d4865bfa860a0dd3668e65b4190560cede30eb1e6ba1a67b80a7da33f8b513f5  guix-build-001b1cf01045/output/x86_64-linux-gnu/bitcoin-001b1cf01045-x86_64-linux-gnu.tar.gz
2414ec6517c4f19145285d637745dd21e57277375427633b3007b8fe81de6a9f80  guix-build-001b1cf01045/output/x86_64-w64-mingw32/SHA256SUMS.part
250030ab8c50b1c3465305464efb251bf81b880a522b4f76f6dc6cff5b0265bf87  guix-build-001b1cf01045/output/x86_64-w64-mingw32/bitcoin-001b1cf01045-win64-debug.zip
2696f7e3905b9be0231db1bb6f6d9ae005abbab767c57be328ef6ce42915df6068  guix-build-001b1cf01045/output/x86_64-w64-mingw32/bitcoin-001b1cf01045-win64-setup-unsigned.exe
27484f54d512af952d7f207e85f2973429edd72e7025e07b006d568dd9f63825d7  guix-build-001b1cf01045/output/x86_64-w64-mingw32/bitcoin-001b1cf01045-win64-unsigned.tar.gz
288389a9f5915e4720b6a994f2b2447f2863b581400ef3724a6f94a99ab5e22d88  guix-build-001b1cf01045/output/x86_64-w64-mingw32/bitcoin-001b1cf01045-win64.zip

hebasto commented at 12:03 pm on September 13, 2024: member

My Guix build:

 0aarch64
 186d20fcaf2331084035fba29305dbcd22665a7a0f910ffbe1667541a338129ed  guix-build-001b1cf01045/output/aarch64-linux-gnu/SHA256SUMS.part
 206ec1b29ed2ac24733fa24083460298e4c9a2cbba8845164f849aebb50c94e91  guix-build-001b1cf01045/output/aarch64-linux-gnu/bitcoin-001b1cf01045-aarch64-linux-gnu-debug.tar.gz
 316b21d25dab9222dc69774e0e788c10bac4f15783c4ccb46c11e0608d132021d  guix-build-001b1cf01045/output/aarch64-linux-gnu/bitcoin-001b1cf01045-aarch64-linux-gnu.tar.gz
 43cdd10a2eb9e0bdba787fbb4c7ae63f74b3d238fbfed9a94a11fc3be90fafb4f  guix-build-001b1cf01045/output/arm-linux-gnueabihf/SHA256SUMS.part
 53b2dc9c09e761dc75f6ae15bb8cd5fcdc4e056600e68e0c452db619a933eb24f  guix-build-001b1cf01045/output/arm-linux-gnueabihf/bitcoin-001b1cf01045-arm-linux-gnueabihf-debug.tar.gz
 66bb830a6bcb831cbb2ccfb68bd70c691d73661561cc4f60b224dc8d946b9bd73  guix-build-001b1cf01045/output/arm-linux-gnueabihf/bitcoin-001b1cf01045-arm-linux-gnueabihf.tar.gz
 73715ca06ff1771bc35e1e4265ce939ad25c731fd94ee4266248e6658450898c3  guix-build-001b1cf01045/output/arm64-apple-darwin/SHA256SUMS.part
 83f78d59c99461020ee190ad8665d9b595df3cb42c895a615887bf0a8fb4cb112  guix-build-001b1cf01045/output/arm64-apple-darwin/bitcoin-001b1cf01045-arm64-apple-darwin-unsigned.tar.gz
 9ba816c0fdb632391b1528d4cb858da12a43c0a061b5aaacd077fd2901963df53  guix-build-001b1cf01045/output/arm64-apple-darwin/bitcoin-001b1cf01045-arm64-apple-darwin-unsigned.zip
103d5312341c52b4f076341102aeb46d20ece44d49a14985314d63fc2787e04d15  guix-build-001b1cf01045/output/arm64-apple-darwin/bitcoin-001b1cf01045-arm64-apple-darwin.tar.gz
11b704319015b4e670ed1e4add637d80c6d1d9cac3d8363d6f36e8e3daa157589d  guix-build-001b1cf01045/output/dist-archive/bitcoin-001b1cf01045.tar.gz
12faf0f14db65a8f40afe12e6382b04d7b59d5fa6c247bb972a8624cf9c92a02eb  guix-build-001b1cf01045/output/powerpc64-linux-gnu/SHA256SUMS.part
131070564b98617051a4bf1327e1d81f610ac6edf67223e803843d3e2360f40e70  guix-build-001b1cf01045/output/powerpc64-linux-gnu/bitcoin-001b1cf01045-powerpc64-linux-gnu-debug.tar.gz
149b3264c70a26c1895b7ae123d361f90935fb467b822e4a5580bdcade07f9a288  guix-build-001b1cf01045/output/powerpc64-linux-gnu/bitcoin-001b1cf01045-powerpc64-linux-gnu.tar.gz
152d1fbdc38c66a05d58c05f3391760655326e8b656dfe490627bcceaa6e29d7c1  guix-build-001b1cf01045/output/riscv64-linux-gnu/SHA256SUMS.part
166b20bedd0116c6790e9edf349a914f50efe444e4e6edcc0c46c48706b66217ae  guix-build-001b1cf01045/output/riscv64-linux-gnu/bitcoin-001b1cf01045-riscv64-linux-gnu-debug.tar.gz
17490579ecf6b8a7b6d6a276d511186b7f8d762a31fae25f39d0a513928b3ae8fe  guix-build-001b1cf01045/output/riscv64-linux-gnu/bitcoin-001b1cf01045-riscv64-linux-gnu.tar.gz
187941addc7669097a27d8208673c558fb269c86fa7f78d2e53c0a0cc17df47a8a  guix-build-001b1cf01045/output/x86_64-apple-darwin/SHA256SUMS.part
1995b260680fdcda7674e85e29017e98671236fc00d65436a67b109fdc9bf7183d  guix-build-001b1cf01045/output/x86_64-apple-darwin/bitcoin-001b1cf01045-x86_64-apple-darwin-unsigned.tar.gz
200c7b959445ce1b30a509502fae56faeac03349c497ccc9aa2e24c9a1e26c5562  guix-build-001b1cf01045/output/x86_64-apple-darwin/bitcoin-001b1cf01045-x86_64-apple-darwin-unsigned.zip
2151ae91ae7d1eefcc3260b2bb2876ec2c0c75bc4b9bb81e9b89f0fdabce72af28  guix-build-001b1cf01045/output/x86_64-apple-darwin/bitcoin-001b1cf01045-x86_64-apple-darwin.tar.gz
22ed5773a890bf66366c5dd891e103d01964dca5ecede308c8da1dad8b69a0c369  guix-build-001b1cf01045/output/x86_64-linux-gnu/SHA256SUMS.part
234dca5d09d5781e92658713f5275cef98463a2cd1dd944c735e633369a692b03d  guix-build-001b1cf01045/output/x86_64-linux-gnu/bitcoin-001b1cf01045-x86_64-linux-gnu-debug.tar.gz
24d4865bfa860a0dd3668e65b4190560cede30eb1e6ba1a67b80a7da33f8b513f5  guix-build-001b1cf01045/output/x86_64-linux-gnu/bitcoin-001b1cf01045-x86_64-linux-gnu.tar.gz
2514ec6517c4f19145285d637745dd21e57277375427633b3007b8fe81de6a9f80  guix-build-001b1cf01045/output/x86_64-w64-mingw32/SHA256SUMS.part
260030ab8c50b1c3465305464efb251bf81b880a522b4f76f6dc6cff5b0265bf87  guix-build-001b1cf01045/output/x86_64-w64-mingw32/bitcoin-001b1cf01045-win64-debug.zip
2796f7e3905b9be0231db1bb6f6d9ae005abbab767c57be328ef6ce42915df6068  guix-build-001b1cf01045/output/x86_64-w64-mingw32/bitcoin-001b1cf01045-win64-setup-unsigned.exe
28484f54d512af952d7f207e85f2973429edd72e7025e07b006d568dd9f63825d7  guix-build-001b1cf01045/output/x86_64-w64-mingw32/bitcoin-001b1cf01045-win64-unsigned.tar.gz
298389a9f5915e4720b6a994f2b2447f2863b581400ef3724a6f94a99ab5e22d88  guix-build-001b1cf01045/output/x86_64-w64-mingw32/bitcoin-001b1cf01045-win64.zip

hebasto approved

hebasto commented at 12:31 pm on September 13, 2024: member

ACK 001b1cf010453adbb1316a6fa8911398953afe61.

DrahtBot requested review from TheCharlatan on Sep 13, 2024

TheCharlatan commented at 2:03 pm on September 13, 2024: contributor

Guix build (aarch64):

 086d20fcaf2331084035fba29305dbcd22665a7a0f910ffbe1667541a338129ed  guix-build-001b1cf01045/output/aarch64-linux-gnu/SHA256SUMS.part
 106ec1b29ed2ac24733fa24083460298e4c9a2cbba8845164f849aebb50c94e91  guix-build-001b1cf01045/output/aarch64-linux-gnu/bitcoin-001b1cf01045-aarch64-linux-gnu-debug.tar.gz
 216b21d25dab9222dc69774e0e788c10bac4f15783c4ccb46c11e0608d132021d  guix-build-001b1cf01045/output/aarch64-linux-gnu/bitcoin-001b1cf01045-aarch64-linux-gnu.tar.gz
 33cdd10a2eb9e0bdba787fbb4c7ae63f74b3d238fbfed9a94a11fc3be90fafb4f  guix-build-001b1cf01045/output/arm-linux-gnueabihf/SHA256SUMS.part
 43b2dc9c09e761dc75f6ae15bb8cd5fcdc4e056600e68e0c452db619a933eb24f  guix-build-001b1cf01045/output/arm-linux-gnueabihf/bitcoin-001b1cf01045-arm-linux-gnueabihf-debug.tar.gz
 56bb830a6bcb831cbb2ccfb68bd70c691d73661561cc4f60b224dc8d946b9bd73  guix-build-001b1cf01045/output/arm-linux-gnueabihf/bitcoin-001b1cf01045-arm-linux-gnueabihf.tar.gz
 63715ca06ff1771bc35e1e4265ce939ad25c731fd94ee4266248e6658450898c3  guix-build-001b1cf01045/output/arm64-apple-darwin/SHA256SUMS.part
 73f78d59c99461020ee190ad8665d9b595df3cb42c895a615887bf0a8fb4cb112  guix-build-001b1cf01045/output/arm64-apple-darwin/bitcoin-001b1cf01045-arm64-apple-darwin-unsigned.tar.gz
 8ba816c0fdb632391b1528d4cb858da12a43c0a061b5aaacd077fd2901963df53  guix-build-001b1cf01045/output/arm64-apple-darwin/bitcoin-001b1cf01045-arm64-apple-darwin-unsigned.zip
 93d5312341c52b4f076341102aeb46d20ece44d49a14985314d63fc2787e04d15  guix-build-001b1cf01045/output/arm64-apple-darwin/bitcoin-001b1cf01045-arm64-apple-darwin.tar.gz
10b704319015b4e670ed1e4add637d80c6d1d9cac3d8363d6f36e8e3daa157589d  guix-build-001b1cf01045/output/dist-archive/bitcoin-001b1cf01045.tar.gz
11faf0f14db65a8f40afe12e6382b04d7b59d5fa6c247bb972a8624cf9c92a02eb  guix-build-001b1cf01045/output/powerpc64-linux-gnu/SHA256SUMS.part
121070564b98617051a4bf1327e1d81f610ac6edf67223e803843d3e2360f40e70  guix-build-001b1cf01045/output/powerpc64-linux-gnu/bitcoin-001b1cf01045-powerpc64-linux-gnu-debug.tar.gz
139b3264c70a26c1895b7ae123d361f90935fb467b822e4a5580bdcade07f9a288  guix-build-001b1cf01045/output/powerpc64-linux-gnu/bitcoin-001b1cf01045-powerpc64-linux-gnu.tar.gz
142d1fbdc38c66a05d58c05f3391760655326e8b656dfe490627bcceaa6e29d7c1  guix-build-001b1cf01045/output/riscv64-linux-gnu/SHA256SUMS.part
156b20bedd0116c6790e9edf349a914f50efe444e4e6edcc0c46c48706b66217ae  guix-build-001b1cf01045/output/riscv64-linux-gnu/bitcoin-001b1cf01045-riscv64-linux-gnu-debug.tar.gz
16490579ecf6b8a7b6d6a276d511186b7f8d762a31fae25f39d0a513928b3ae8fe  guix-build-001b1cf01045/output/riscv64-linux-gnu/bitcoin-001b1cf01045-riscv64-linux-gnu.tar.gz
177941addc7669097a27d8208673c558fb269c86fa7f78d2e53c0a0cc17df47a8a  guix-build-001b1cf01045/output/x86_64-apple-darwin/SHA256SUMS.part
1895b260680fdcda7674e85e29017e98671236fc00d65436a67b109fdc9bf7183d  guix-build-001b1cf01045/output/x86_64-apple-darwin/bitcoin-001b1cf01045-x86_64-apple-darwin-unsigned.tar.gz
190c7b959445ce1b30a509502fae56faeac03349c497ccc9aa2e24c9a1e26c5562  guix-build-001b1cf01045/output/x86_64-apple-darwin/bitcoin-001b1cf01045-x86_64-apple-darwin-unsigned.zip
2051ae91ae7d1eefcc3260b2bb2876ec2c0c75bc4b9bb81e9b89f0fdabce72af28  guix-build-001b1cf01045/output/x86_64-apple-darwin/bitcoin-001b1cf01045-x86_64-apple-darwin.tar.gz
21ed5773a890bf66366c5dd891e103d01964dca5ecede308c8da1dad8b69a0c369  guix-build-001b1cf01045/output/x86_64-linux-gnu/SHA256SUMS.part
224dca5d09d5781e92658713f5275cef98463a2cd1dd944c735e633369a692b03d  guix-build-001b1cf01045/output/x86_64-linux-gnu/bitcoin-001b1cf01045-x86_64-linux-gnu-debug.tar.gz
23d4865bfa860a0dd3668e65b4190560cede30eb1e6ba1a67b80a7da33f8b513f5  guix-build-001b1cf01045/output/x86_64-linux-gnu/bitcoin-001b1cf01045-x86_64-linux-gnu.tar.gz
2414ec6517c4f19145285d637745dd21e57277375427633b3007b8fe81de6a9f80  guix-build-001b1cf01045/output/x86_64-w64-mingw32/SHA256SUMS.part
250030ab8c50b1c3465305464efb251bf81b880a522b4f76f6dc6cff5b0265bf87  guix-build-001b1cf01045/output/x86_64-w64-mingw32/bitcoin-001b1cf01045-win64-debug.zip
2696f7e3905b9be0231db1bb6f6d9ae005abbab767c57be328ef6ce42915df6068  guix-build-001b1cf01045/output/x86_64-w64-mingw32/bitcoin-001b1cf01045-win64-setup-unsigned.exe
27484f54d512af952d7f207e85f2973429edd72e7025e07b006d568dd9f63825d7  guix-build-001b1cf01045/output/x86_64-w64-mingw32/bitcoin-001b1cf01045-win64-unsigned.tar.gz
288389a9f5915e4720b6a994f2b2447f2863b581400ef3724a6f94a99ab5e22d88  guix-build-001b1cf01045/output/x86_64-w64-mingw32/bitcoin-001b1cf01045-win64.zip

DrahtBot removed the label CI failed on Sep 13, 2024

TheCharlatan approved

TheCharlatan commented at 2:07 pm on September 13, 2024: contributor

ACK 001b1cf010453adbb1316a6fa8911398953afe61

fanquake merged this on Sep 13, 2024

fanquake closed this on Sep 13, 2024

fanquake deleted the branch on Sep 13, 2024

DrahtBot commented at 6:11 pm on September 13, 2024: contributor

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

File	commit e43ce250c6fb65cc0c8903296c8ab228539d2204(master)	commit 029b356e6ff4b5eefcf8471331346e035c9e5ce3(master and this pull)
SHA256SUMS.part	`3df04d08e5d9768e...`	`99fa8eb7e18c7e63...`
*-aarch64-linux-gnu-debug.tar.gz	`6de610a63aa146be...`	`73064dd8e56175ee...`
*-aarch64-linux-gnu.tar.gz	`e52256bd2333f5f0...`	`c37c0af73d83430d...`
*-arm-linux-gnueabihf-debug.tar.gz	`4059d01f78087061...`	`5e1220c6be419cd1...`
*-arm-linux-gnueabihf.tar.gz	`4ca53be8ba9e9004...`	`b533356bc16e8883...`
*-arm64-apple-darwin-unsigned.tar.gz	`c8e1ae9bdeff070c...`	`3c9235619f92d81b...`
*-arm64-apple-darwin-unsigned.zip	`78af35f83e55072c...`	`0510f6dca3bd082e...`
*-arm64-apple-darwin.tar.gz	`cd41b2c6f95d8721...`	`d20a0ba61314903c...`
*-powerpc64-linux-gnu-debug.tar.gz	`9961f12ab415e694...`	`b29834d763cbb3fc...`
*-powerpc64-linux-gnu.tar.gz	`d46cb206818af43c...`	`e6651b07d5dfc536...`
*-riscv64-linux-gnu-debug.tar.gz	`253e401cb3ae20f3...`	`4e08d7abdf6d5ad6...`
*-riscv64-linux-gnu.tar.gz	`84b623221169abd3...`	`2a03336ee48f4856...`
*-x86_64-apple-darwin-unsigned.tar.gz	`214819d3149d156e...`	`13e440f62437e9aa...`
*-x86_64-apple-darwin-unsigned.zip	`64caec0234f6f5a4...`	`c1cdb4a76b3f44d8...`
*-x86_64-apple-darwin.tar.gz	`6c98005b03456703...`	`61c8b0460df8690c...`
*-x86_64-linux-gnu-debug.tar.gz	`893fc8dd7e456e43...`	`b0fe5e6afecd59d6...`
*-x86_64-linux-gnu.tar.gz	`69e42fb0a5aca0c0...`	`36311f079ff0ba2a...`
*.tar.gz	`c18b8c9245a5a57c...`	`2f16e671d41fde9d...`
guix_build.log	`e263c61ae47d4e42...`	`9ca220a6b575359a...`
guix_build.log.diff		`935ba2ac366f76e0...`

DrahtBot removed the label DrahtBot Guix build requested on Sep 13, 2024

build: add standard branch-protection to hardening flags for aarch64-linux #30433

Code Coverage

Reviews

Conflicts

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

build: add `standard branch-protection` to hardening flags for aarch64-linux #30433