depends: remove Darwin ENV unsetting

fanquake commented at 10:46 am on July 15, 2024: member

Now that we use the native compiler, and have fixed Qt, and these vars are (almost) unset in Guix, we can remove the unsetting from our compiler command here.

I couldn’t manage to make a darwin-clang-cross only exclusion of -lm work properly for Qt, so opted for just removing the explicit link entirely. I do not think this should have any other unwanted side-effects.

Fixes #21552.

DrahtBot commented at 10:46 am on July 15, 2024: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	TheCharlatan
Concept ACK	hebasto

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

No conflicts as of last run.

DrahtBot added the label Build system on Jul 15, 2024

fanquake added the label DrahtBot Guix build requested on Jul 15, 2024

hebasto commented at 11:20 am on July 15, 2024: member

Concept ACK.

theuni commented at 4:00 pm on July 15, 2024: member

Whoa, this greatly simplifies things. When/why where these removed in guix? I thought they were pretty fundamental there.

I wonder if we should check for the use of these in depends and bail out if they’re set though.

DrahtBot commented at 8:02 pm on July 15, 2024: contributor

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

File	commit 84063a4c4c0a5c8e39de1500b835c3a318eea089(master)	commit d9acd8531664eaa29bfc12e0b027863d5c6b8d09(master and this pull)
SHA256SUMS.part	`e82b4412cf161414...`	`e506ac9236e1d210...`
*-aarch64-linux-gnu-debug.tar.gz	`bd0963db76536b6a...`	`4e7c79566b5789bc...`
*-aarch64-linux-gnu.tar.gz	`272fb923908c3c62...`	`c7a843b7d4421dec...`
*-arm-linux-gnueabihf-debug.tar.gz	`2daf8c152761fa74...`	`3ecda2665f0c8d2d...`
*-arm-linux-gnueabihf.tar.gz	`66c04d6d50db8dc6...`	`d1da2a4093e19ccd...`
*-arm64-apple-darwin-unsigned.tar.gz	`afd8cf68738b1c96...`	`4d7eb596e3a47bc8...`
*-arm64-apple-darwin-unsigned.zip	`b1b92dcb985ea331...`	`9ca002990c99da7e...`
*-arm64-apple-darwin.tar.gz	`477c9cafff3a4c81...`	`38a39ab8533cc38a...`
*-powerpc64-linux-gnu-debug.tar.gz	`d916ed90478aa810...`	`9a06afb42eda8338...`
*-powerpc64-linux-gnu.tar.gz	`5b167afbc96dd090...`	`abf5d8b2874d73cd...`
*-riscv64-linux-gnu-debug.tar.gz	`b9a98ff4f732cb98...`	`1ce183752fb93cbd...`
*-riscv64-linux-gnu.tar.gz	`5aa51e201b82a6e6...`	`4282d368e9499663...`
*-x86_64-apple-darwin-unsigned.tar.gz	`b95b90b04bae3ee7...`	`1401a7e284495a7a...`
*-x86_64-apple-darwin-unsigned.zip	`d26f052fc9a6a44e...`	`983b0af2ad62fc67...`
*-x86_64-apple-darwin.tar.gz	`fe595b5a818d3bff...`	`f070cf596bed7fc8...`
*-x86_64-linux-gnu-debug.tar.gz	`d5c52fd47c972e1d...`	`7aa51088b3d1f259...`
*-x86_64-linux-gnu.tar.gz	`033c8ca7c5211349...`	`2ff9d5ef76b77a2f...`
*.tar.gz	`be279d2e1c6a553e...`	`28e02ad893bddad0...`
guix_build.log	`5162b2fa43f45d9c...`	`7c26f9c6c6cba83f...`
guix_build.log.diff		`9a0632625083676e...`

DrahtBot removed the label DrahtBot Guix build requested on Jul 15, 2024

fanquake force-pushed on Jul 17, 2024

fanquake commented at 4:03 pm on July 17, 2024: member

When/why where these removed in guix? I thought they were pretty fundamental there.

I’ve added some more cleanup here. We can’t remove them entirely (for Darwin) in Guix, because we still need some set during depends, for QT/qmake… However, we can unset them after that, for the main build.

fanquake commented at 12:02 pm on July 18, 2024: member

Assuming that #29723 lands first, the commit here adding a patch for librt will be dropped, as that is also patched out of the CMake side in that PR.

fanquake force-pushed on Jul 20, 2024

fanquake commented at 12:30 pm on July 20, 2024: member

Dropped the (autotools) zeromq commit and rebased on top of #29723.

fanquake commented at 12:45 pm on July 20, 2024: member

Guix build (aarch64):

05447a6b0ed155318747354b9db7972716ba5a5c45c956ca39e979c380fe7b25c  guix-build-298c8192a71e/output/arm64-apple-darwin/SHA256SUMS.part
19bc5df1ade9d2a8d9c469ffcbc72ff064c57658474a028270fbeeb4fafb7cff4  guix-build-298c8192a71e/output/arm64-apple-darwin/bitcoin-298c8192a71e-arm64-apple-darwin-unsigned.tar.gz
27aa774a9731f69379ae994a60c7fef3e33d07ebcb5f70b0cc0224e0640f638e2  guix-build-298c8192a71e/output/arm64-apple-darwin/bitcoin-298c8192a71e-arm64-apple-darwin-unsigned.zip
35e0be95ea55819731fad709dbbf75345fbac4de9e764baa40111d225fca2ecf7  guix-build-298c8192a71e/output/arm64-apple-darwin/bitcoin-298c8192a71e-arm64-apple-darwin.tar.gz
4d7df88817fcc48b0eb80cdc04cd399f34629f4d15c29535a676a0eb8ebe47d9d  guix-build-298c8192a71e/output/dist-archive/bitcoin-298c8192a71e.tar.gz
5a6c604fcb17443886aa710884767d824a9ebf6f99a2da1ba11124fbe0c379b1c  guix-build-298c8192a71e/output/x86_64-apple-darwin/SHA256SUMS.part
62cad928bd4ad6998707a667980ce609c52ef77793415ddf04d9f210a01a3c9fa  guix-build-298c8192a71e/output/x86_64-apple-darwin/bitcoin-298c8192a71e-x86_64-apple-darwin-unsigned.tar.gz
7bf41537390da432fd5e72428f41de96ba31862aa00773522fb9879d780e27e25  guix-build-298c8192a71e/output/x86_64-apple-darwin/bitcoin-298c8192a71e-x86_64-apple-darwin-unsigned.zip
87e869a3790854c00518c194b04c75189036b9661eeaa2f8a0797da25c3c7c073  guix-build-298c8192a71e/output/x86_64-apple-darwin/bitcoin-298c8192a71e-x86_64-apple-darwin.tar.gz

fanquake force-pushed on Jul 22, 2024

fanquake added the label DrahtBot Guix build requested on Jul 22, 2024

DrahtBot commented at 11:25 am on July 23, 2024: contributor

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

File	commit 8754d055c65e11fd2afa59f9e5de7c60a9e0ec23(master)	commit dbaf44cd0adb99153e6b5b9443b2777e91170f66(master and this pull)
SHA256SUMS.part	`d6e6493ade976e0d...`	`38df348bc2a6058d...`
*-aarch64-linux-gnu-debug.tar.gz	`7cfc076ad8f454ea...`	`395660840c7155fe...`
*-aarch64-linux-gnu.tar.gz	`d41bd61202831ba3...`	`ab45840c393e882d...`
*-arm-linux-gnueabihf-debug.tar.gz	`912bbcf745276a50...`	`12dc3d505d126ab2...`
*-arm-linux-gnueabihf.tar.gz	`8c0682e696de8302...`	`16018a8f51022958...`
*-arm64-apple-darwin-unsigned.tar.gz	`dfe0523b3f4cb6f3...`	`e2c107854519c169...`
*-arm64-apple-darwin-unsigned.zip	`ea1ba475f15725a2...`	`84954d21fb82a120...`
*-arm64-apple-darwin.tar.gz	`e1d791be90054e5d...`	`ed0a2a853f5388b6...`
*-powerpc64-linux-gnu-debug.tar.gz	`0687d53371c9d763...`	`95055747b5f5de3a...`
*-powerpc64-linux-gnu.tar.gz	`c5374aa7b2c93e11...`	`68d77ba5e5c67029...`
*-riscv64-linux-gnu-debug.tar.gz	`e93579b19a31ce98...`	`155ff9f92eb683c5...`
*-riscv64-linux-gnu.tar.gz	`7ff41ce672e58033...`	`037cd76a56812672...`
*-x86_64-apple-darwin-unsigned.tar.gz	`b25a790a1d1a81ed...`	`58361ca3ef8a0405...`
*-x86_64-apple-darwin-unsigned.zip	`f30efb740994654d...`	`a23b44c0328c9193...`
*-x86_64-apple-darwin.tar.gz	`a03819d1a7360b2b...`	`bb6b6d28039e35c9...`
*-x86_64-linux-gnu-debug.tar.gz	`cd949492f6e34833...`	`296161e8eae3690b...`
*-x86_64-linux-gnu.tar.gz	`073ddca46f7fef65...`	`d1a46ea624cfb682...`
*.tar.gz	`59cca0c61711199d...`	`4864cf1b602d1236...`
guix_build.log	`41a8872a4896048c...`	`7d0af171d103f54c...`
guix_build.log.diff		`27780f50d152f86f...`

DrahtBot removed the label DrahtBot Guix build requested on Jul 23, 2024

in contrib/guix/libexec/build.sh:81 in 1c0456016a outdated

80+        export CPLUS_INCLUDE_PATH="${NATIVE_GCC}/include/c++:${NATIVE_GCC}/include"
81+        ;;
82+    *)
83+        export C_INCLUDE_PATH="${NATIVE_GCC}/include"
84+        export CPLUS_INCLUDE_PATH="${NATIVE_GCC}/include/c++:${NATIVE_GCC}/include"
85+        export OBJC_INCLUDE_PATH="${NATIVE_GCC}/include"

TheCharlatan commented at 12:20 pm on July 25, 2024:

If I am reading this right, this sets OBJC vars for non-darwin hosts. Is that intended? I would have expected the opposite.

fanquake commented at 12:46 pm on July 25, 2024:

Heh, yea. These should/would only be needed for macOS, and only for Qt-related code. I guess everything still currently builds even with them unset, because when we compile our objc++ code, we would never be looking in any GCC related include/std-lib/related dirs in any case? Will push some changes.

depends: patch explicit -lm usage out of Qt tools 0b2aeee21d

guix: improve ENV unsetting for macOS 1807760f09

depends: remove ENV unsetting for darwin

Now that we use the native compiler, and have fixed Qt, and these vars
are unset it Guix, we can remove the unsetting from our compiler command
here.

Fixes #21552.

bda537f7c4

fanquake force-pushed on Jul 25, 2024

TheCharlatan commented at 7:45 pm on July 25, 2024: contributor

Guix build (aarch64):

 0e54a5bec288e01beccb7329fe623269decbac58c8fca182005660e2e0eab9937  guix-build-bda537f7c484/output/aarch64-linux-gnu/SHA256SUMS.part
 1c4121cc8b7367a3fa16667fce7fae752f243e502e82786be1a4defa512b807fc  guix-build-bda537f7c484/output/aarch64-linux-gnu/bitcoin-bda537f7c484-aarch64-linux-gnu-debug.tar.gz
 2f6d64868fb78b9667fa486052ab2ade488caad03df577aa1cc4d79fa542c48ae  guix-build-bda537f7c484/output/aarch64-linux-gnu/bitcoin-bda537f7c484-aarch64-linux-gnu.tar.gz
 3451ff70d68b6925e467dfe3ae69351004f4bfb4973d45ae8f49cd2928f795c4c  guix-build-bda537f7c484/output/arm-linux-gnueabihf/SHA256SUMS.part
 4869f32187db9fb59f600147c57a166dcc53b78fa5297a750ae416cb01cfce8f0  guix-build-bda537f7c484/output/arm-linux-gnueabihf/bitcoin-bda537f7c484-arm-linux-gnueabihf-debug.tar.gz
 561efedeaae40a022d3cb48a4389adbfa1ec1982c1165615effec2e1523d75263  guix-build-bda537f7c484/output/arm-linux-gnueabihf/bitcoin-bda537f7c484-arm-linux-gnueabihf.tar.gz
 6e3f6d6e8e998bf7e0dae5bfa3b8479091bad2ce87615ee8de16130c6300665cc  guix-build-bda537f7c484/output/arm64-apple-darwin/SHA256SUMS.part
 704ff93a466e8c875c88c57a9d31aece2443cf3f06768f5d87a56235a2c7e46cc  guix-build-bda537f7c484/output/arm64-apple-darwin/bitcoin-bda537f7c484-arm64-apple-darwin-unsigned.tar.gz
 897f31359809acefcdd71750f93ee821c57834ba04015659f7641509046a95ae2  guix-build-bda537f7c484/output/arm64-apple-darwin/bitcoin-bda537f7c484-arm64-apple-darwin-unsigned.zip
 9dcdb54e3a62720f67cede2359cb88c6e5b496727b8e33c7fcf61679436b86c6e  guix-build-bda537f7c484/output/arm64-apple-darwin/bitcoin-bda537f7c484-arm64-apple-darwin.tar.gz
10d2dbfd4d2e22f9b5155b6488773ead04bb8a4e2e087761122a6e08b4ae0ea006  guix-build-bda537f7c484/output/dist-archive/bitcoin-bda537f7c484.tar.gz
11bfb792e4ebaf1b7d42a9f4040e751a5417b79acec24dacc364f2a042b6b19788  guix-build-bda537f7c484/output/powerpc64-linux-gnu/SHA256SUMS.part
1230df3def1db919437ab1a54d283170d6a728e5199e3e9c8ee73871645c91b628  guix-build-bda537f7c484/output/powerpc64-linux-gnu/bitcoin-bda537f7c484-powerpc64-linux-gnu-debug.tar.gz
13184bb34be85a50fa0f6137e17c57fc7c33c37ce10e06d067c24f45bdc49e50e3  guix-build-bda537f7c484/output/powerpc64-linux-gnu/bitcoin-bda537f7c484-powerpc64-linux-gnu.tar.gz
141f92d6f9f9de4bf44b7e1a2a74cdcab20f71297f3271613a55b9ef36924901a9  guix-build-bda537f7c484/output/riscv64-linux-gnu/SHA256SUMS.part
15953506894362070665e16744d5676fa9530e3e58c3d06bbcfe4af77035bf96c9  guix-build-bda537f7c484/output/riscv64-linux-gnu/bitcoin-bda537f7c484-riscv64-linux-gnu-debug.tar.gz
1663a47f60fe7fec1d2a8403a7891b349b4ffd7a2c91af57426ea4ace14dab1ca5  guix-build-bda537f7c484/output/riscv64-linux-gnu/bitcoin-bda537f7c484-riscv64-linux-gnu.tar.gz
1735ca4b44a0f1d633b7a715a13d3447bade13e4405cb10aa6314a4f0f93a10cd8  guix-build-bda537f7c484/output/x86_64-apple-darwin/SHA256SUMS.part
18ae9719518493ef8b411613c973cb37ecc7b21117e84e8695407f01ec948cff90  guix-build-bda537f7c484/output/x86_64-apple-darwin/bitcoin-bda537f7c484-x86_64-apple-darwin-unsigned.tar.gz
19114a95bf0de85371236c1cd5769e78861396243cdfa75baad2f87572f168e358  guix-build-bda537f7c484/output/x86_64-apple-darwin/bitcoin-bda537f7c484-x86_64-apple-darwin-unsigned.zip
20bc57a7676f8bfe4bdb48be5e9a5d29833db65580cbcf66fe91f145e4a3d6cd47  guix-build-bda537f7c484/output/x86_64-apple-darwin/bitcoin-bda537f7c484-x86_64-apple-darwin.tar.gz
21e3597c886089cc37feee7b5683c8062b52d9629288b940c8dbdbda6ca432541c  guix-build-bda537f7c484/output/x86_64-linux-gnu/SHA256SUMS.part
228b7285eb11ec0df84142ec00aa8b9708baa7a69ef9077c6ec5bb9095db7b83b6  guix-build-bda537f7c484/output/x86_64-linux-gnu/bitcoin-bda537f7c484-x86_64-linux-gnu-debug.tar.gz
23eabd4a583dcf08d5712d9853dfc34da3ae9b34e66daa3bea1e919eec8d079459  guix-build-bda537f7c484/output/x86_64-linux-gnu/bitcoin-bda537f7c484-x86_64-linux-gnu.tar.gz
241197b6e04c25512f037cf0467aa08db595f78f0e19f539216ac9a1ece38af1c6  guix-build-bda537f7c484/output/x86_64-w64-mingw32/SHA256SUMS.part
2570845f68e1f4444a5b0ae78d829a5cb2add8d808989942ee28aae52d36ff5ae0  guix-build-bda537f7c484/output/x86_64-w64-mingw32/bitcoin-bda537f7c484-win64-debug.zip
269756e593fc216a12a4adfb3bff4147f44c3f5e73979348176843463095b612ab  guix-build-bda537f7c484/output/x86_64-w64-mingw32/bitcoin-bda537f7c484-win64-setup-unsigned.exe
27f0d8fbce1c4ecc80d65c0d174d49e305b8098ac1b074dcafec8d14e61ba7f859  guix-build-bda537f7c484/output/x86_64-w64-mingw32/bitcoin-bda537f7c484-win64-unsigned.tar.gz
288083b1b4772045331bcf1a9b50676622e639fccf04f16156264a66e006b60905  guix-build-bda537f7c484/output/x86_64-w64-mingw32/bitcoin-bda537f7c484-win64.zip

hebasto commented at 12:17 pm on July 26, 2024: member

My Guix build:

 0x86_64
 1e54a5bec288e01beccb7329fe623269decbac58c8fca182005660e2e0eab9937  guix-build-bda537f7c484/output/aarch64-linux-gnu/SHA256SUMS.part
 2c4121cc8b7367a3fa16667fce7fae752f243e502e82786be1a4defa512b807fc  guix-build-bda537f7c484/output/aarch64-linux-gnu/bitcoin-bda537f7c484-aarch64-linux-gnu-debug.tar.gz
 3f6d64868fb78b9667fa486052ab2ade488caad03df577aa1cc4d79fa542c48ae  guix-build-bda537f7c484/output/aarch64-linux-gnu/bitcoin-bda537f7c484-aarch64-linux-gnu.tar.gz
 4451ff70d68b6925e467dfe3ae69351004f4bfb4973d45ae8f49cd2928f795c4c  guix-build-bda537f7c484/output/arm-linux-gnueabihf/SHA256SUMS.part
 5869f32187db9fb59f600147c57a166dcc53b78fa5297a750ae416cb01cfce8f0  guix-build-bda537f7c484/output/arm-linux-gnueabihf/bitcoin-bda537f7c484-arm-linux-gnueabihf-debug.tar.gz
 661efedeaae40a022d3cb48a4389adbfa1ec1982c1165615effec2e1523d75263  guix-build-bda537f7c484/output/arm-linux-gnueabihf/bitcoin-bda537f7c484-arm-linux-gnueabihf.tar.gz
 7e3f6d6e8e998bf7e0dae5bfa3b8479091bad2ce87615ee8de16130c6300665cc  guix-build-bda537f7c484/output/arm64-apple-darwin/SHA256SUMS.part
 804ff93a466e8c875c88c57a9d31aece2443cf3f06768f5d87a56235a2c7e46cc  guix-build-bda537f7c484/output/arm64-apple-darwin/bitcoin-bda537f7c484-arm64-apple-darwin-unsigned.tar.gz
 997f31359809acefcdd71750f93ee821c57834ba04015659f7641509046a95ae2  guix-build-bda537f7c484/output/arm64-apple-darwin/bitcoin-bda537f7c484-arm64-apple-darwin-unsigned.zip
10dcdb54e3a62720f67cede2359cb88c6e5b496727b8e33c7fcf61679436b86c6e  guix-build-bda537f7c484/output/arm64-apple-darwin/bitcoin-bda537f7c484-arm64-apple-darwin.tar.gz
11d2dbfd4d2e22f9b5155b6488773ead04bb8a4e2e087761122a6e08b4ae0ea006  guix-build-bda537f7c484/output/dist-archive/bitcoin-bda537f7c484.tar.gz
12bfb792e4ebaf1b7d42a9f4040e751a5417b79acec24dacc364f2a042b6b19788  guix-build-bda537f7c484/output/powerpc64-linux-gnu/SHA256SUMS.part
1330df3def1db919437ab1a54d283170d6a728e5199e3e9c8ee73871645c91b628  guix-build-bda537f7c484/output/powerpc64-linux-gnu/bitcoin-bda537f7c484-powerpc64-linux-gnu-debug.tar.gz
14184bb34be85a50fa0f6137e17c57fc7c33c37ce10e06d067c24f45bdc49e50e3  guix-build-bda537f7c484/output/powerpc64-linux-gnu/bitcoin-bda537f7c484-powerpc64-linux-gnu.tar.gz
151f92d6f9f9de4bf44b7e1a2a74cdcab20f71297f3271613a55b9ef36924901a9  guix-build-bda537f7c484/output/riscv64-linux-gnu/SHA256SUMS.part
16953506894362070665e16744d5676fa9530e3e58c3d06bbcfe4af77035bf96c9  guix-build-bda537f7c484/output/riscv64-linux-gnu/bitcoin-bda537f7c484-riscv64-linux-gnu-debug.tar.gz
1763a47f60fe7fec1d2a8403a7891b349b4ffd7a2c91af57426ea4ace14dab1ca5  guix-build-bda537f7c484/output/riscv64-linux-gnu/bitcoin-bda537f7c484-riscv64-linux-gnu.tar.gz
1835ca4b44a0f1d633b7a715a13d3447bade13e4405cb10aa6314a4f0f93a10cd8  guix-build-bda537f7c484/output/x86_64-apple-darwin/SHA256SUMS.part
19ae9719518493ef8b411613c973cb37ecc7b21117e84e8695407f01ec948cff90  guix-build-bda537f7c484/output/x86_64-apple-darwin/bitcoin-bda537f7c484-x86_64-apple-darwin-unsigned.tar.gz
20114a95bf0de85371236c1cd5769e78861396243cdfa75baad2f87572f168e358  guix-build-bda537f7c484/output/x86_64-apple-darwin/bitcoin-bda537f7c484-x86_64-apple-darwin-unsigned.zip
21bc57a7676f8bfe4bdb48be5e9a5d29833db65580cbcf66fe91f145e4a3d6cd47  guix-build-bda537f7c484/output/x86_64-apple-darwin/bitcoin-bda537f7c484-x86_64-apple-darwin.tar.gz
22e3597c886089cc37feee7b5683c8062b52d9629288b940c8dbdbda6ca432541c  guix-build-bda537f7c484/output/x86_64-linux-gnu/SHA256SUMS.part
238b7285eb11ec0df84142ec00aa8b9708baa7a69ef9077c6ec5bb9095db7b83b6  guix-build-bda537f7c484/output/x86_64-linux-gnu/bitcoin-bda537f7c484-x86_64-linux-gnu-debug.tar.gz
24eabd4a583dcf08d5712d9853dfc34da3ae9b34e66daa3bea1e919eec8d079459  guix-build-bda537f7c484/output/x86_64-linux-gnu/bitcoin-bda537f7c484-x86_64-linux-gnu.tar.gz
251197b6e04c25512f037cf0467aa08db595f78f0e19f539216ac9a1ece38af1c6  guix-build-bda537f7c484/output/x86_64-w64-mingw32/SHA256SUMS.part
2670845f68e1f4444a5b0ae78d829a5cb2add8d808989942ee28aae52d36ff5ae0  guix-build-bda537f7c484/output/x86_64-w64-mingw32/bitcoin-bda537f7c484-win64-debug.zip
279756e593fc216a12a4adfb3bff4147f44c3f5e73979348176843463095b612ab  guix-build-bda537f7c484/output/x86_64-w64-mingw32/bitcoin-bda537f7c484-win64-setup-unsigned.exe
28f0d8fbce1c4ecc80d65c0d174d49e305b8098ac1b074dcafec8d14e61ba7f859  guix-build-bda537f7c484/output/x86_64-w64-mingw32/bitcoin-bda537f7c484-win64-unsigned.tar.gz
298083b1b4772045331bcf1a9b50676622e639fccf04f16156264a66e006b60905  guix-build-bda537f7c484/output/x86_64-w64-mingw32/bitcoin-bda537f7c484-win64.zip

TheCharlatan approved

TheCharlatan commented at 3:33 pm on July 27, 2024: contributor

ACK bda537f7c484d61a55a72c5856f2d4420664db8f

Tested the gui on macos 12.7.4

DrahtBot requested review from hebasto on Jul 27, 2024

fanquake merged this on Jul 30, 2024

fanquake closed this on Jul 30, 2024

fanquake deleted the branch on Jul 30, 2024

depends: remove Darwin ENV unsetting #30451

Code Coverage

Reviews

Conflicts

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]