fuzz: reduce keypool size in scriptpubkeyman target #30494

pull brunoerg wants to merge 1 commits into bitcoin:master from brunoerg:2024-07-fuzz-spkm-fix changing 1 files +1 −0
  1. brunoerg commented at 3:57 pm on July 20, 2024: contributor

    Fixes #30476

    This PR reduces keypool size in scriptpubkeyman fuzz target to avoid spend a lot of time in TopUp (which is obviously called by many spkm functions).

    For reference:

    This PR:

    0INFO: Running with entropic power schedule (0xFF, 100).
    1INFO: Seed: 1845055748
    2INFO: Loaded 1 modules   (1225616 inline 8-bit counters): 1225616 [0x106346fe0, 0x106472370), 
    3INFO: Loaded 1 PC tables (1225616 PCs): 1225616 [0x106472370,0x107725c70), 
    4./src/test/fuzz/fuzz: Running 1 inputs 10 time(s) each.
    5Running: ./qa-assets/fuzz_seed_corpus/scriptpubkeyman/c9b8928cecb1edc192fb2d5816b4b7878cdfcf50
    6Executed ./qa-assets/fuzz_seed_corpus/scriptpubkeyman/c9b8928cecb1edc192fb2d5816b4b7878cdfcf50 in 250 ms
    

    Master:

    0INFO: Running with entropic power schedule (0xFF, 100).
    1INFO: Seed: 2004906948
    2INFO: Loaded 1 modules   (1225603 inline 8-bit counters): 1225603 [0x104196f80, 0x1042c2303), 
    3INFO: Loaded 1 PC tables (1225603 PCs): 1225603 [0x1042c2308,0x105575b38), 
    4./src/test/fuzz/fuzz: Running 1 inputs 10 time(s) each.
    5Running: ./qa-assets/fuzz_seed_corpus/scriptpubkeyman/c9b8928cecb1edc192fb2d5816b4b7878cdfcf50
    6Executed ./qa-assets/fuzz_seed_corpus/scriptpubkeyman/c9b8928cecb1edc192fb2d5816b4b7878cdfcf50 in 21016 ms
    
  2. fuzz: reduce keypool size in scriptpubkeyman target dcb4ec9449
  3. DrahtBot commented at 3:57 pm on July 20, 2024: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage

    For detailed information about the code coverage, see the test coverage report.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK maflcko, dergoegge
    Concept ACK Sjors

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #30221 (wallet: Ensure best block matches wallet scan state by achow101)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  4. DrahtBot added the label Tests on Jul 20, 2024
  5. brunoerg renamed this:
    fuzz: reduce keypool size in scriptpubkeyman target
    fuzz: reduce keypool size in `scriptpubkeyman` target
    on Jul 20, 2024
  6. maflcko commented at 8:16 am on July 22, 2024: member

    review ACK dcb4ec944984961e3b40452425a219e15e6ab508

    This implements my suggestion from #30476#issue-2415683883, but I haven’t benchmarked whether it works.

    Edit: According to the CI timing output, it works.

    https://cirrus-ci.com/task/6392536002985984?logs=ci#L6480

    https://cirrus-ci.com/task/6473792925466624?logs=ci#L7201

  7. Sjors commented at 12:45 pm on July 22, 2024: member
    Concept ACK
  8. DrahtBot requested review from Sjors on Jul 22, 2024
  9. fanquake requested review from dergoegge on Jul 22, 2024
  10. dergoegge approved
  11. dergoegge commented at 5:08 pm on July 22, 2024: member
    utACK dcb4ec944984961e3b40452425a219e15e6ab508
  12. fanquake merged this on Jul 22, 2024
  13. fanquake closed this on Jul 22, 2024

  14. brunoerg deleted the branch on Jul 22, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-18 04:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me