Fix lint-spelling warnings

paplorinc commented at 12:01 pm on July 22, 2024: contributor

These warnings were often polluting the CI output, e.g. https://github.com/bitcoin/bitcoin/pull/30499/checks?check_run_id=27745036545

./test/lint/lint-spelling.py

before the change:

 0doc/design/libraries.md:100: targetted ==> targeted
 1doc/developer-notes.md:495: dependant ==> dependent
 2src/bench/sign_transaction.cpp:49: hashIn ==> hashing, hash in
 3src/bitcoin-chainstate.cpp:213: hashIn ==> hashing, hash in
 4src/bitcoin-chainstate.cpp:213: hashIn ==> hashing, hash in
 5src/coins.cpp:24: viewIn ==> viewing, view in
 6src/coins.cpp:24: viewIn ==> viewing, view in
 7src/coins.cpp:29: viewIn ==> viewing, view in
 8src/coins.cpp:29: viewIn ==> viewing, view in
 9src/coins.h:44: outIn ==> outing, out in
10src/coins.h:44: outIn ==> outing, out in
11src/coins.h:45: outIn ==> outing, out in
12src/coins.h:45: outIn ==> outing, out in
13src/coins.h:215: viewIn ==> viewing, view in
14src/coins.h:220: viewIn ==> viewing, view in
15src/primitives/transaction.h:37: hashIn ==> hashing, hash in
16src/primitives/transaction.h:37: hashIn ==> hashing, hash in
17src/protocol.cpp:51: hashIn ==> hashing, hash in
18src/protocol.cpp:51: hashIn ==> hashing, hash in
19src/protocol.h:497: hashIn ==> hashing, hash in
20src/qt/forms/optionsdialog.ui:344: incomin ==> incoming
21src/qt/optionsdialog.cpp:445: proxys ==> proxies
22src/rpc/mining.cpp:987: hashIn ==> hashing, hash in
23src/rpc/mining.cpp:987: hashIn ==> hashing, hash in
24src/script/interpreter.h:298: amountIn ==> amounting, amount in
25src/script/interpreter.h:298: amountIn ==> amounting, amount in
26src/script/interpreter.h:299: amountIn ==> amounting, amount in
27src/script/interpreter.h:299: amountIn ==> amounting, amount in
28src/script/sigcache.h:70: amountIn ==> amounting, amount in
29src/script/sigcache.h:70: amountIn ==> amounting, amount in
30src/signet.cpp:144: amountIn ==> amounting, amount in
31src/test/fuzz/util/net.cpp:386: occured ==> occurred
32src/test/fuzz/util/net.cpp:398: occured ==> occurred
33src/util/vecdeque.h:79: deques ==> dequeues
34src/util/vecdeque.h:160: deques ==> dequeues
35src/util/vecdeque.h:184: deques ==> dequeues
36src/util/vecdeque.h:194: deques ==> dequeues
37src/validation.cpp:2130: re-declared ==> redeclared
38src/validation.h:348: outIn ==> outing, out in
39src/validation.h:349: outIn ==> outing, out in
40test/functional/wallet_bumpfee.py:851: atleast ==> at least

Fix lint-spelling warnings

These warnings were often polluting the CI output, e.g. https://github.com/bitcoin/bitcoin/pull/30499/checks?check_run_id=27745036545

> ./test/lint/lint-spelling.py

before the change:
```
doc/design/libraries.md:100: targetted ==> targeted
doc/developer-notes.md:495: dependant ==> dependent
src/bench/sign_transaction.cpp:49: hashIn ==> hashing, hash in
src/bitcoin-chainstate.cpp:213: hashIn ==> hashing, hash in
src/bitcoin-chainstate.cpp:213: hashIn ==> hashing, hash in
src/coins.cpp:24: viewIn ==> viewing, view in
src/coins.cpp:24: viewIn ==> viewing, view in
src/coins.cpp:29: viewIn ==> viewing, view in
src/coins.cpp:29: viewIn ==> viewing, view in
src/coins.h:44: outIn ==> outing, out in
src/coins.h:44: outIn ==> outing, out in
src/coins.h:45: outIn ==> outing, out in
src/coins.h:45: outIn ==> outing, out in
src/coins.h:215: viewIn ==> viewing, view in
src/coins.h:220: viewIn ==> viewing, view in
src/primitives/transaction.h:37: hashIn ==> hashing, hash in
src/primitives/transaction.h:37: hashIn ==> hashing, hash in
src/protocol.cpp:51: hashIn ==> hashing, hash in
src/protocol.cpp:51: hashIn ==> hashing, hash in
src/protocol.h:497: hashIn ==> hashing, hash in
src/qt/forms/optionsdialog.ui:344: incomin ==> incoming
src/qt/optionsdialog.cpp:445: proxys ==> proxies
src/rpc/mining.cpp:987: hashIn ==> hashing, hash in
src/rpc/mining.cpp:987: hashIn ==> hashing, hash in
src/script/interpreter.h:298: amountIn ==> amounting, amount in
src/script/interpreter.h:298: amountIn ==> amounting, amount in
src/script/interpreter.h:299: amountIn ==> amounting, amount in
src/script/interpreter.h:299: amountIn ==> amounting, amount in
src/script/sigcache.h:70: amountIn ==> amounting, amount in
src/script/sigcache.h:70: amountIn ==> amounting, amount in
src/signet.cpp:144: amountIn ==> amounting, amount in
src/test/fuzz/util/net.cpp:386: occured ==> occurred
src/test/fuzz/util/net.cpp:398: occured ==> occurred
src/util/vecdeque.h:79: deques ==> dequeues
src/util/vecdeque.h:160: deques ==> dequeues
src/util/vecdeque.h:184: deques ==> dequeues
src/util/vecdeque.h:194: deques ==> dequeues
src/validation.cpp:2130: re-declared ==> redeclared
src/validation.h:348: outIn ==> outing, out in
src/validation.h:349: outIn ==> outing, out in
test/functional/wallet_bumpfee.py:851: atleast ==> at least
```

bccfca0382

DrahtBot commented at 12:01 pm on July 22, 2024: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	Sjors, josibake

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Sjors commented at 12:41 pm on July 22, 2024: member

ACK bccfca0382bbf00092db6e7828fc79b6ce399c5d

The new lint failure is unrelated, see #30496. Once fixed, you should rebase this to make sure.

paplorinc commented at 12:47 pm on July 22, 2024: contributor

Thanks for the review @Sjors.

The new lint failure is unrelated, see #30496

Yes, it was the PR that triggered this change

josibake approved

josibake commented at 12:54 pm on July 22, 2024: member

ACK https://github.com/bitcoin/bitcoin/pull/30500/commits/bccfca0382bbf00092db6e7828fc79b6ce399c5d

Ran the linter locally to verify all of the warnings are now fixed.

fanquake merged this on Jul 22, 2024

fanquake closed this on Jul 22, 2024

Fix lint-spelling warnings #30500

Code Coverage

Reviews