Fix lint-spelling warnings #30500

pull l0rinc wants to merge 1 commits into bitcoin:master from l0rinc:paplorinc/codespell changing 7 files +12 −7
  1. l0rinc commented at 12:01 PM on July 22, 2024: contributor

    These warnings were often polluting the CI output, e.g. https://github.com/bitcoin/bitcoin/pull/30499/checks?check_run_id=27745036545

    ./test/lint/lint-spelling.py

    before the change:

    doc/design/libraries.md:100: targetted ==> targeted
    doc/developer-notes.md:495: dependant ==> dependent
    src/bench/sign_transaction.cpp:49: hashIn ==> hashing, hash in
    src/bitcoin-chainstate.cpp:213: hashIn ==> hashing, hash in
    src/bitcoin-chainstate.cpp:213: hashIn ==> hashing, hash in
    src/coins.cpp:24: viewIn ==> viewing, view in
    src/coins.cpp:24: viewIn ==> viewing, view in
    src/coins.cpp:29: viewIn ==> viewing, view in
    src/coins.cpp:29: viewIn ==> viewing, view in
    src/coins.h:44: outIn ==> outing, out in
    src/coins.h:44: outIn ==> outing, out in
    src/coins.h:45: outIn ==> outing, out in
    src/coins.h:45: outIn ==> outing, out in
    src/coins.h:215: viewIn ==> viewing, view in
    src/coins.h:220: viewIn ==> viewing, view in
    src/primitives/transaction.h:37: hashIn ==> hashing, hash in
    src/primitives/transaction.h:37: hashIn ==> hashing, hash in
    src/protocol.cpp:51: hashIn ==> hashing, hash in
    src/protocol.cpp:51: hashIn ==> hashing, hash in
    src/protocol.h:497: hashIn ==> hashing, hash in
    src/qt/forms/optionsdialog.ui:344: incomin ==> incoming
    src/qt/optionsdialog.cpp:445: proxys ==> proxies
    src/rpc/mining.cpp:987: hashIn ==> hashing, hash in
    src/rpc/mining.cpp:987: hashIn ==> hashing, hash in
    src/script/interpreter.h:298: amountIn ==> amounting, amount in
    src/script/interpreter.h:298: amountIn ==> amounting, amount in
    src/script/interpreter.h:299: amountIn ==> amounting, amount in
    src/script/interpreter.h:299: amountIn ==> amounting, amount in
    src/script/sigcache.h:70: amountIn ==> amounting, amount in
    src/script/sigcache.h:70: amountIn ==> amounting, amount in
    src/signet.cpp:144: amountIn ==> amounting, amount in
    src/test/fuzz/util/net.cpp:386: occured ==> occurred
    src/test/fuzz/util/net.cpp:398: occured ==> occurred
    src/util/vecdeque.h:79: deques ==> dequeues
    src/util/vecdeque.h:160: deques ==> dequeues
    src/util/vecdeque.h:184: deques ==> dequeues
    src/util/vecdeque.h:194: deques ==> dequeues
    src/validation.cpp:2130: re-declared ==> redeclared
    src/validation.h:348: outIn ==> outing, out in
    src/validation.h:349: outIn ==> outing, out in
    test/functional/wallet_bumpfee.py:851: atleast ==> at least
    
  2. Fix lint-spelling warnings
    These warnings were often polluting the CI output, e.g. https://github.com/bitcoin/bitcoin/pull/30499/checks?check_run_id=27745036545
    
    > ./test/lint/lint-spelling.py
    
    before the change:
    ```
    doc/design/libraries.md:100: targetted ==> targeted
    doc/developer-notes.md:495: dependant ==> dependent
    src/bench/sign_transaction.cpp:49: hashIn ==> hashing, hash in
    src/bitcoin-chainstate.cpp:213: hashIn ==> hashing, hash in
    src/bitcoin-chainstate.cpp:213: hashIn ==> hashing, hash in
    src/coins.cpp:24: viewIn ==> viewing, view in
    src/coins.cpp:24: viewIn ==> viewing, view in
    src/coins.cpp:29: viewIn ==> viewing, view in
    src/coins.cpp:29: viewIn ==> viewing, view in
    src/coins.h:44: outIn ==> outing, out in
    src/coins.h:44: outIn ==> outing, out in
    src/coins.h:45: outIn ==> outing, out in
    src/coins.h:45: outIn ==> outing, out in
    src/coins.h:215: viewIn ==> viewing, view in
    src/coins.h:220: viewIn ==> viewing, view in
    src/primitives/transaction.h:37: hashIn ==> hashing, hash in
    src/primitives/transaction.h:37: hashIn ==> hashing, hash in
    src/protocol.cpp:51: hashIn ==> hashing, hash in
    src/protocol.cpp:51: hashIn ==> hashing, hash in
    src/protocol.h:497: hashIn ==> hashing, hash in
    src/qt/forms/optionsdialog.ui:344: incomin ==> incoming
    src/qt/optionsdialog.cpp:445: proxys ==> proxies
    src/rpc/mining.cpp:987: hashIn ==> hashing, hash in
    src/rpc/mining.cpp:987: hashIn ==> hashing, hash in
    src/script/interpreter.h:298: amountIn ==> amounting, amount in
    src/script/interpreter.h:298: amountIn ==> amounting, amount in
    src/script/interpreter.h:299: amountIn ==> amounting, amount in
    src/script/interpreter.h:299: amountIn ==> amounting, amount in
    src/script/sigcache.h:70: amountIn ==> amounting, amount in
    src/script/sigcache.h:70: amountIn ==> amounting, amount in
    src/signet.cpp:144: amountIn ==> amounting, amount in
    src/test/fuzz/util/net.cpp:386: occured ==> occurred
    src/test/fuzz/util/net.cpp:398: occured ==> occurred
    src/util/vecdeque.h:79: deques ==> dequeues
    src/util/vecdeque.h:160: deques ==> dequeues
    src/util/vecdeque.h:184: deques ==> dequeues
    src/util/vecdeque.h:194: deques ==> dequeues
    src/validation.cpp:2130: re-declared ==> redeclared
    src/validation.h:348: outIn ==> outing, out in
    src/validation.h:349: outIn ==> outing, out in
    test/functional/wallet_bumpfee.py:851: atleast ==> at least
    ```
    bccfca0382
  3. DrahtBot commented at 12:01 PM on July 22, 2024: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage

    For detailed information about the code coverage, see the test coverage report.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK Sjors, josibake

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. Sjors commented at 12:41 PM on July 22, 2024: member

    ACK bccfca0382bbf00092db6e7828fc79b6ce399c5d

    The new lint failure is unrelated, see #30496. Once fixed, you should rebase this to make sure.

  5. l0rinc commented at 12:47 PM on July 22, 2024: contributor

    Thanks for the review @Sjors.

    The new lint failure is unrelated, see #30496

    Yes, it was the PR that triggered this change

  6. josibake approved
  7. josibake commented at 12:54 PM on July 22, 2024: member

    ACK https://github.com/bitcoin/bitcoin/pull/30500/commits/bccfca0382bbf00092db6e7828fc79b6ce399c5d

    Ran the linter locally to verify all of the warnings are now fixed.

  8. fanquake merged this on Jul 22, 2024
  9. fanquake closed this on Jul 22, 2024

  10. bitcoin locked this on Jul 22, 2025

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-02 21:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me