depends: Cleanup postprocess commands after switching to CMake

hebasto commented at 10:43 am on July 23, 2024: member

I overlooked this while reviewing #29723, #29835, and #29880.

hebasto added the label Build system on Jul 23, 2024

DrahtBot commented at 10:43 am on July 23, 2024: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	fanquake

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

hebasto commented at 1:06 pm on July 23, 2024: member

My Guix build:

 0x86_64
 1e23e8a489ca99ccd8be77790ce3af8a47355c47783c3e0aa95f1b9d0ff8812c9  guix-build-f624854665ac/output/aarch64-linux-gnu/SHA256SUMS.part
 2ff15f20ffa82de84e3b242de1501712db7fc07a084425e31706324c4d6698f10  guix-build-f624854665ac/output/aarch64-linux-gnu/bitcoin-f624854665ac-aarch64-linux-gnu-debug.tar.gz
 30a3ac5d2a3b426f2ab8249a7876fc0f5dda0dc11d74b7f0a3704c45a22cd68af  guix-build-f624854665ac/output/aarch64-linux-gnu/bitcoin-f624854665ac-aarch64-linux-gnu.tar.gz
 4c350679959f4ae3ad150bb04f116568b6f8a48bf4f7e65403c391b5dd855946a  guix-build-f624854665ac/output/arm-linux-gnueabihf/SHA256SUMS.part
 588f64372f4f6ab744671d9810db1efddca25c5efd2282d5df4865db0c23d383e  guix-build-f624854665ac/output/arm-linux-gnueabihf/bitcoin-f624854665ac-arm-linux-gnueabihf-debug.tar.gz
 6251684d4800843422f47e7a87642d70f0ca42ddc1ee3e07c72e78285ba677a70  guix-build-f624854665ac/output/arm-linux-gnueabihf/bitcoin-f624854665ac-arm-linux-gnueabihf.tar.gz
 786954686e6589000a0632d16036eca02aa789ab1a66e14c056d788119fc35657  guix-build-f624854665ac/output/arm64-apple-darwin/SHA256SUMS.part
 83845e6dd681934584fedbb94909a541ccc78f22b9c7a09262de727c252137625  guix-build-f624854665ac/output/arm64-apple-darwin/bitcoin-f624854665ac-arm64-apple-darwin-unsigned.tar.gz
 98125c43ee681d6bc7205d18a1b41342def9385c42fdba0d367032dc0810b6ec2  guix-build-f624854665ac/output/arm64-apple-darwin/bitcoin-f624854665ac-arm64-apple-darwin-unsigned.zip
10e5415e9180743e3686a2a50dcf49a44913e3f21d90ad9cfcfb05082e708429f1  guix-build-f624854665ac/output/arm64-apple-darwin/bitcoin-f624854665ac-arm64-apple-darwin.tar.gz
11803c16d3834856e45bb6cbb4518ba584680eb0c0035b1be4d2a277eb484354df  guix-build-f624854665ac/output/dist-archive/bitcoin-f624854665ac.tar.gz
12fbaa78b9d12f35558a9ec41bb0f56520159e8bcab7c6783782a375f610c881f3  guix-build-f624854665ac/output/powerpc64-linux-gnu/SHA256SUMS.part
13e303ea0a1297369af981101961cd7f4efea736e50b6d2e4062564216e1b27ebb  guix-build-f624854665ac/output/powerpc64-linux-gnu/bitcoin-f624854665ac-powerpc64-linux-gnu-debug.tar.gz
14a0873523ee9030ead1fcdce257be562b99869bcaff6c99860d7dd09bc976e1a3  guix-build-f624854665ac/output/powerpc64-linux-gnu/bitcoin-f624854665ac-powerpc64-linux-gnu.tar.gz
155061ee5ff65130bc06b13900bf0a79f4c0d0e5ec4a888825e1e6c06caf1cf96b  guix-build-f624854665ac/output/riscv64-linux-gnu/SHA256SUMS.part
160191cf1d51bcf4c1f8b66fc41210cbcd7a4bab5b8240090ba9642f7c270a0e17  guix-build-f624854665ac/output/riscv64-linux-gnu/bitcoin-f624854665ac-riscv64-linux-gnu-debug.tar.gz
17364e502743b9831699d4b6507aa55a280eb372cfb95e2ae45cc9a49ed173c986  guix-build-f624854665ac/output/riscv64-linux-gnu/bitcoin-f624854665ac-riscv64-linux-gnu.tar.gz
18451579d0eba39c3156d0843cd64b460bbd9ac51104e35742ca423119b87ec833  guix-build-f624854665ac/output/x86_64-apple-darwin/SHA256SUMS.part
1909918349486b2572199365f3d9d40994e1c5c9d4a04413dd21a393408bef8dad  guix-build-f624854665ac/output/x86_64-apple-darwin/bitcoin-f624854665ac-x86_64-apple-darwin-unsigned.tar.gz
20de7773c2e29b53eaa816787434576c7d79491e21e4b46633f00d63d367336c08  guix-build-f624854665ac/output/x86_64-apple-darwin/bitcoin-f624854665ac-x86_64-apple-darwin-unsigned.zip
21661cdd1216c426e26af7d079c7551232f35348ec822ff4f8206ec56714a6d6f3  guix-build-f624854665ac/output/x86_64-apple-darwin/bitcoin-f624854665ac-x86_64-apple-darwin.tar.gz
2261ca2c2362e52a46cbfb56915880cf93f9708363971e5435e05c9c7fc4a93dbd  guix-build-f624854665ac/output/x86_64-linux-gnu/SHA256SUMS.part
23442164981ce0e312f01669b4d87da369d0f7ff54e452487493d9c2570b8c15b0  guix-build-f624854665ac/output/x86_64-linux-gnu/bitcoin-f624854665ac-x86_64-linux-gnu-debug.tar.gz
24b48b60c3dc72f9416bda96f1c3319a322ffa801e48650297cfb6b6af6c4545ae  guix-build-f624854665ac/output/x86_64-linux-gnu/bitcoin-f624854665ac-x86_64-linux-gnu.tar.gz
25939d6f8a16e8b3b90831422d041626ef1c15fb88206ec3b0eb3df616bcaafe6a  guix-build-f624854665ac/output/x86_64-w64-mingw32/SHA256SUMS.part
264a02c0d6e181303e9d88d18e51e1087f4db009dc0c326564e99aed2dcee2c96d  guix-build-f624854665ac/output/x86_64-w64-mingw32/bitcoin-f624854665ac-win64-debug.zip
27a94ff9dc4ac87c3d74370c299ad2c3015284ff0d175afc8436ef3e53aecb63da  guix-build-f624854665ac/output/x86_64-w64-mingw32/bitcoin-f624854665ac-win64-setup-unsigned.exe
28bb246f9ffcbb54518c5f4dc23b8b917a44d675879fa3a3c1a14abb332f5c3d8b  guix-build-f624854665ac/output/x86_64-w64-mingw32/bitcoin-f624854665ac-win64-unsigned.tar.gz
29541b7f0005739e6cd1bb4285c1b2cb3b3d6fde492d5b2a2a09555cf275aa263c  guix-build-f624854665ac/output/x86_64-w64-mingw32/bitcoin-f624854665ac-win64.zip

depends: Cleanup postprocess commands after switching to CMake 06d4aab77a

depends: cleanup after miniupnpc build 745bf0fa7e

depends: cleanup after qrencode build a0314c1516

fanquake commented at 11:06 am on July 25, 2024: member

Looks good. Want to pull in the additional CMake cleanup here: https://github.com/fanquake/bitcoin/tree/30506_more_cleanup?

hebasto force-pushed on Jul 25, 2024

hebasto commented at 11:15 am on July 25, 2024: member

Looks good. Want to pull in the additional CMake cleanup here: https://github.com/fanquake/bitcoin/tree/30506_more_cleanup?

Thanks! Pulled.

fanquake approved

fanquake commented at 12:42 pm on July 25, 2024: member

ACK a0314c151679a348d842b68c5ecb7a556700811c Guix build (aarch64):

 0a35aa8777223dbb7fdb3b9f600067303a5846c26a854d7d5aaa41b5fe12a047f  guix-build-a0314c151679/output/aarch64-linux-gnu/SHA256SUMS.part
 1917c0ebbb4c8cbddc6e314a2f6bcee22d9399356b56ecdecd6fb008882a6eb48  guix-build-a0314c151679/output/aarch64-linux-gnu/bitcoin-a0314c151679-aarch64-linux-gnu-debug.tar.gz
 2884d1264b2d8bcb2975c61248f5794fba26c60deb445a07f12b69c17db8c4cc6  guix-build-a0314c151679/output/aarch64-linux-gnu/bitcoin-a0314c151679-aarch64-linux-gnu.tar.gz
 32626ce875616a7d0e1b7f6c8f81e6f2fcb95a0c2dd17f80281bce6355b56e441  guix-build-a0314c151679/output/arm-linux-gnueabihf/SHA256SUMS.part
 4bfe6d4c28d895d055226f3c37a60cf323e9bc302f418d6978bc9872cdb5fe47c  guix-build-a0314c151679/output/arm-linux-gnueabihf/bitcoin-a0314c151679-arm-linux-gnueabihf-debug.tar.gz
 5da4eb522e5e224d3dc38bf6a215fdeab37a9f70ec0ee6d3262ca0feba6b67c45  guix-build-a0314c151679/output/arm-linux-gnueabihf/bitcoin-a0314c151679-arm-linux-gnueabihf.tar.gz
 6e321a506e27acb31d34115095843c136cad8e23f0088e934d29d70baa2933524  guix-build-a0314c151679/output/arm64-apple-darwin/SHA256SUMS.part
 7ad9c4b213b2b3bacedfc9473b2ccf64e0482b450ddaf19ff27ffde630698c421  guix-build-a0314c151679/output/arm64-apple-darwin/bitcoin-a0314c151679-arm64-apple-darwin-unsigned.tar.gz
 8e0de8c6f17b89ac6836901819d4012e55106e46ac0591b107032f4d7d3aa199e  guix-build-a0314c151679/output/arm64-apple-darwin/bitcoin-a0314c151679-arm64-apple-darwin-unsigned.zip
 9aab33e2165cb57f7c2ab6c09ee7fc77d639e3542bee5dd37640003fb2ea58f0e  guix-build-a0314c151679/output/arm64-apple-darwin/bitcoin-a0314c151679-arm64-apple-darwin.tar.gz
10e008683cdd09f41ed7893e638a5693b401e72e195b724b9edac0354e97c10f21  guix-build-a0314c151679/output/dist-archive/bitcoin-a0314c151679.tar.gz
119a153b248716e35acd48a7c7f9b9eb5fcad0a8e98be72d43bfd0ced14ab5e001  guix-build-a0314c151679/output/powerpc64-linux-gnu/SHA256SUMS.part
12b5fe52491dcd888cc38e2e77455e7f186d0c3c408c846cf3a4208c0ca113deee  guix-build-a0314c151679/output/powerpc64-linux-gnu/bitcoin-a0314c151679-powerpc64-linux-gnu-debug.tar.gz
13c211749116804f0b818b8d526c83891b8ec3f89bf344634b7a4773a2e717ece8  guix-build-a0314c151679/output/powerpc64-linux-gnu/bitcoin-a0314c151679-powerpc64-linux-gnu.tar.gz
141c20a8fb29fb19b23c9655f506a0c10c842988885313e342f48cea68360ff6bd  guix-build-a0314c151679/output/riscv64-linux-gnu/SHA256SUMS.part
1543c537196114d22e8f86d1c8646ecffa8de7cd8ced0a06b523b5c21c86ec2b84  guix-build-a0314c151679/output/riscv64-linux-gnu/bitcoin-a0314c151679-riscv64-linux-gnu-debug.tar.gz
16f329b0dd9b7602ecb36e6cc721247e0bfb56b3d3bb87b842b6a36c3d18c41819  guix-build-a0314c151679/output/riscv64-linux-gnu/bitcoin-a0314c151679-riscv64-linux-gnu.tar.gz
17b83ff26b772e6d07a4d95da1788bc8dcd1bb3a357b18b351078c58d754c90367  guix-build-a0314c151679/output/x86_64-apple-darwin/SHA256SUMS.part
186c3a8a7b1da14edfe173145b5ab4f22c7a8dfe19ef9b701c94c0748e7bda5c61  guix-build-a0314c151679/output/x86_64-apple-darwin/bitcoin-a0314c151679-x86_64-apple-darwin-unsigned.tar.gz
19f560ac98b03660be3ef617cb90041135e970e8ef1c74604b6098659af9123a3f  guix-build-a0314c151679/output/x86_64-apple-darwin/bitcoin-a0314c151679-x86_64-apple-darwin-unsigned.zip
20ad93b85f9b403c6678df690cdcc63b31db68d3c42c3423f76fd777f42b1513f9  guix-build-a0314c151679/output/x86_64-apple-darwin/bitcoin-a0314c151679-x86_64-apple-darwin.tar.gz
21c98f9665ef4e52eadba6026f227ca29857ccb0d5c0919513911061a6b9f165fd  guix-build-a0314c151679/output/x86_64-linux-gnu/SHA256SUMS.part
220db8159eefbcc720762847cfcc5002047ad36335a7bd7dbb6122b873fce01efc  guix-build-a0314c151679/output/x86_64-linux-gnu/bitcoin-a0314c151679-x86_64-linux-gnu-debug.tar.gz
23dda426b52867dfc6ff858b76f41e95bec03a3c48a26eaec22c40208940b116bd  guix-build-a0314c151679/output/x86_64-linux-gnu/bitcoin-a0314c151679-x86_64-linux-gnu.tar.gz
24f4a66e82e3d6304a77afd13de6d229d72d2f7a05574d97b2aad7e31ac65b2846  guix-build-a0314c151679/output/x86_64-w64-mingw32/SHA256SUMS.part
25715477ee3705dd3fee0c6db0afcb5a36d9bebc746ae3cfce94407ec920753397  guix-build-a0314c151679/output/x86_64-w64-mingw32/bitcoin-a0314c151679-win64-debug.zip
26c90df5179bafb742e0e9e96033b1cf01f55f3da270bcb7ef324ad0551ab3d4aa  guix-build-a0314c151679/output/x86_64-w64-mingw32/bitcoin-a0314c151679-win64-setup-unsigned.exe
2782d7f54376fcaeb1ade794c80dcefaf441ec6b61d81f6818a51b5333eb2c9877  guix-build-a0314c151679/output/x86_64-w64-mingw32/bitcoin-a0314c151679-win64-unsigned.tar.gz
286db355c367524724b7c8de4b082ccdc0f3e6ee2defa494184d8dccd9b5306c77  guix-build-a0314c151679/output/x86_64-w64-mingw32/bitcoin-a0314c151679-win64.zip

fanquake merged this on Jul 25, 2024

fanquake closed this on Jul 25, 2024

hebasto deleted the branch on Jul 25, 2024

depends: Cleanup postprocess commands after switching to CMake #30506

Code Coverage

Reviews