test: Add missing --v1transport to feature_proxy.py #30531

pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2407-nov2 changing 1 files +2 −2
  1. maflcko commented at 2:47 PM on July 26, 2024: member

    Fixes #29871

    V2 is enabled via:

    ci/test/00_setup_env_i686_multiprocess.sh:15:export TEST_RUNNER_EXTRA="--v2transport"
    

    However, that seems premature, given that the test fails intermittently (or reproducibly) on some machines:

    $ while test/functional/feature_proxy.py --v2transport --valgrind  ; do true ; done 
    2024-07-25T10:09:50.233000Z TestFramework (INFO): PRNG seed is: 4706088440128402104
    2024-07-25T10:09:50.234000Z TestFramework (INFO): Initializing test directory /tmp/bitcoin_func_test__c5c1wwl
    2024-07-25T10:10:16.428000Z TestFramework (ERROR): Assertion failed
    
    AssertionError: not(bytearray(b'node.noumenon') == b'fc00:1:2:3:4:5:6:7')
    

    Fix it by temporarily disabling it.

    In the future, the test can be fixed and this can be enabled again.

  2. test: Add missing --v1transport to feature_proxy.py fa7010643a
  3. DrahtBot commented at 2:47 PM on July 26, 2024: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage

    For detailed information about the code coverage, see the test coverage report.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK mzumsande

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. DrahtBot added the label Tests on Jul 26, 2024
  5. mzumsande commented at 4:27 PM on July 26, 2024: contributor

    utACK fa7010643a44f87e0655e39afba4a455591c72dc

    I can try to find out why it's failing with v2, but only next week.

  6. mzumsande commented at 7:49 PM on July 29, 2024: contributor

    See #30545 for an explanation and a fix within feature_proxy.py.

  7. maflcko closed this on Jul 30, 2024

  8. maflcko deleted the branch on Jul 30, 2024
  9. bitcoin locked this on Jul 30, 2025

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-24 09:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me