refactor: move `SignSignature` helpers to test utils #30561

1. 
   theStack commented at 1:46 PM on July 31, 2024: contributor

   These helpers haven't been used in production code since segwit was merged more than eight years ago (see commit 605e8473, PR #8149), so it seems appropriate to move them to the test utils module. As suggested by instagibbs, see #30352 (review).

2. 
   DrahtBot commented at 1:46 PM on July 31, 2024: contributor

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--006a51241073e994b41acfe9ec718e94-->

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   <!--021abf342d371248e50ceaed478a90ca-->

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	pablomartin4btc, instagibbs
   Concept ACK	darosior, tdb3

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   <!--174a7506f384e20aa4161008e828411d-->

   Conflicts

   No conflicts as of last run.

3. DrahtBot added the label Refactoring on Jul 31, 2024
4. 
   instagibbs commented at 2:30 PM on July 31, 2024: member

   concept ACK

   (after we merge #30352 )

5. 
   darosior commented at 2:54 PM on July 31, 2024: member

   Concept ACK

6. 
   tdb3 commented at 1:55 AM on August 1, 2024: contributor

   Concept ACK. Seems like a reasonable refactor.

7. DrahtBot added the label CI failed on Aug 26, 2024
8. theStack force-pushed on Aug 26, 2024
9. DrahtBot removed the label CI failed on Aug 27, 2024
10. DrahtBot added the label Needs rebase on Sep 4, 2024
11. refactor: move `SignSignature` helpers to test utils

    These helpers haven't been used in production code since segwit was
    merged more than eight years ago (see commit 605e8473, PR #8149),
    so it seems appropriate to move them to the test utils module.
    
    Can be reviewed via `--color-moved=dimmed-zebra`.

    58499b00d0
12. theStack force-pushed on Sep 4, 2024
13. 
    theStack commented at 9:06 PM on September 4, 2024: contributor

    Rebased on master, needed after #30784 got merged.

14. DrahtBot removed the label Needs rebase on Sep 4, 2024
15. DrahtBot added the label CI failed on Sep 8, 2024
16. DrahtBot removed the label CI failed on Sep 9, 2024
17. DrahtBot added the label CI failed on Sep 18, 2024
18. DrahtBot removed the label CI failed on Sep 18, 2024
19. DrahtBot added the label CI failed on Sep 18, 2024
20. DrahtBot removed the label CI failed on Sep 19, 2024
21. 
    pablomartin4btc commented at 1:37 PM on September 20, 2024: member

    ACK 58499b00d0ad1c83e433caa8fcc0e5d3fd3f2070

    The helpers are already used exclusively within the test code; this is a suitable cleanup.

22. DrahtBot requested review from darosior on Sep 20, 2024
23. DrahtBot requested review from tdb3 on Sep 20, 2024
24. DrahtBot requested review from instagibbs on Sep 20, 2024
25. 
    instagibbs commented at 2:20 PM on September 20, 2024: member

    ACK 58499b00d0ad1c83e433caa8fcc0e5d3fd3f2070

    thanks for the cleanup!

26. fanquake merged this on Sep 20, 2024
27. fanquake closed this on Sep 20, 2024

    ---

28. theStack deleted the branch on Sep 27, 2024
29. TheCharlatan referenced this in commit 8bb47d4c2c on Nov 2, 2024
30. bitcoin locked this on Sep 27, 2025

Review Requested
instagibbsdarosiortdb3