get miniupnpc from ssl, this reverts commit 21b8a14d37c19ce292d5529597e0d52338db48a9 #30564

1. 
   justinvforvendetta commented at 10:02 pm on July 31, 2024: contributor

   the tuxfamily mirror is back up, revert back to an SSL source
2. 
   DrahtBot commented at 10:02 pm on July 31, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   Reviews

   See the guideline for information on the review process. A summary of reviews will appear here.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #30301 (depends: bump miniupnpc to 2.2.8 by theuni)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

3. 
   maflcko commented at 6:06 am on August 1, 2024: member

   Please refer to the commit that this is reverting in the commit message. Git can do it all for you, if you type:

   0git revert 21b8a14d37c19ce292d5529597e0d52338db48a9
   

4. justinvforvendetta renamed this:
   get miniupnpc from ssl
   get miniupnpc from ssl, reverts 21b8a14d37c19ce292d5529597e0d52338db48a9
   on Aug 1, 2024
5. justinvforvendetta renamed this:
   get miniupnpc from ssl, reverts 21b8a14d37c19ce292d5529597e0d52338db48a9
   get miniupnpc from ssl, reverts https://github.com/bitcoin/bitcoin/commit/21b8a14d37c19ce292d5529597e0d52338db48a9
   on Aug 1, 2024
6. justinvforvendetta renamed this:
   get miniupnpc from ssl, reverts https://github.com/bitcoin/bitcoin/commit/21b8a14d37c19ce292d5529597e0d52338db48a9
   get miniupnpc from ssl, reverts 21b8a14d37c19ce292d5529597e0d52338db48a9
   on Aug 1, 2024
7. justinvforvendetta renamed this:
   get miniupnpc from ssl, reverts 21b8a14d37c19ce292d5529597e0d52338db48a9
   get miniupnpc from ssl, this reverts commit 21b8a14d37c19ce292d5529597e0d52338db48a9
   on Aug 1, 2024
8. 
   justinvforvendetta commented at 2:35 pm on August 1, 2024: contributor

   thanks for the heads up @maflcko! until the changes and bump in version are pushed, its important to pull depends from ssl sources.
9. 
   willcl-ark commented at 3:39 pm on August 6, 2024: member

   @justinvforvendetta you’ve changed the PR title here, but not the commit message. Running the command that @maflcko gave on master will generate a specific revert commit with the expected title.
10. justinvforvendetta force-pushed on Aug 7, 2024
11. get miniupnpc from ssl, this reverts commit 21b8a14d37c19ce292d5529597e0d52338db48a9

    tuxfamily mirror is back up, revert back to SSL source

    4a470ba654
12. 
    justinvforvendetta commented at 7:10 pm on August 7, 2024: contributor

    @willcl-ark fixed it. i misinterpreted, thanks
13. 
    fanquake commented at 7:18 pm on August 7, 2024: member

    fixed it. i misinterpreted, thanks

    Thanks, but you’ve still misinterpreted. You should literally type:

    0git revert 21b8a14d37c19ce292d5529597e0d52338db48a9
    

    which will give a commit like this:

     0commit 3e36c5c07a32b24a10a4ded17ccd129717fb0c82 (HEAD -> master)
     1Author: fanquake <fanquake@gmail.com>
     2Date:   Wed Aug 7 20:18:15 2024 +0100
     3
     4    Revert "depends: Fetch miniupnpc sources from an alternative website"
     5    
     6    This reverts commit 21b8a14d37c19ce292d5529597e0d52338db48a9.
     7
     8diff --git a/depends/packages/miniupnpc.mk b/depends/packages/miniupnpc.mk
     9index 91d71a71b6..f9e114b495 100644
    10--- a/depends/packages/miniupnpc.mk
    11+++ b/depends/packages/miniupnpc.mk
    12@@ -1,6 +1,6 @@
    13 package=miniupnpc
    14 $(package)_version=2.2.7
    15-$(package)_download_path=http://miniupnp.free.fr/files/
    16+$(package)_download_path=https://miniupnp.tuxfamily.org/files/
    17 $(package)_file_name=$(package)-$($(package)_version).tar.gz
    18 $(package)_sha256_hash=b0c3a27056840fd0ec9328a5a9bac3dc5e0ec6d2e8733349cf577b0aa1e70ac1
    19 $(package)_patches=dont_leak_info.patch cmake_get_src_addr.patch fix_windows_snprintf.patch
    

14. justinvforvendetta closed this on Aug 7, 2024

    ---

15. bitcoin locked this on Aug 12, 2024

Contributors
justinvforvendetta DrahtBot maflcko willcl-ark fanquake