depends: Fix `zeromq` build on OpenBSD #30565

1. 
   hebasto commented at 10:45 PM on July 31, 2024: member

   On the master branch @ 66e82dc90c598c9c42ff980693ef5367a845e1d0, the zeromq package fails to build on OpenBSD 7.5:

   [ 19%] Building CXX object CMakeFiles/objects.dir/src/io_thread.cpp.o
   /home/hebasto/bitcoin/depends/work/build/amd64-unknown-openbsd7.5/zeromq/4.3.5-df5b1b9f936/src/io_thread.cpp:14:22: error: static_cast from 'std::nullptr_t' to 'poller_t::handle_t' (aka 'int') is not allowed
       _mailbox_handle (static_cast<poller_t::handle_t> (NULL))
                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   1 error generated.
   

   This regression was overlooked by me in #29723.

   This PR fixes the issue by backporting an upstream commit from https://github.com/zeromq/libzmq/pull/4659.

2. depends: Fix `zeromq` build on OpenBSD 89b1d5c818
3. hebasto added the label Build system on Jul 31, 2024
4. 
   DrahtBot commented at 10:45 PM on July 31, 2024: contributor

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--006a51241073e994b41acfe9ec718e94-->

   Code Coverage

   For detailed information about the code coverage, see the test coverage report.

   <!--021abf342d371248e50ceaed478a90ca-->

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	theStack

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

5. 
   hebasto commented at 10:45 PM on July 31, 2024: member

   Friendly ping @theStack :)

6. hebasto added this to the milestone 28.0 on Aug 1, 2024
7. theStack approved
8. 
   theStack commented at 1:51 AM on August 1, 2024: contributor

   tACK 89b1d5c818a33440c0c497aa78721fb9b0af35a5

   Verified on OpenBSD 7.5 that building the zeromq depends build via

   $ gmake -C depends NO_BOOST=1 NO_LIBEVENT=1 NO_QT=1 NO_SQLITE=1 NO_NATPMP=1 NO_UPNP=1 NO_USDT=1 NO_BDB=1
   

   fails on master (same error message as in the PR description) and succeeds on the PR branch. Checked also that the introduced patch matches https://github.com/zeromq/libzmq/pull/4659/commits/f9a798c9fb26124206ae2a3e72225f6d9dd8c646.

9. fanquake merged this on Aug 1, 2024
10. fanquake closed this on Aug 1, 2024

    ---

11. hebasto deleted the branch on Aug 1, 2024
12. PastaPastaPasta referenced this in commit a6426ed557 on Oct 25, 2024
13. PastaPastaPasta referenced this in commit ddaec964c0 on Oct 27, 2024
14. PastaPastaPasta referenced this in commit 565f2db930 on Oct 27, 2024
15. bitcoin locked this on Aug 1, 2025

Milestone
28.0