test: check that keyless P2A 'signing' via `signrawtransactionwithkey` succeeds #30576

pull theStack wants to merge 1 commits into bitcoin:master from theStack:202408-test-check_keyless_p2a_signing changing 2 files +17 −0

theStack commented at 6:26 PM on August 2, 2024: contributor

This small PR adds a sanity check to verify that transactions with P2A inputs can be 'signed' successfully, using the non-wallet RPC signrawtransactionwithkey. Note that in the this flow, SignStep (which was also extended for the new ANCHOR output type in #30352) is never called, as signing is only tried if the locking script verification isn't successful already. See the review discussion #30352 (review) ff.
test: check that keyless P2A 'signing' via `signrawtransactionwithkey` succeeds 5e87f30f7c
DrahtBot commented at 6:26 PM on August 2, 2024: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Code Coverage

For detailed information about the code coverage, see the test coverage report.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK instagibbs, tdb3, glozow

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
DrahtBot added the label Tests on Aug 2, 2024
instagibbs commented at 6:59 PM on August 2, 2024: member

ACK 5e87f30f7c9f6b276ccace88a55b7f0abced591b
tdb3 approved
tdb3 commented at 12:06 AM on August 3, 2024: contributor

ACK 5e87f30f7c9f6b276ccace88a55b7f0abced591b Nice addition.
Mahmoud198425 approved
glozow commented at 8:41 AM on August 5, 2024: member

code review ACK 5e87f30f7c9f6b276ccace88a55b7f0abced591b

compared this with what I wrote while reviewing p2a, and this is way cleaner
glozow merged this on Aug 5, 2024
glozow closed this on Aug 5, 2024
theStack deleted the branch on Aug 5, 2024
bitcoin locked this on Aug 5, 2025